From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id WImTHA+2GmDWEAAA0tVLHw (envelope-from ) for ; Wed, 03 Feb 2021 14:41:19 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id KBlCGA+2GmDmdwAA1q6Kng (envelope-from ) for ; Wed, 03 Feb 2021 14:41:19 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 373829402D4 for ; Wed, 3 Feb 2021 14:41:19 +0000 (UTC) Received: from localhost ([::1]:34572 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l7JLK-0007Oj-4Y for larch@yhetil.org; Wed, 03 Feb 2021 09:41:18 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:52752) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l7JL5-0007CX-2c for guix-patches@gnu.org; Wed, 03 Feb 2021 09:41:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:54045) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l7JL4-0007ja-O1 for guix-patches@gnu.org; Wed, 03 Feb 2021 09:41:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1l7JL4-0001li-Lr for guix-patches@gnu.org; Wed, 03 Feb 2021 09:41:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#45707] [PATCH] gnu: obs: Update obs to fb347c. References: <875z4963kf.fsf@gmail.com> In-Reply-To: <875z4963kf.fsf@gmail.com> Resent-From: Andrew Tropin Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 03 Feb 2021 14:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45707 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Received: via spool by 45707-done@debbugs.gnu.org id=D45707.16123632466726 (code D ref 45707); Wed, 03 Feb 2021 14:41:02 +0000 Received: (at 45707-done) by debbugs.gnu.org; 3 Feb 2021 14:40:46 +0000 Received: from localhost ([127.0.0.1]:37346 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l7JKn-0001kP-O2 for submit@debbugs.gnu.org; Wed, 03 Feb 2021 09:40:45 -0500 Received: from mail-lf1-f68.google.com ([209.85.167.68]:45444) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l7JKm-0001k3-2W for 45707-done@debbugs.gnu.org; Wed, 03 Feb 2021 09:40:44 -0500 Received: by mail-lf1-f68.google.com with SMTP id q12so33649929lfo.12 for <45707-done@debbugs.gnu.org>; Wed, 03 Feb 2021 06:40:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=trop-in.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:mime-version; bh=1apQWFcctZnP+bl4tu6mC/C+GMQ+XjCvaPnJnVOW24E=; b=kz2c1yHddxHNqQWYwXX844D034cn24LFkOAawTO4HDbk+3k4QdX/08mRAWYQEkuDcs svVxcLc5u5r1jmlrGe1w3+Ns0r2K54R3HN21o9tcf9Mu38c38ANRV3PTlnoEAA8Y1Nvv BOC7/x6FdTUBrkHeEH0qlbtv+8HNzlFrqG51LqyzeBOGrdRobG0V9HQSBaqr6OdUFZxv mlroJYku7izoK1Ic0tf7SRmIxlw1E5ajqpsnmb1sGsTTKZnFUqEyor9mXzfOVioiE4dq 8SpCRjml5QR60lyksqoURcjRjP1sG5PjCHJu+1aqPOTZ5pCJ27xy6bPvdRg/le1EqAx/ HsFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version; bh=1apQWFcctZnP+bl4tu6mC/C+GMQ+XjCvaPnJnVOW24E=; b=NwYT8h0Is1jkTu9jOsUl1V3CMcJtxlSvwpEPqikOeJzbiwWj33ZuKrLYafhEMD3fZp 3rcOxN4oA7olK4kcADW/1+531X/gT53ksgQ+4XlrsbCyy7tL8nNm8n5dukRk6o1ofiEI CDjUHLCLLIdZYTwWkU29ZDJXGWUxN1PW9yrvUWWvwYQisMMb/ER+bFscwOUN0L7cQjmg cEzAjquf7Xka6xCiMLLDBifGWIaVp3ekfVWIHws/ITb8xcFGTdREH2xvYilvfgdQzPRQ jQhBHt3hDMB7GftGtZ3beEDDiGBYdq48HrzOEAwJzbcrkE2Y6bASI8wzDxmsDEX5CLPh 6AXA== X-Gm-Message-State: AOAM533vJgXztk9rcXjTE1LwbvaEm105uZEP9tXz0cM56ccZTmT76BPu 0arp1cwZTwJGmvCG+og0+5qTudE+yzMMoA== X-Google-Smtp-Source: ABdhPJyJllKlnGygB318D92+3UOpQIK7RhGMwsAo76gOrIv5YvfLbJjmSjkMZhHZZdlA9m4VvapCPA== X-Received: by 2002:a05:6512:3046:: with SMTP id b6mr2043861lfb.407.1612363237756; Wed, 03 Feb 2021 06:40:37 -0800 (PST) Received: from ixy (109-252-99-251.nat.spd-mgts.ru. [109.252.99.251]) by smtp.gmail.com with ESMTPSA id r1sm264173lfn.180.2021.02.03.06.40.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Feb 2021 06:40:37 -0800 (PST) From: Andrew Tropin Date: Wed, 03 Feb 2021 17:40:34 +0300 Message-ID: <87mtwlrz8d.fsf@trop.in> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 46113@debbugs.gnu.org, 45707-done@debbugs.gnu.org Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -1.36 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=trop-in.20150623.gappssmtp.com header.s=20150623 header.b=kz2c1yHd; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 373829402D4 X-Spam-Score: -1.36 X-Migadu-Scanner: scn0.migadu.com X-TUID: mi66IP39QYRR > Should we wait for the next OBS release instead of packaging an > arbitrary commit? I'm not in a hurry, but as I explained earlier in this thread [fn:2] it seems relatively safe for me to use this commit and getting back later to 26.1.3 or 26.2.0 or whatever next release will be. > I am not insist on keeping [1], but I do think that is more cleaner > solution. In terms of implememntation I like that [fn:1] prevents double loading of plugins, by excluding obs installation dir from "load-path". However double loading of the same plugin doesn't seem to break anything. Also, OBS_PLUGINS_DIRECTORY variable name maybe a little better than OBS_PLUGINS_PATH as it contains only one path. The problem is that now there are two almost identical mechanisms (one in upstream and one via patch [fn:1]), which can bring some maintanance problems in the future. There are two good option in my opinion: - contribute patch from [fn:1] to upstream (reverting OBS_PLUGINS_PATH) - revert [fn:1] and use OBS_PLUGINS_PATH from upstream If Alexey ready to contibute OBS_PLUGINS_DIRECTORY patch to obs (reverting OBS_PLUGINS_PATH), I would be glad to support it. Otherwise, I would prefer to revert [fn:1] and apply this one. To prevent maintanance problems in the future. * Footnotes [fn:2] http://issues.guix.gnu.org/46113 [fn:1] https://issues.guix.gnu.org/45707 -- Best regards, Andrew Tropin