From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id yAWAIByRK2BBCAAA0tVLHw (envelope-from ) for ; Tue, 16 Feb 2021 09:32:12 +0000 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id ONlPHByRK2C2QQAA1q6Kng (envelope-from ) for ; Tue, 16 Feb 2021 09:32:12 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id C432D2FAA0 for ; Tue, 16 Feb 2021 10:32:11 +0100 (CET) Received: from localhost ([::1]:56496 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lBwiJ-00023J-0P for larch@yhetil.org; Tue, 16 Feb 2021 04:32:11 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:36530) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lBwi9-00020k-Ub for guix-patches@gnu.org; Tue, 16 Feb 2021 04:32:01 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:56070) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lBwi9-0006Te-Ks for guix-patches@gnu.org; Tue, 16 Feb 2021 04:32:01 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lBwi9-0007Q6-Hx for guix-patches@gnu.org; Tue, 16 Feb 2021 04:32:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#43929] gnu: Add pijul. Resent-From: Nicolas Goaziou Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 16 Feb 2021 09:32:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43929 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: John Soo Cc: Julien Lepiller , 43929 <43929@debbugs.gnu.org>, Ludovic =?UTF-8?Q?Court=C3=A8s?= , zimoun Received: via spool by 43929-submit@debbugs.gnu.org id=B43929.161346791528510 (code B ref 43929); Tue, 16 Feb 2021 09:32:01 +0000 Received: (at 43929) by debbugs.gnu.org; 16 Feb 2021 09:31:55 +0000 Received: from localhost ([127.0.0.1]:39383 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lBwi3-0007Pl-CZ for submit@debbugs.gnu.org; Tue, 16 Feb 2021 04:31:55 -0500 Received: from relay1-d.mail.gandi.net ([217.70.183.193]:58349) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lBwi0-0007PX-1J for 43929@debbugs.gnu.org; Tue, 16 Feb 2021 04:31:53 -0500 X-Originating-IP: 185.131.40.67 Received: from localhost (40-67.ipv4.commingeshautdebit.fr [185.131.40.67]) (Authenticated sender: admin@nicolasgoaziou.fr) by relay1-d.mail.gandi.net (Postfix) with ESMTPSA id 9442F24000B; Tue, 16 Feb 2021 09:31:42 +0000 (UTC) From: Nicolas Goaziou References: <87lfgcog2g.fsf@asu.edu> <864kme2w8g.fsf@gmail.com> <2DFC6265-699A-4EA3-8E50-5352B8EA59F6@lepiller.eu> <87a6vvvkxq.fsf@asu.edu> <878saptpbd.fsf@asu.edu> <875z2tdlfh.fsf_-_@asu.edu> Date: Tue, 16 Feb 2021 10:31:41 +0100 In-Reply-To: <875z2tdlfh.fsf_-_@asu.edu> (John Soo's message of "Mon, 15 Feb 2021 14:18:42 -0800") Message-ID: <87mtw4gxz6.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: 0.64 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: C432D2FAA0 X-Spam-Score: 0.64 X-Migadu-Scanner: scn1.migadu.com X-TUID: LiUCHFUG46R7 Hello, John Soo writes: Thank you. I'm adding my grain of salt, if you don't mind! > +(define-public rust-trust-dns-rustls-0.6 > + (package > + (inherit rust-trust-dns-rustls-0.7) > + (name "rust-trust-dns-rustls") AFAICT, rust-trust-dns-rustls-0.6 already inherits from 0.19, so it is not strictly necessary to change this inheritance. > +(define-public rust-yasna-0.1 > + (package > + (name "rust-yasna") > + (version "0.1.3") > + (source > + (origin > + (method url-fetch) > + (uri (crate-uri "yasna" version)) > + (file-name > + (string-append name "-" version ".tar.gz")) > + (sha256 > + (base32 > + "1frcd79rzi6dlly7lldjn2avnhfmj6yxrjsgvb2p1k2zbxdzyc9s")))) > + (build-system cargo-build-system) > + (arguments > + `(#:cargo-inputs > + (("rust-bit-vec" ,rust-bit-vec-0.4) > + ("rust-chrono" ,rust-chrono-0.4) > + ("rust-num" ,rust-num-0.1) > + ("rust-num-bigint" ,rust-num-bigint-0.1)) > + #:cargo-development-inputs > + (("rust-num-traits" ,rust-num-traits-0.2)))) This should have #:skip-build #t as any non-leaf package. > +(define-public rust-thrussh-keys-0.11 [...] > + ("rust-thrussh-libsodium" > + ,rust-thrussh-libsodium-0.1) Nitpick: indentation. > + ("rust-tokio" ,rust-tokio-0.1) > + ("rust-yasna" ,rust-yasna-0.1)) > + #:cargo-development-inputs > + (("rust-env-logger" ,rust-env-logger-0.6) > + ("rust-tempdir" ,rust-tempdir-0.3) > + ("rust-tokio-uds" ,rust-tokio-uds-0.2)))) See above about #:skip-build? > + (home-page "https://pijul.org/thrussh") > + (synopsis > + "Deal with SSH keys in Rust") > + (description > + "This package provides a rust library to deal with SSH keys. Nitpick: rust -> Rust > + ("rust-thrussh-libsodium" > + ,rust-thrussh-libsodium-0.1) Indentation nitpick and #skip-build again :) I will not repeat those in the rest of the message. > + (synopsis > + "Contains function definitions for the Windows API library advapi32") s/Contains // > + (description > + "Contains function definitions for the Windows API library advapi32. > +The winapi crate's types and constants has more details about this > API.") The description needs to be a complete sentence. > + (synopsis > + "Portably retrieve the username of the user running the current thread") s/Portably // > + (description > + "Portably retrieve the user name (and possibly other information in > +future versions) of the user running the current thread.") Could you write it as a full sentence? > +(define-public rust-spmc-0.2 > + (package > + (inherit rust-spmc-0.3) > + (name "rust-spmc") > + (version "0.2.3") > + (source > + (origin > + (method url-fetch) > + (uri (crate-uri "spmc" version)) > + (file-name (string-append name "-" version ".tar.gz")) > + (sha256 > + (base32 "1nhbjc65avbb4nffk6b49spbv7rsmmnrppj2qnx39mhwi57spgiw")))) > + (arguments > + `(#:tests? #f ;; tests hang > + #:cargo-development-inputs > + (("rust-loom" ,rust-loom-0.2)))) > + ;; This package is broken before 0.3 > + ;; Only included for pijul@1 > + (properties `((hidden? . #t))))) I suggest to not bother and use #:skip-build? > +(define-public rust-tokio-tls-0.1 > + (package > + (inherit rust-tokio-tls-0.3) > + (version "0.1.4") > + (source > + (origin > + (method url-fetch) > + (uri (crate-uri "tokio-tls" version)) > + (file-name > + (string-append > + (package-name rust-tokio-tls-0.3) "-" version ".tar.gz")) > + (sha256 > + (base32 > + "04yrdscn8m9qza8ms09pqipbmj6x2q64jgm5n3ipy4b0wl24nbvp")))) > + (arguments > + `(#:skip-build? #t > + #:cargo-inputs > + (("rust-futures" ,rust-futures-0.1) > + ("rust-native-tls" ,rust-native-tls-0.1) > + ("rust-tokio-core" ,rust-tokio-core-0.1) > + ("rust-tokio-io" ,rust-tokio-io-0.1) > + ("rust-tokio-proto" ,rust-tokio-proto-0.1)) > + #:cargo-development-inputs > + (("rust-cfg-if" ,rust-cfg-if-0.1) > + ("rust-env-logger" ,rust-env-logger-0.4) > + ("rust-hyper" ,rust-hyper-0.11) > + ("rust-openssl" ,rust-openssl-0.9) > + ("rust-schannel" ,rust-schannel-0.1) > + ("rust-security-framework" > + ,rust-security-framework-0.1) > + ("rust-tokio-service" ,rust-tokio-service-0.1) > + ("rust-winapi" ,rust-winapi-0.3)))))) Since you use skip-build?, development inputs are not necessary. > +(define-public pijul > + (package > + (name "pijul") > + (version "0.12.2") > + (source > + (origin > + (method url-fetch) > + (uri (crate-uri "pijul" version)) > + (file-name > + (string-append name "-" version ".tar.gz")) > + (sha256 > + (base32 > + "12aqpfd2si70qbvfnn9kvznxyd5g5gsb1kk1q52wm077cd03yapr")))) > + (build-system cargo-build-system) > + (inputs > + `(("clang" ,clang) > + ("libressl" ,libressl) > + ("libsodium" ,libsodium) > + ("nettle" ,nettle) > + ("pkg-config" ,pkg-config))) Shouldn't pgk-config and clang be native-inputs instead? Regards, -- Nicolas Goaziou