From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id RMWPOwh8K2DhRwAA0tVLHw (envelope-from ) for ; Tue, 16 Feb 2021 08:02:16 +0000 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id cNCmNgh8K2DJNgAAbx9fmQ (envelope-from ) for ; Tue, 16 Feb 2021 08:02:16 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 8CAB92C2F3 for ; Tue, 16 Feb 2021 09:02:16 +0100 (CET) Received: from localhost ([::1]:42308 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lBvJH-0004Wr-PV for larch@yhetil.org; Tue, 16 Feb 2021 03:02:15 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:48598) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lBvJ4-0004Ph-Sx for guix-patches@gnu.org; Tue, 16 Feb 2021 03:02:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:55948) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lBvJ4-0008CO-L5 for guix-patches@gnu.org; Tue, 16 Feb 2021 03:02:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lBvJ4-00055P-GN for guix-patches@gnu.org; Tue, 16 Feb 2021 03:02:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#46322] [staging 0/2] Update pulseaudio to 14.2 and move to meson build system Resent-From: Brice Waegeneire Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 16 Feb 2021 08:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46322 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Leo Famulari Cc: 46322@debbugs.gnu.org Received: via spool by 46322-submit@debbugs.gnu.org id=B46322.161346252119537 (code B ref 46322); Tue, 16 Feb 2021 08:02:02 +0000 Received: (at 46322) by debbugs.gnu.org; 16 Feb 2021 08:02:01 +0000 Received: from localhost ([127.0.0.1]:39260 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lBvJ3-000553-1O for submit@debbugs.gnu.org; Tue, 16 Feb 2021 03:02:01 -0500 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:42241) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lBvJ2-00054p-0D for 46322@debbugs.gnu.org; Tue, 16 Feb 2021 03:02:00 -0500 X-Originating-IP: 176.181.186.101 Received: from localhost (i15-les02-ntr-176-181-186-101.sfr.lns.abo.bbox.fr [176.181.186.101]) (Authenticated sender: brice@waegenei.re) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id BE576E0002; Tue, 16 Feb 2021 08:01:52 +0000 (UTC) From: Brice Waegeneire In-Reply-To: (Leo Famulari's message of "Sun, 14 Feb 2021 15:33:52 -0500") References: <20210205075519.2935-1-brice@waegenei.re> <20210205080029.3433-2-brice@waegenei.re> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) Date: Tue, 16 Feb 2021 09:01:52 +0100 Message-ID: <87mtw4785r.fsf_-_@waegenei.re> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -2.36 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 8CAB92C2F3 X-Spam-Score: -2.36 X-Migadu-Scanner: scn1.migadu.com X-TUID: fGzM0+Xs+nJb Hello Leo, Leo Famulari writes: > On Fri, Feb 05, 2021 at 09:00:29AM +0100, Brice Waegeneire wrote: >> * gnu/packages/pulseaudio.scm (pulseaudio)[build-system]: Switch from >> gnu to meson. >> [arguments]: Migrate configure flags for meson. >> [propagated-inputs]: Replace 'gdbm' with 'tdb', upstream default. > >> + `(#:configure-flags >> + (let ((out (assoc-ref %outputs "out"))) >> + (list "-Doss-output=3Ddisable" >> + "-Dbluez5=3Dtrue" >> + "-Dlocalstatedir=3D/var" >> + (string-append "-Dudevrulesdir=3D" >> + out "/lib/udev/rules.d") >> + ;; Ensure the RUNPATH contains all installed library loc= ations. >> + (string-append "-Dc_link_args=3D-Wl,-rpath=3D" >> + out "/lib/pulseaudio:" >> + out "/lib:" >> + out "/lib/pulse-14.2/modules"))) > > We should avoid hard-coding the version string with something like > "/lib/pulse-" ,version "/modules" Done. > Overall LGTM for staging. Maybe you already did this but I recommend > comparing the built outputs of the old and new versions to make sure we > don't accidentally lose any components by using the new build system. No, I hadn't so thank you for the heads up. Esound support isn't availaible with the new build system but that software isn't maintained anymore and pulseaudio devs are looking to drop support for it=C2=B9. Pushed as 0c25529c6c4d1da7483db3db8bdc4a10b580c85b. =C2=B9 https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/blob/b1f599dc= d992e61c5ce2ed870bd913a43bb32deb/NEWS#L73 Cheers, - Brice