From: "Ludovic Courtès" <ludo@gnu.org>
To: Tobias Geerinckx-Rice <me@tobias.gr>
Cc: 47193@debbugs.gnu.org
Subject: [bug#47193] Fancify guix lint -c cve output
Date: Wed, 31 Mar 2021 14:53:00 +0200 [thread overview]
Message-ID: <87mtuja3ir.fsf_-_@gnu.org> (raw)
In-Reply-To: <20210316160653.9891-1-me@tobias.gr> (Tobias Geerinckx-Rice's message of "Tue, 16 Mar 2021 17:06:52 +0100")
Hi!
Tobias Geerinckx-Rice <me@tobias.gr> skribis:
> * guix/lint.scm (check-vulnerabilities): Sort unpatched vulnerabilities
> by ID.
[...]
> (make-warning
> package
> (G_ "probably vulnerable to ~a")
> - (list (string-join (map vulnerability-id unpatched)
> + (list (string-join (map vulnerability-id
> + (sort unpatched vulnerability<))
> ", "))))))))))
Nitpick: it might be a bit clearer done the other way around:
(sort (map vulnerability-id unpatched) cve-id<?)
… where ‘cve-id<?’ is like ‘vulnerability<’ but takes a CVE ID (a
string).
Otherwise LGTM!
Ludo’.
next prev parent reply other threads:[~2021-03-31 12:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-16 16:00 [bug#47193] Fancify guix lint -c cve output Tobias Geerinckx-Rice via Guix-patches via
2021-03-16 16:06 ` [bug#47193] [PATCH 1/2] lint: Sort possible vulnerabilities Tobias Geerinckx-Rice via Guix-patches via
2021-03-16 16:06 ` [bug#47193] [PATCH 2/2] lint: Indicate CVE severity Tobias Geerinckx-Rice via Guix-patches via
2021-03-31 13:03 ` [bug#47193] Fancify guix lint -c cve output Ludovic Courtès
2021-03-31 13:06 ` Léo Le Bouter via Guix-patches via
2021-03-31 20:57 ` Ludovic Courtès
2021-04-01 23:36 ` Léo Le Bouter via Guix-patches via
2021-03-31 12:53 ` Ludovic Courtès [this message]
2021-03-16 18:19 ` Léo Le Bouter via Guix-patches via
2021-03-16 21:12 ` Tobias Geerinckx-Rice via Guix-patches via
2021-03-17 8:13 ` Léo Le Bouter via Guix-patches via
2021-03-17 19:32 ` Tobias Geerinckx-Rice via Guix-patches via
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mtuja3ir.fsf_-_@gnu.org \
--to=ludo@gnu.org \
--cc=47193@debbugs.gnu.org \
--cc=me@tobias.gr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).