From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id wBPmNtTCZ2BtKAAAgWs5BA (envelope-from ) for ; Sat, 03 Apr 2021 03:20:20 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id uVHyMNTCZ2AmFwAAB5/wlQ (envelope-from ) for ; Sat, 03 Apr 2021 01:20:20 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 60B30C30B for ; Sat, 3 Apr 2021 03:20:20 +0200 (CEST) Received: from localhost ([::1]:55938 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lSUxX-0006WO-HW for larch@yhetil.org; Fri, 02 Apr 2021 21:20:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37724) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lSUxH-0006W0-1q for guix-patches@gnu.org; Fri, 02 Apr 2021 21:20:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:49727) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lSUxG-0008B7-CQ for guix-patches@gnu.org; Fri, 02 Apr 2021 21:20:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lSUxG-0001X5-7R for guix-patches@gnu.org; Fri, 02 Apr 2021 21:20:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#47282] [PATCH 00/13] node going forward Resent-From: Timothy Sample Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 03 Apr 2021 01:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47282 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Jelle Licht Cc: 47282-done@debbugs.gnu.org Received: via spool by 47282-done@debbugs.gnu.org id=D47282.16174127975875 (code D ref 47282); Sat, 03 Apr 2021 01:20:02 +0000 Received: (at 47282-done) by debbugs.gnu.org; 3 Apr 2021 01:19:57 +0000 Received: from localhost ([127.0.0.1]:33040 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lSUxB-0001Wh-2n for submit@debbugs.gnu.org; Fri, 02 Apr 2021 21:19:57 -0400 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:39801) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lSUx8-0001WT-Bo for 47282-done@debbugs.gnu.org; Fri, 02 Apr 2021 21:19:55 -0400 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 1B4D35C008B; Fri, 2 Apr 2021 21:19:49 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Fri, 02 Apr 2021 21:19:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=oT+UhkeXUO+EKhMnht63p7vfsjAOLtSPUZ6kgYXjj 4c=; b=txUBRgbw2SxtK6sUuIyo08mZD0edhFH3An2WFGSXwxgtaawlLJ18zyNmY PK4TorjL12s3LjIUCB/ZDoqOGLWqjMXfqy3JPq8oNYesbCemZEGAXO2J4N5UW6XZ 5Qb2lqCfahY+unFZoCBuye/1HlGhiajPTgoZW2IFkhf8jLxqS9vVnmDWH3fi/EMm UC4rAgDklU4owb5bz46/NFUjZrYioPbrYkm+3SSzFD995BF1Tlqnwky3yOdZlo7K kEngD7iMZByOEiQMW7Fpv0gD0DgzPRk5W9maIslvHgFqLF360moz3cwUgfoynO/h xMBQvGFhiCutuYwoY6uNDHfNtwd9A== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudeijedggeegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufhfffgjkfgfgggtgfesthhqredttderjeenucfhrhhomhepvfhimhho thhhhicuufgrmhhplhgvuceoshgrmhhplhgvthesnhhghihrohdrtghomheqnecuggftrf grthhtvghrnhepieduuefhgeegleelveehgedugfeuhfeikefftdevieelgfelhfdvtdfg ieehtefgnecukfhppeejgedrudduiedrudekiedrgeegnecuvehluhhsthgvrhfuihiivg eptdenucfrrghrrghmpehmrghilhhfrhhomhepshgrmhhplhgvthesnhhghihrohdrtgho mh X-ME-Proxy: Received: from mrblack (74-116-186-44.qc.dsl.ebox.net [74.116.186.44]) by mail.messagingengine.com (Postfix) with ESMTPA id 2F9A924005A; Fri, 2 Apr 2021 21:19:48 -0400 (EDT) From: Timothy Sample References: <20210320145706.12308-1-jlicht@fsfe.org> <87k0pprz6n.fsf@ngyro.com> <86ft083bjz.fsf@fsfe.org> Date: Fri, 02 Apr 2021 21:19:46 -0400 In-Reply-To: <86ft083bjz.fsf@fsfe.org> (Jelle Licht's message of "Fri, 02 Apr 2021 18:18:08 +0200") Message-ID: <87mtugjhal.fsf@ngyro.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1617412820; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=oT+UhkeXUO+EKhMnht63p7vfsjAOLtSPUZ6kgYXjj4c=; b=SdCfWiIU9fRS3qUUv8yJoSItFn90dMHf/ICgZvCNAyKEcSQsHOejMOaJi1iKweKQMO4NV/ CSVnsKPK4h67O5Lkc4llVM0Ro20hBfbtYh1Qf5GAA0Lv8znllmrBXsBhO8++y/i2L+zcO+ XjGCESwxiFp9YjEP0NDi+B9QF+nF+Y9UUx8d5h+l3WntdX1w6Jlw8/ksJAHWnNg3VcFl6F NemNfIqj9yq2zlfeCDRg6AGLYGNaFEmX+OKgYfWuptVE4ea/GeETMkr9gwB8JO7EZiDAvQ gb6+03w2wv85pDl3KXnB94P5tQ/AETP1098XsphHxy0ZowwB/mKikQULSDRiGg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1617412820; a=rsa-sha256; cv=none; b=TWZY5F7FPbLCIdKqJHphG5NbNj6YWN1W6uPyTXvcJYKVjT09HEgQgR6g5TM7ya7TOh7XQ6 YZGtXNXa//G3ul4tZTHqkbOPsE7Y/y7criEo4HdZUN9LN7aKWqLfbfwyRI1xDP+j+1izTX LSRC3eWx5IsxUIoQiH+O+ktSzm0/qlHSe7CvQMrxTHUbBnB6zvDlWB4kGyz3bZI8odT8Mz 4fKy5MGX5HQZlGzIEGctSk9hPymRJ+13spNZfHAv/duQgKKMKRQPWCmz3Jv2FjJ8SsOoET l11WiQcNymrjMVGTH4AQjBT6Ui81aeSgXNtKfL0pTpGMZMew6H2eJC47UkiHVw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm2 header.b=txUBRgbw; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.43 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm2 header.b=txUBRgbw; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 60B30C30B X-Spam-Score: -1.43 X-Migadu-Scanner: scn0.migadu.com X-TUID: sb+M6lWmfuyH Hi, Jelle Licht writes: > Timothy Sample writes: > >> =E2=80=A2 Change the =E2=80=9CFix incorrect import semantics=E2=80= =9D comments to =E2=80=9CFix >> imports for esbuild=E2=80=9D. To me, if TypeScript=E2=80=99s tsc = likes the >> imports, they are correct TypeScript (despite the esbuild bug >> report). > > "Something a native speaker of English can make sense of" !=3D "Proper > English", and in that same vein I don't think a commmon mistake with > workaround in place is not a mistake. > > I really don't care about what ends up in the codebase though, as long > as it is clear why we do what we do, which works out just fine with your > comment. Heh. You=E2=80=99re right: it=E2=80=99s not a big deal. Thanks for humour= ing me. :) >> The final result is still a little messy, but I don=E2=80=99t think we s= hould >> hold this back any longer. It=E2=80=99s a significant step forward, and= it puts >> us in better shape to improve things incrementally. >> >> WDYT? Let me know if I made anything worse! :) If the altered patches >> look good to you, I suggest you go ahead and push them. > > I still adressed some of Efraim's remarks, and pushed it to master just > now. Nice!! > There are quite some ways to go from here: > > * Get the 'binary' importer upstreamable (I will continue with this) > > * Properly support cross-compilation of Node and Node-packages > > I had a super quick look at this, but it seems that in building node, > you build intermediate tools that run on the host. Perhaps some our > x-compilation gurus can weigh in. > > * Make a Rome-based build system, once Rome does more than linting, to > help untangle the knot that is JavaScript-packaging Sounds pretty exciting! -- Tim