* [bug#49756] [PATCH][core-updates] build-system: asdf: Remove %build-inputs reference.
@ 2021-07-28 14:13 Mathieu Othacehe
2021-07-28 14:20 ` Mathieu Othacehe
2021-07-29 8:18 ` Ludovic Courtès
0 siblings, 2 replies; 4+ messages in thread
From: Mathieu Othacehe @ 2021-07-28 14:13 UTC (permalink / raw)
To: 49756; +Cc: Mathieu Othacehe
This is a follow-up of 7d873f194ca69d6096d28d7a224ab78e83e34fe1 that removes
the %build-inputs variable.
* guix/build-system/asdf.scm (asdf-build): Remove %build-inputs reference.
---
Hello,
This fixes the asdf based builds on core-updates.
Thanks,
Mathieu
guix/build-system/asdf.scm | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/guix/build-system/asdf.scm b/guix/build-system/asdf.scm
index 79de2ee5ba..f4ad7252df 100644
--- a/guix/build-system/asdf.scm
+++ b/guix/build-system/asdf.scm
@@ -28,7 +28,8 @@
#:use-module (guix search-paths)
#:use-module ((guix build utils)
#:select ((package-name->name+version
- . hyphen-separated-name->name+version)))
+ . hyphen-separated-name->name+version)
+ search-input-file))
#:use-module (guix build-system)
#:use-module (guix build-system gnu)
#:use-module (ice-9 match)
@@ -295,9 +296,9 @@ set up using CL source package conventions."
(with-imported-modules imported-modules
#~(begin
(use-modules #$@(sexp->gexp modules))
- (parameterize ((%lisp (string-append
- (assoc-ref %build-inputs #$lisp-type)
- "/bin/" #$lisp-type))
+ (parameterize ((%lisp (search-input-file
+ #$(input-tuples->gexp inputs)
+ (string-append "bin/" #$lisp-type)))
(%lisp-type #$lisp-type))
(asdf-build #:name #$name
#:source #+source
--
2.32.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [bug#49756] [PATCH][core-updates] build-system: asdf: Remove %build-inputs reference.
2021-07-28 14:13 [bug#49756] [PATCH][core-updates] build-system: asdf: Remove %build-inputs reference Mathieu Othacehe
@ 2021-07-28 14:20 ` Mathieu Othacehe
2021-07-29 8:18 ` Ludovic Courtès
1 sibling, 0 replies; 4+ messages in thread
From: Mathieu Othacehe @ 2021-07-28 14:20 UTC (permalink / raw)
To: 49756
> #:select ((package-name->name+version
> - . hyphen-separated-name->name+version)))
> + . hyphen-separated-name->name+version)
> + search-input-file))
This hunk is not needed.
Mathieu
^ permalink raw reply [flat|nested] 4+ messages in thread
* [bug#49756] [PATCH][core-updates] build-system: asdf: Remove %build-inputs reference.
2021-07-28 14:13 [bug#49756] [PATCH][core-updates] build-system: asdf: Remove %build-inputs reference Mathieu Othacehe
2021-07-28 14:20 ` Mathieu Othacehe
@ 2021-07-29 8:18 ` Ludovic Courtès
2021-07-29 8:29 ` bug#49756: " Mathieu Othacehe
1 sibling, 1 reply; 4+ messages in thread
From: Ludovic Courtès @ 2021-07-29 8:18 UTC (permalink / raw)
To: Mathieu Othacehe; +Cc: 49756
Hi,
Mathieu Othacehe <othacehe@gnu.org> skribis:
> This is a follow-up of 7d873f194ca69d6096d28d7a224ab78e83e34fe1 that removes
> the %build-inputs variable.
>
> * guix/build-system/asdf.scm (asdf-build): Remove %build-inputs reference.
LGTM! (modulo the unnecessary hunk)
Note that I left ‘%build-inputs’ in the “main” build systems, but
semi-intentionally left it out in other build systems, the idea being
that we should no longer need it now, and it was already rarely used.
Thanks,
Ludo’.
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#49756: [PATCH][core-updates] build-system: asdf: Remove %build-inputs reference.
2021-07-29 8:18 ` Ludovic Courtès
@ 2021-07-29 8:29 ` Mathieu Othacehe
0 siblings, 0 replies; 4+ messages in thread
From: Mathieu Othacehe @ 2021-07-29 8:29 UTC (permalink / raw)
To: Ludovic Courtès; +Cc: 49756-done
Hey,
> Note that I left ‘%build-inputs’ in the “main” build systems, but
> semi-intentionally left it out in other build systems, the idea being
> that we should no longer need it now, and it was already rarely used.
I see, thanks for explaining!
Closing this one,
Mathieu
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-07-29 8:30 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-28 14:13 [bug#49756] [PATCH][core-updates] build-system: asdf: Remove %build-inputs reference Mathieu Othacehe
2021-07-28 14:20 ` Mathieu Othacehe
2021-07-29 8:18 ` Ludovic Courtès
2021-07-29 8:29 ` bug#49756: " Mathieu Othacehe
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).