From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id qHcwKIUzZ2E7aQAAgWs5BA (envelope-from ) for ; Wed, 13 Oct 2021 21:29:09 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id oInkI4UzZ2EiJAAA1q6Kng (envelope-from ) for ; Wed, 13 Oct 2021 19:29:09 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 44B7AAC7C for ; Wed, 13 Oct 2021 21:29:09 +0200 (CEST) Received: from localhost ([::1]:40352 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1majw3-0001kb-VU for larch@yhetil.org; Wed, 13 Oct 2021 15:29:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47918) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1majvy-0001kJ-QB for guix-patches@gnu.org; Wed, 13 Oct 2021 15:29:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:50204) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1majvy-0003Qk-I8 for guix-patches@gnu.org; Wed, 13 Oct 2021 15:29:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1majvy-0008RZ-EW for guix-patches@gnu.org; Wed, 13 Oct 2021 15:29:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#51113] [PATCH] gnu: Add snooze. Resent-From: Nicolas Goaziou Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 13 Oct 2021 19:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51113 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 51113@debbugs.gnu.org Cc: jgart@dismail.de X-Debbugs-Original-To: jgart via Guix-patches via X-Debbugs-Original-Cc: jgart , 51113@debbugs.gnu.org Received: via spool by submit@debbugs.gnu.org id=B.163415333632431 (code B ref -1); Wed, 13 Oct 2021 19:29:02 +0000 Received: (at submit) by debbugs.gnu.org; 13 Oct 2021 19:28:56 +0000 Received: from localhost ([127.0.0.1]:33515 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1majvs-0008R0-Dl for submit@debbugs.gnu.org; Wed, 13 Oct 2021 15:28:56 -0400 Received: from lists.gnu.org ([209.51.188.17]:43760) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1majvr-0008Qk-AA for submit@debbugs.gnu.org; Wed, 13 Oct 2021 15:28:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47908) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1majvr-0001is-0r for guix-patches@gnu.org; Wed, 13 Oct 2021 15:28:55 -0400 Received: from relay9-d.mail.gandi.net ([217.70.183.199]:34955) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1majvo-0003Gj-Rn for guix-patches@gnu.org; Wed, 13 Oct 2021 15:28:54 -0400 Received: (Authenticated sender: admin@nicolasgoaziou.fr) by relay9-d.mail.gandi.net (Postfix) with ESMTPSA id 47E67FF802; Wed, 13 Oct 2021 19:28:48 +0000 (UTC) From: Nicolas Goaziou References: <20211010075339.22230-1-jgart@dismail.de> Date: Wed, 13 Oct 2021 21:28:48 +0200 In-Reply-To: <20211010075339.22230-1-jgart@dismail.de> (jgart via Guix-patches via's message of "Sun, 10 Oct 2021 03:53:39 -0400") Message-ID: <87mtnc7mhb.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=217.70.183.199; envelope-from=mail@nicolasgoaziou.fr; helo=relay9-d.mail.gandi.net X-Spam_score_int: -6 X-Spam_score: -0.7 X-Spam_bar: / X-Spam_report: (-0.7 / 5.0 requ) RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1634153349; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post; bh=/aLc7lNe5t9/tXtgDjDwQ1iNmgKuQ0cjDOOqx0gV3bM=; b=kXJRfuBG5mY4Dlx7XmEZXbcVM/l4XOZm+/CxVUbLXy7FFQcv/Wt3lyp92S6oCsyq+EKm6k UHJ774puNrWlY5VPb4poes/rfOGweBd6VxQNnVrULCUpeH8J1NalbrO3Fo7bXBIE0u+ptb wzQmrByfb3LntA4kjXZu3e1Q+lLPvY8HeqinUmvlNVLC5MlNG9zQxO5CrHjFLgWHeJnChF BpjKcUDbhpjqWDm5LZd94uVt7sww89cCUxvkn875BJNVWdoeEiyX8gC1lxWk8E8TwMtxIX xLR8HfkxUpt91TAnPWD6lhdo3S46wnBcJ0IYzR27ZKsTs3XK+7vJTkBgNhvXfg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1634153349; a=rsa-sha256; cv=none; b=CZ4Y6WLlFj+ORo+7ROTp2lUL2PS0RayHhzSZF3ICWG1TxmPgK5Gp7JToAQ5URMB2+zolwD 4EVZ4qGcqGv0z4eMlQvIRnlY4WGQyq/P+t6GL4g8T9l/ze+ZltYG7RhQc6nNAZdYHbBEAI ngkrAhQ7Fw3GIu8AxZ2x5840EkkhLwW5btVUSKI8NOxEFhPcWZOhGweguGa6t7b+1mfCK4 93YVKfuALv5zl+L9mYwiJE7RRLPJ/fadpIKKLmu2toG47YJmwbA8TqC3QyJfhWc5MjKd3g U+7nGeTx8UZteu4Q9dACzFqUKtlOqIF44yTT8WHnRu5inWKyD55eyA3wuNqAQw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -2.41 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 44B7AAC7C X-Spam-Score: -2.41 X-Migadu-Scanner: scn0.migadu.com X-TUID: fg1r9i9YYw2e Hello, jgart via Guix-patches via writes: > * gnu/packages/suckless.scm (snooze): New variable. Thank you. Some comments follow. > + (arguments > + `(#:tests? #f Could you add a comment explaining why tests are disabled? I assume upstream does not provide any. > + #:make-flags > + (list (string-append "CC=" ,(cc-for-target)) > + (string-append "DESTDIR=" %output) > + "PREFIX=") It may be worth explaining in a comment why PREFIX is reset. > + #:phases > + (modify-phases %standard-phases > + (delete 'configure)))) > + (home-page "https://github.com/leahneukirchen/snooze") > + (synopsis "Run a command at a particular time") > + (description > +"@command{snooze} is a new tool for waiting until a particular time and then > +running a command.") I would remove "new" from the description. Otherwise, LGTM. Could you send an updated patch? Regards, -- Nicolas Goaziou