From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: 51113@debbugs.gnu.org
Cc: jgart@dismail.de
Subject: [bug#51113] [PATCH] gnu: Add snooze.
Date: Wed, 13 Oct 2021 21:28:48 +0200 [thread overview]
Message-ID: <87mtnc7mhb.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <20211010075339.22230-1-jgart@dismail.de> (jgart via Guix-patches via's message of "Sun, 10 Oct 2021 03:53:39 -0400")
Hello,
jgart via Guix-patches via <guix-patches@gnu.org> writes:
> * gnu/packages/suckless.scm (snooze): New variable.
Thank you. Some comments follow.
> + (arguments
> + `(#:tests? #f
Could you add a comment explaining why tests are disabled? I assume
upstream does not provide any.
> + #:make-flags
> + (list (string-append "CC=" ,(cc-for-target))
> + (string-append "DESTDIR=" %output)
> + "PREFIX=")
It may be worth explaining in a comment why PREFIX is reset.
> + #:phases
> + (modify-phases %standard-phases
> + (delete 'configure))))
> + (home-page "https://github.com/leahneukirchen/snooze")
> + (synopsis "Run a command at a particular time")
> + (description
> +"@command{snooze} is a new tool for waiting until a particular time and then
> +running a command.")
I would remove "new" from the description.
Otherwise, LGTM. Could you send an updated patch?
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2021-10-13 19:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-10 7:53 [bug#51113] [PATCH] gnu: Add snooze jgart via Guix-patches via
2021-10-13 19:28 ` Nicolas Goaziou [this message]
2021-10-19 6:16 ` jgart via Guix-patches via
2021-10-13 21:28 ` jgart via Guix-patches via
2021-10-21 22:13 ` bug#51113: " Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mtnc7mhb.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=51113@debbugs.gnu.org \
--cc=jgart@dismail.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).