From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id kAM6ANoF1mGemAAAgWs5BA (envelope-from ) for ; Wed, 05 Jan 2022 21:55:54 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id GJEdOdkF1mHLxQAA9RJhRA (envelope-from ) for ; Wed, 05 Jan 2022 21:55:53 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id BDC393F0C6 for ; Wed, 5 Jan 2022 21:55:53 +0100 (CET) Received: from localhost ([::1]:58576 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n5DK4-0002fB-RP for larch@yhetil.org; Wed, 05 Jan 2022 15:55:52 -0500 Received: from eggs.gnu.org ([209.51.188.92]:54786) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n5DJG-0002cU-OI for guix-patches@gnu.org; Wed, 05 Jan 2022 15:55:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:46091) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n5DJG-0004jO-Dj for guix-patches@gnu.org; Wed, 05 Jan 2022 15:55:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1n5DJG-0004yT-Dh for guix-patches@gnu.org; Wed, 05 Jan 2022 15:55:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#52828] [PATCH] Fix Disarchive fallback on Guix System Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 05 Jan 2022 20:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52828 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Timothy Sample Cc: 52828@debbugs.gnu.org Received: via spool by 52828-submit@debbugs.gnu.org id=B52828.164141605319058 (code B ref 52828); Wed, 05 Jan 2022 20:55:02 +0000 Received: (at 52828) by debbugs.gnu.org; 5 Jan 2022 20:54:13 +0000 Received: from localhost ([127.0.0.1]:38994 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n5DIT-0004xI-2N for submit@debbugs.gnu.org; Wed, 05 Jan 2022 15:54:13 -0500 Received: from hera.aquilenet.fr ([185.233.100.1]:44146) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n5DIR-0004x4-7D for 52828@debbugs.gnu.org; Wed, 05 Jan 2022 15:54:11 -0500 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id 7B8882C1; Wed, 5 Jan 2022 21:54:04 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id mxJJt4LJyGwV; Wed, 5 Jan 2022 21:54:03 +0100 (CET) Received: from ribbon (91-160-117-201.subs.proxad.net [91.160.117.201]) by hera.aquilenet.fr (Postfix) with ESMTPSA id 4E5CB112; Wed, 5 Jan 2022 21:54:03 +0100 (CET) From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <877dbpuc2n.fsf@ngyro.com> Date: Wed, 05 Jan 2022 21:54:02 +0100 In-Reply-To: <877dbpuc2n.fsf@ngyro.com> (Timothy Sample's message of "Mon, 27 Dec 2021 13:39:28 -0500") Message-ID: <87mtk9kiol.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spamd-Bar: / X-Rspamd-Server: hera X-Rspamd-Queue-Id: 7B8882C1 X-Spamd-Result: default: False [-0.10 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; MID_RHS_MATCH_FROM(0.00)[] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1641416153; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=RKaAKFot/wAAYLm8jsK0XVP4Krto+S/sCgG9+XZ8/bE=; b=uV5hZ/mfzVd5Q/z+TJgqAdvR2pbf72/QPW+Z5VLSnTS66EHknAuAcWee2Yi3e/AwVo7Pnq bAgzOLw6F6hqnHVenBW3stEGXTnkFzmBnFlpB+DnEXIitIagTHhFTBPqWnA/CBeVPojKo5 iwXBNZ9rx2YPkbBwaqyAZzqZJYA7wplPMPcPAqKMoDsv/yAQRck8N6HdKGctj5Xv+y5kOL 9xpg9aTs4cHOyXUj1ZteuvUgJbWPUhfmSaOjhRpflR3vp3banHI8i84eNOX8+MwfvIlbSJ p1SLI1j1SPhw/hP81ZFvojhj8JFSrNIa2MwqCMiZeENestx+CdNhen2EOBfH1A== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1641416153; a=rsa-sha256; cv=none; b=WPjHh/6f6S9VdaqCKQl7fqAvBuIJrQmPgU7iJeosOCpNn+5ftfP9qZEIPQUxkNygVy0BL1 Ob32e2Oq855Gg22fhrWmklj+V7Is9w2qvAcQnXni0/4+nYs2LOH1Tm7yL0/r2Xex0Cr7NS hxzub1v8tRb/w5TdwiBicOPSWh2zo14HVBF5cQ+ShLpZID3RRf9XxYT3CSmDnHxpviwIUZ yS2ftsGEBxM46hgoHQYDvcclh8uWSeqzuuntCR3+12XfovDWp7eZLQq9oYy0RVBsuerFHu fJCrK2JKs8CT2hFDa3glAhfTSIoeruw1IhNjzADnL84qPRT3iFOJfsiGx38CRQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -2.10 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: BDC393F0C6 X-Spam-Score: -2.10 X-Migadu-Scanner: scn1.migadu.com X-TUID: vQNEpi8WQbfp Hi Timothy, Timothy Sample skribis: > I noticed recently that Disarchive fallback does not work on Guix > System. This is because the =E2=80=98(guix swh)=E2=80=99 module shells o= ut to =E2=80=98tar=E2=80=99 to > extract the tarball that it downloads from SWH. However, when used as > part of =E2=80=98guix perform-download=E2=80=99 via the daemon, =E2=80=98= tar=E2=80=99 is not available. > AFAICS, that the daemon is run with no =E2=80=98PATH=E2=80=99 at all. > > You can confirm this by running (on Guix System): > > $ GUIX_DOWNLOAD_FALLBACK_TEST=3Ddisarchive-mirrors \ > guix build --check -S python-flask > > You should see: > > [...] > Downloading [...] from Software Heritage... > In procedure fport_write: Broken pipe > [...] > > This patch adds =E2=80=98tar=E2=80=99 and =E2=80=98gzip=E2=80=99 to the d= aemon=E2=80=99s =E2=80=98PATH=E2=80=99. To me, this is > the most straight-forward way to fix the issue, but there are others. > Any opinions? > >>>From 2893252c16f3e447eccd0f8d216bfb44b1965c43 Mon Sep 17 00:00:00 2001 > From: Timothy Sample > Date: Thu, 23 Dec 2021 22:32:07 -0500 > Subject: [PATCH] services: guix: Add tar and gzip to PATH. > > * gnu/services/base.scm (guix-shepherd-service): Add the PATH > environment-variable and populate it with tar and gzip. What about uses of guix-daemon on other distros? Perhaps we assume tar and gzip are already on PATH? I=E2=80=99d feel more comfortable with a solution at the package level. In= the =E2=80=98guix=E2=80=99 package, or perhaps in a Makefile.am, we could hard-= code absolute file names of tar and gzip in (guix scripts perform-download) and set PATH from there. We=E2=80=99d need to do the same in (guix self) though. Alternatively, we could change (guix swh) to use Guile-Zlib and the tar implementation of Gash-Utils or that of Disarchive. WDYT? Thanks, Ludo=E2=80=99.