From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id cH8GCs6/1mGNggEAgWs5BA (envelope-from ) for ; Thu, 06 Jan 2022 11:09:18 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id +Iy0As6/1mHlZQAAG6o9tA (envelope-from ) for ; Thu, 06 Jan 2022 11:09:18 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A949514FB4 for ; Thu, 6 Jan 2022 11:09:17 +0100 (CET) Received: from localhost ([::1]:40850 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n5Phs-0003Jd-JT for larch@yhetil.org; Thu, 06 Jan 2022 05:09:16 -0500 Received: from eggs.gnu.org ([209.51.188.92]:53244) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n5Pfj-0007Wb-8n for guix-patches@gnu.org; Thu, 06 Jan 2022 05:07:04 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:46785) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n5Pfi-00036P-1P for guix-patches@gnu.org; Thu, 06 Jan 2022 05:07:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1n5Pfh-0001vX-Ob for guix-patches@gnu.org; Thu, 06 Jan 2022 05:07:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#50072] [PATCH WIP 0/4] Add upstream updater for git-fetch origins. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 06 Jan 2022 10:07:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50072 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxime Devos Cc: Sarah Morgensen , 50072@debbugs.gnu.org, zimoun Received: via spool by 50072-submit@debbugs.gnu.org id=B50072.16414636097389 (code B ref 50072); Thu, 06 Jan 2022 10:07:01 +0000 Received: (at 50072) by debbugs.gnu.org; 6 Jan 2022 10:06:49 +0000 Received: from localhost ([127.0.0.1]:39688 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n5PfI-0001us-4y for submit@debbugs.gnu.org; Thu, 06 Jan 2022 05:06:49 -0500 Received: from hera.aquilenet.fr ([185.233.100.1]:58554) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n5PfC-0001uY-3T for 50072@debbugs.gnu.org; Thu, 06 Jan 2022 05:06:35 -0500 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id 8EF95FF; Thu, 6 Jan 2022 11:06:23 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Jlqxbglj4GnV; Thu, 6 Jan 2022 11:06:22 +0100 (CET) Received: from ribbon (91-160-117-201.subs.proxad.net [91.160.117.201]) by hera.aquilenet.fr (Postfix) with ESMTPSA id 1739B2A8; Thu, 6 Jan 2022 11:06:21 +0100 (CET) From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20220104200643.43374-1-maximedevos@telenet.be> <20220104200643.43374-2-maximedevos@telenet.be> <867dbfcf9n.fsf_-_@gmail.com> <52e7be94d926aa06c2a0132090e8c212381e7900.camel@telenet.be> <86y23u768v.fsf@gmail.com> Date: Thu, 06 Jan 2022 11:06:21 +0100 In-Reply-To: (Maxime Devos's message of "Wed, 05 Jan 2022 12:10:01 +0000") Message-ID: <87mtk9faaq.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spamd-Bar: + X-Rspamd-Server: hera X-Rspamd-Queue-Id: 8EF95FF X-Spamd-Result: default: False [1.40 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FREEMAIL_CC(0.00)[gmail.com,mgsn.dev,debbugs.gnu.org]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; TO_MATCH_ENVRCPT_ALL(0.00)[]; TAGGED_RCPT(0.00)[]; MIME_GOOD(-0.10)[text/plain]; TO_DN_SOME(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; SUSPICIOUS_RECIPS(1.50)[] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1641463757; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=mc78g4LiJrmfW2JQC8+yzZkFxWutkxj20qSjzwutXFs=; b=OJG53B4RsbqePfETPSxo4SEVvTx5p6b4X0oOSniYrWlkaVYtssO4q3iW8ULN4tKNejxY8L NY1yvKSWf8Z9K08SdMdkaH381+VGgbNrflTYLISBlKTuugnwSJmRzMFzz2Qt8Xi4TpBaFR xBMIOAP6EJqpaRQO+Hc9qf07azmL7UEKonz/lR11dtXTIpkq6/tCbBkuCp9Q4NBCfXNotF epiIwIJPEjlH5AaGX4q0B7uJV1RhSxfh6cDHVlk+vBDyYsB3Dh8+0iM9UOjY+wD2RAwafF nPAzGeGJOgpsh4O071xlcELy8X56HUkSiZd7D4YBrBxqlFYEPvxUgBwiwQL4rA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1641463757; a=rsa-sha256; cv=none; b=A7Tw4vYfj+DFJhy9lhShIm+jHEqwEh4GBJbZ4/b36455nY1pBQOTMLcuYfwjqoMRaBNnus pzh6IxjyQna1jSzDxVvDqdmNNmbB1EMLNhb/4pr45yGcLHnxQGsUnC7/sgfJRywumXBTPx iDIkEghymmSrTK+CpEW/SY2i7cGqmR6toQsRehoX+xcZfUBDV5lajvCa2ONPH9BS/hVPHx AU1/QcWmhmDaA8ehg3alKW95n82ATAOIzIUdFnzzjjYLFhJ94Ca8F60OGOjQsexX3VH11v +/p8xfdmYHi1Z9a/0OT0liVxPPI79d2Hji4gLbvny3RlsLA6msmKPRK0apEfrw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -2.90 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: A949514FB4 X-Spam-Score: -2.90 X-Migadu-Scanner: scn0.migadu.com X-TUID: bU2w00hV3RLn Hi, Maxime Devos skribis: > 'auto' is indeed a little ambigious, so I adjusted most calls to > file-hash* to set #:recursive? #true/#false appropriately in=C2=A0v3. > But in this particular case (guix/scripts/refresh.scm), it not known in > advance, so some guesswork is necessary. We could move guesswork at the call site. No big deal IMO, though. > Anyway, these calls to file-hash* are bothering me a little: can't > we just record the hash in the 'upstream-source' record or ask the > daemon for the hash of a store item (*) or something? represents available source that has usually not been downloaded yet (that=E2=80=99s what happens when running =E2=80=98guix refr= esh=E2=80=99 without =E2=80=98-u=E2=80=99), so it cannot contain the hash. > That would complicate this patch series more, so I'd prefer to delay > that for a future patch series. Yes, this series LGTM as-is, but let=E2=80=99s keep these improvements in m= ind. Ludo=E2=80=99.