From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id wKa/LqgsN2LF7QAAgWs5BA (envelope-from ) for ; Sun, 20 Mar 2022 14:31:20 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id CEodLKgsN2L2SwEA9RJhRA (envelope-from ) for ; Sun, 20 Mar 2022 14:31:20 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 347A21A257 for ; Sun, 20 Mar 2022 14:31:20 +0100 (CET) Received: from localhost ([::1]:50160 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nVveQ-0006Aj-Qq for larch@yhetil.org; Sun, 20 Mar 2022 09:31:18 -0400 Received: from eggs.gnu.org ([209.51.188.92]:38798) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nVveA-0006AY-HR for guix-patches@gnu.org; Sun, 20 Mar 2022 09:31:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:39355) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nVveA-0006N0-8i for guix-patches@gnu.org; Sun, 20 Mar 2022 09:31:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nVveA-0007oz-06 for guix-patches@gnu.org; Sun, 20 Mar 2022 09:31:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#54474] [PATCH 1/6] gnu: Add emacs-logos. Resent-From: Nicolas Goaziou Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 20 Mar 2022 13:31:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54474 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Jai Vetrivelan Cc: 54474@debbugs.gnu.org Received: via spool by 54474-submit@debbugs.gnu.org id=B54474.164778303930035 (code B ref 54474); Sun, 20 Mar 2022 13:31:01 +0000 Received: (at 54474) by debbugs.gnu.org; 20 Mar 2022 13:30:39 +0000 Received: from localhost ([127.0.0.1]:33252 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nVvdm-0007oN-MF for submit@debbugs.gnu.org; Sun, 20 Mar 2022 09:30:38 -0400 Received: from relay6-d.mail.gandi.net ([217.70.183.198]:52923) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nVvdk-0007o6-DS for 54474@debbugs.gnu.org; Sun, 20 Mar 2022 09:30:37 -0400 Received: (Authenticated sender: admin@nicolasgoaziou.fr) by mail.gandi.net (Postfix) with ESMTPSA id 60C40C0002; Sun, 20 Mar 2022 13:30:29 +0000 (UTC) From: Nicolas Goaziou In-Reply-To: <87v8w8bw4y.fsf@gmail.com> (Jai Vetrivelan's message of "Sun, 20 Mar 2022 18:48:05 +0530") References: <87y214bw95.fsf@gmail.com> <87v8w8bw4y.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) Date: Sun, 20 Mar 2022 14:30:28 +0100 Message-ID: <87mthksqdn.fsf@nicolasgoaziou.fr> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1647783080; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post; bh=sZOZ9st1XAXxcWkhSYJvuw7O7GvjAhueb5M+swpX9dA=; b=h+oakr0vfMdk1XssRX4CRy0TVVk6CXHaH5j8zXl0+4PiLBrMZTBOzGh3IPiSmlW33tpMvo 2gvIVXDApan5sJ4RYBLHkRqL4Nw209xbMG3sSPKZaK9o/VI0Rx7EUurFNeSKVfvmZd5PTN KRA+w1IrEgv9GzXR1dCq7r+3IK/EH+XCoizIjbmc/qsfMexM1AI58QtBTmEYVcfPxvWhie 2Etxlu43RhS+mRUvdvleM6o4x7QICHBkA23JmCCWww/xUS/fZH1x+R92X3bMOMV9g6dr3G MBcSKXTdcpjeevJh+O/omf+wUoO5B6b88OqGShOI7T2SYy7mEYBi1DdLDDVAYw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1647783080; a=rsa-sha256; cv=none; b=j6m/E+RDIMgrjBy4El1gqoVle2dsugHlKSF9PzouJbaAJpBvQSJZZOySjF55gjeHt/Jvwk NC9S/FAyK6QVJ/5gd3BMRjYFIybaP9zh5lmDEwWg+6vVOHSb+OkUZ0XQ+dGlxw1SkqKBmp lPr4X7dTkuipgJWDoWfBzg3JPgQle8jYsJlVBTTasylIJQ7DZ6fSSAX3AvAhQ5dqiVRc66 mH3RceD2KTR1ggcmoGbKip/+dlP3HhUihFcSuaFGItp70QzN3EkPJk6xEGHxXzRZCJRYlG 9rFxmJWRDhaNBsNnzkskZml4G+c3LT/hQmN2Y8bwp2npmr5FYSxl12AW8X9wBA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.43 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 347A21A257 X-Spam-Score: -3.43 X-Migadu-Scanner: scn0.migadu.com X-TUID: gkdrPFHD5qG+ Hello, Jai Vetrivelan writes: > Subject: [PATCH 1/6] gnu: Add emacs-logos. > > * gnu/packages/emacs-xyz.scm (emacs-logos): New variable. Thanks. Some comments follow. > (source (origin > (method git-fetch) > (uri (git-reference > (url "https://gitlab.com/protesilaos/logos.git/") You can drop the ".git" suffix, as mentioned by "guix lint". > + (arguments > + `(#:phases You should use G-expressions here, if only to avoid writing (assoc-ref outputs "out") which is too low level. So: (arguments (list #:phases #~(modifiy phases ...))) > + (modify-phases %standard-phases > + (add-after 'install 'makeinfo > + (lambda* (#:key outputs #:allow-other-keys) Here, this would become (lambda _ ...) > + (invoke "emacs" > + "--batch" > + "--eval=(require 'ox-texinfo)" > + "--eval=(find-file \"README.org\")" > + "--eval=(org-texinfo-export-to-info)") > + (install-file "logos.info" > + (string-append (assoc-ref outputs "out") > + "/share/info"))))))) And here: (install-file "logos.info" (string-append #$output "/share/info")) The same goes for other packages. Could you send updated patches? Regards, -- Nicolas Goaziou