From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id GF6IM7fXpGJlFQEAbAwnHQ (envelope-from ) for ; Sat, 11 Jun 2022 19:58:15 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id aP55M7fXpGIxgwEA9RJhRA (envelope-from ) for ; Sat, 11 Jun 2022 19:58:15 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 8B4BA2BD08 for ; Sat, 11 Jun 2022 19:58:14 +0200 (CEST) Received: from localhost ([::1]:50512 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o05NF-0005i0-Fj for larch@yhetil.org; Sat, 11 Jun 2022 13:58:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49594) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o05N5-0005hP-4S for guix-patches@gnu.org; Sat, 11 Jun 2022 13:58:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:59981) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o05N4-0005eL-QA for guix-patches@gnu.org; Sat, 11 Jun 2022 13:58:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1o05N4-0002rZ-PU for guix-patches@gnu.org; Sat, 11 Jun 2022 13:58:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#54529] Checking In Resent-From: Christine Lemmer-Webber Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 11 Jun 2022 17:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54529 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Christopher Rodriguez Cc: 54529@debbugs.gnu.org X-Debbugs-Original-Cc: 54529@debbugs.gnu.org, guix-patches@gnu.org Received: via spool by 54529-submit@debbugs.gnu.org id=B54529.165497023310929 (code B ref 54529); Sat, 11 Jun 2022 17:58:02 +0000 Received: (at 54529) by debbugs.gnu.org; 11 Jun 2022 17:57:13 +0000 Received: from localhost ([127.0.0.1]:53875 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o05MG-0002q7-Kj for submit@debbugs.gnu.org; Sat, 11 Jun 2022 13:57:12 -0400 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:53303) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o05MC-0002pW-4g for 54529@debbugs.gnu.org; Sat, 11 Jun 2022 13:57:11 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id EF0E85C00B7; Sat, 11 Jun 2022 13:57:02 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Sat, 11 Jun 2022 13:57:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dustycloud.org; h=cc:cc:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm2; t=1654970222; x=1655056622; bh=eW o01dX5ZhcLSYPsSSwk1QUDBvFHEC5TqbxYyiO+gUA=; b=cQwx5qI+tfxPxJHyNA YX5sIqMjtEqJWPpVyvEllPD3gsB8jr0w6uvU5wlRuIYReFt739l6INGz7axBk9gw VviKxRDiuR9/Jp21nBXZJrNVc0Sbv+Mbcc1W0wxXrJQOildK6bGViLZ1/T33bdrS vQdJn587HINSM1j/e9TpygI+OTigDXakXSXUfw3eb6vB3LCfCIpK6wXhdE3qUoKu 5Uh1WO1To4Nfj+tSYGubt6g2EV+8DK2CIwVEaIHnC7Ou/9n8/QxIQkkobOD8sqXr 78FeMV9JyDy1FfS43KLTJQiM2kMdk8CRl641CARsiYRXeBLzarIY/9T4afuZyfvQ vYqQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1654970222; x=1655056622; bh=eWo01dX5ZhcLSYPsSSwk1QUDBvFH EC5TqbxYyiO+gUA=; b=XT7I/Fa3qG01763AwBJPX4ayy65DTgXDFnnb4OrRo7Fl 0/kwGaPh3/rXMvgvmRJAqzi85FRqAKa1NLdN6lTyW1LVfFytyRO0SzIRu7LK7xx7 9P71oB2YjOWmJa9JfO8k2AeO50KW8ojFPAKiESl16SjThLt7k+cvKIZXCTquaDqg i3DK8w0EErq9y3oYzA92hoemHbaa/Zy6qpewFyD5jv4rLVqZuj5kVYDgnx1zgEh6 XnyXYnlJEtRXfgCiZY5nrkJMTCXy+i/7uNuv6Y7u1uSmDvfD4LKz+R3tGt1cTB4X 5pjbCbS/j1l6AxaNLKzdoQVQcC+gNcYNer++oaqg2A== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedruddufedgudduiecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecunecujfgurhepfhgfhffvvefuffgjkfggtgesth dtredttdertdenucfhrhhomhepvehhrhhishhtihhnvgcunfgvmhhmvghrqdghvggssggv rhcuoegtfigvsggsvghrseguuhhsthihtghlohhuugdrohhrgheqnecuggftrfgrthhtvg hrnhepuefffedtffetffdvgffhlefguedtfeeutdevgfduueelgeevudetuedvgefhieek necuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheptgifvg gssggvrhesughushhthigtlhhouhgurdhorhhg X-ME-Proxy: Feedback-ID: i006446df:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 11 Jun 2022 13:57:02 -0400 (EDT) References: <20220322224614.5605-1-yewscion@gmail.com> <87k0bi4eac.fsf@dustycloud.org> User-agent: mu4e 1.6.10; emacs 27.2 From: Christine Lemmer-Webber Date: Sat, 11 Jun 2022 13:55:00 -0400 In-reply-to: Message-ID: <87mtejf5hu.fsf@dustycloud.org> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1654970295; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=eWo01dX5ZhcLSYPsSSwk1QUDBvFHEC5TqbxYyiO+gUA=; b=h4AJr1A5CS8Zvt36DQT5Ot0/+9EL4kYj29d9zqzm7dK2abrZg28htj93qM9ar3rMI6yf0R kA16mGkHB13roQ24kjy4MEUWpbfM1b8YE9qZ6BE+EzNYYYWtBTJqVuu8jiRNfyTnzn/Fml z1af4xSdkFlGo6xZkiz4TdijkwBw7+MKtOLKgrr8u5wHcvtp5ScgBRzu3dWwDFbmSnGpUa JBMvumNQw3RfLboeYwtCIoTYqPFDg39QFh7fOd9j1mxRuVucSsl33Xek2wDfcB5f1GhAf7 hLwULblEUMcAVdlfcmEx5lqnYuGzSUGNEhmcBRV+qpy2v05/piPNqFLnfERUog== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1654970295; a=rsa-sha256; cv=none; b=Fp20Mgmh/vqHBG9XIzXua9S1suZMTdV1kIBdz/Avk+tH9YpPgh3hqWJj60r00uGPunpZ8V k/mIyLOOHQvuZdWNiYo4NP3dMQBANSlNtUkb4mFlBn9wH2LVzj+wzbivg5G/ublgOUSEYx 4Jlm/6fe3SiAFJNLXaTguI/CsHk2CB6MIbrguAcY0qzt3jHABi3Lu4MNnJzpdkQrQhnX2b Mhw9KhomPSGB4AKLcH2o/ZzLrEYuOv7zvbH0nGFfeWxa7htKlHbEZ/sWSTOOBHohJzEUxo qy06/vzbJkSITleeVbPrZP9S3V+Q4Ro8bu0dET964EzDzyydPmunrRh3Lcd7IQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=dustycloud.org header.s=fm2 header.b=cQwx5qI+; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm2 header.b="XT7I/Fa3"; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 2.42 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=dustycloud.org header.s=fm2 header.b=cQwx5qI+; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm2 header.b="XT7I/Fa3"; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 8B4BA2BD08 X-Spam-Score: 2.42 X-Migadu-Scanner: scn1.migadu.com X-TUID: FjCLBOuSSIKZ Hello! Checking in on this again. If you give an updated version of the patch, it can be merged I think. With the commented out part, I'm uncertain whether or not it was commented out because it's no longer needed or because it was but you were debugging, based on what you've said so that's the main concern I have. Could you also use git format-patch for the next version you send? That'll make it easy to apply! Thanks! Sorry for the delays on this review cycle! It's busy here. - Christine Christopher Rodriguez writes: > [[PGP Signed Part:Undecided]] > > Christine Lemmer-Webber writes: > >> Christopher Rodriguez writes: >> >>> [[PGP Signed Part:Undecided]] >>> Hello all, >>> >>> Just want to confirm if this is waiting on me for anything. Trying to stay on >>> top of the issues I'm opening, as I'm planning to open more soon and don't want >>> to pollute the queue with a bunch of forgotten issues. >>> >>> Is there anything else that needs done from my end concerning the above patch? >>> >>> Thanks for Your time! >> >> I've been overwhelmed with other things, but I did try the patch out and >> it did work great. Then I got overwhelmed again. ;P >> >> I think I made a suggestion about the moving the binary name after >> install bit. Did you / could you give that a try? > > Hi Christine! > > I did give it a try, and it worked! I actually decided to do it after > the build step, before the install. > > The above patch should have the updated version, though I do notice now > (upon reading through it again) that it includes a rather large section > I had commented out during debugging. > > I'll remove that and send a revised patch tonight; With the package name issue > out of the way I believe this /should/ be ready to merge.