From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id GI2JNaWq0WMtEQAAbAwnHQ (envelope-from ) for ; Wed, 25 Jan 2023 23:18:13 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id EE/ZNaWq0WOhNgEA9RJhRA (envelope-from ) for ; Wed, 25 Jan 2023 23:18:13 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B38A41042F for ; Wed, 25 Jan 2023 23:18:13 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pKo5m-0005hY-Ag; Wed, 25 Jan 2023 17:18:06 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pKo5i-0005gf-KO for guix-patches@gnu.org; Wed, 25 Jan 2023 17:18:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pKo5i-00059O-By for guix-patches@gnu.org; Wed, 25 Jan 2023 17:18:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pKo5h-0007ZO-Sp for guix-patches@gnu.org; Wed, 25 Jan 2023 17:18:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#57337] [v2 1/2] gnu: Add miniz-cpp. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 25 Jan 2023 22:18:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57337 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Wiktor =?UTF-8?Q?=C5=BBelazny?= Cc: 57337@debbugs.gnu.org Received: via spool by 57337-submit@debbugs.gnu.org id=B57337.167468505129056 (code B ref 57337); Wed, 25 Jan 2023 22:18:01 +0000 Received: (at 57337) by debbugs.gnu.org; 25 Jan 2023 22:17:31 +0000 Received: from localhost ([127.0.0.1]:60140 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pKo5D-0007YZ-1p for submit@debbugs.gnu.org; Wed, 25 Jan 2023 17:17:31 -0500 Received: from eggs.gnu.org ([209.51.188.92]:59356) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pKo59-0007YK-Qw for 57337@debbugs.gnu.org; Wed, 25 Jan 2023 17:17:29 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pKo53-00054f-Hm; Wed, 25 Jan 2023 17:17:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=rHiqxbTM0YL8M8Z5To4e/xIK5mHG1VO5Uz1Qdem2EXU=; b=ch9h/Q4ZTRf/G6IHN5GN YBgBsVSFITTC0RukLcEXrRgakkzzNodUN2vrV7EhlXXiwcuvT0MpENKN5kskoikpAvqCD6YC2Nze0 AJPtWYlIGc8ZzHwhiNpoiGmTI/+30GtV1f0ushyWQm9/VeIYNaWR1OgaTmHvO85WajN/v6X0Ksvcs 2UI4WxwtdYAXgjB8WETTj3RF/xECRiUV0IUfLw8ilFMwkWCMbc6zqW8M2HMik7hQ8BFymnFs4eMhK 8kh683vZuFeEdz56JOywYSxHi4kqRyCpzU5Ldcxpj8aX+QhbboZGCcdqF4y4VyFMYuUCmJtWFHPyH qfnlMhb0vS12Vw==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201] helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pKo52-0005qF-RM; Wed, 25 Jan 2023 17:17:21 -0500 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20221226145732.1237-1-wz@freeshell.de> <20221226145732.1237-2-wz@freeshell.de> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: Sextidi 6 =?UTF-8?Q?Pluvi=C3=B4se?= an 231 de la =?UTF-8?Q?R=C3=A9volution,?= jour du Laurier-thym X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Wed, 25 Jan 2023 23:17:18 +0100 In-Reply-To: <20221226145732.1237-2-wz@freeshell.de> ("Wiktor =?UTF-8?Q?=C5=BBelazny?="'s message of "Mon, 26 Dec 2022 15:57:31 +0100") Message-ID: <87mt66s1ht.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1674685093; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=rHiqxbTM0YL8M8Z5To4e/xIK5mHG1VO5Uz1Qdem2EXU=; b=gI9C/NN6Rnn6dJOww1mC2ShRVYkp45Xw69aGG+57+ZYS6Shw6k207kPzUEs08Q/DG9z+EG ZI3IRxA3TiAbaeJUUyZDRdLE7BfrVfuELcFE8feEanu9NEfGZhzLWiZa8aJJnmLxvR5HS/ D7oeRwYjXEvyMV0bNhi/CpZWbxZlTfaszszntwF34+Q+1egNTaPJxX0pAWffHgch8aSKPv 7zx6XP0rqUxcCrRb4ybUFLxg/zoBffWphwpJX09JYQ5CieRBTAI2506FCMXkgbBF+Qnyfa ocy+9x9ZNhZbH+xHRy8zkszPjaPuP38KCj8O6UZp28YgLmVzxqlcwTgYT/4/VA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b="ch9h/Q4Z"; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Seal: i=1; s=key1; d=yhetil.org; t=1674685093; a=rsa-sha256; cv=none; b=dv40ZU8V97CI1dsdonPRxNXsDO5U2SoG69XB/rfvY5yzStU5KjWSUTgeKpl0jwN21hirLK muGc9ih4HzEQFKm12q1hjZbROywGINuReJdIgyOjWQBaEjNGy5qxRCtLmE9Ryw2fneyqrE a8RCo420U6IeFRYVDlhvkSmxYHqWv/TvzGo3Q/pQZfEpBd2YTjJQGJyKIs0FD+/aahkYUp H4m0bNiJ7aqfgttInTBU05+BrzEn/CzP3KnYU+eNU0k6r256+KumvrymumxbOCBAg27MgX cVXQG4Ju9cZ8zTbKHmY8a5bwnCJPKELmSIBNzs2daG6sfGZoFXTRddxUpC/Khw== X-Migadu-Scanner: scn1.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b="ch9h/Q4Z"; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org X-Migadu-Spam-Score: -3.98 X-Spam-Score: -3.98 X-Migadu-Queue-Id: B38A41042F X-TUID: QNOhClRORF+X Hi Wiktor, Apologies for the delay. Wiktor =C5=BBelazny skribis: > * gnu/packages/cpp.scm (miniz-cpp): New variable. > --- > gnu/local.mk | 1 + > gnu/packages/cpp.scm | 35 + > .../miniz-cpp-fixed-duplicated-symbols.patch | 2734 +++++++++++++++++ > 3 files changed, 2770 insertions(+) > create mode 100644 gnu/packages/patches/miniz-cpp-fixed-duplicated-symbo= ls.patch That=E2=80=99s a pretty big patch, and we don=E2=80=99t usually take that b= ig a patch downstream, but=E2=80=A6 > + (patches (search-patches > + ;; To be removed once https://github.com/tfuss= ell/miniz-cpp/pull/11 > + ;; gets merged. > + "miniz-cpp-fixed-duplicated-symbols.patch")))) Looking at the GitHub issue, it seems the solution could be merge soon. How about (1) pinging upstream asking whether they could merge it, and (2) referring to the commit of this pull request in the package definition in the meantime, with a comment explaining why? Thanks in advance, Ludo=E2=80=99.