From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id 4JKQAdSE4mMdoQAAbAwnHQ (envelope-from ) for ; Tue, 07 Feb 2023 18:05:24 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id SLNsAdSE4mNfcAEAauVa8A (envelope-from ) for ; Tue, 07 Feb 2023 18:05:24 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D2BC82DFE1 for ; Tue, 7 Feb 2023 18:05:22 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pPRP5-0006a1-Gz; Tue, 07 Feb 2023 12:05:13 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pPROx-0006SW-1N for guix-patches@gnu.org; Tue, 07 Feb 2023 12:05:04 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pPROw-0005Xj-Li for guix-patches@gnu.org; Tue, 07 Feb 2023 12:05:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pPROw-0001vq-0D for guix-patches@gnu.org; Tue, 07 Feb 2023 12:05:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#60905] [PATCH 08/25] gnu: go-github-com-pkg-diff: Update to 0.0.0-20210226163009-20ebb0f2a09e. Resent-From: Katherine Cox-Buday Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 07 Feb 2023 17:05:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60905 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 60905@debbugs.gnu.org, mail@cbaines.net Cc: paren@disroot.org X-Debbugs-Original-To: "( via Guix-patches" via , Christopher Baines X-Debbugs-Original-Cc: "\(" , 60905@debbugs.gnu.org Received: via spool by submit@debbugs.gnu.org id=B.16757894917404 (code B ref -1); Tue, 07 Feb 2023 17:05:01 +0000 Received: (at submit) by debbugs.gnu.org; 7 Feb 2023 17:04:51 +0000 Received: from localhost ([127.0.0.1]:53890 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pPROk-0001vM-QG for submit@debbugs.gnu.org; Tue, 07 Feb 2023 12:04:51 -0500 Received: from lists.gnu.org ([209.51.188.17]:37024) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pPROj-0001v7-5F for submit@debbugs.gnu.org; Tue, 07 Feb 2023 12:04:49 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pPRON-0006GK-0m for guix-patches@gnu.org; Tue, 07 Feb 2023 12:04:28 -0500 Received: from mail-io1-xd31.google.com ([2607:f8b0:4864:20::d31]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pPROK-0005SG-Ps for guix-patches@gnu.org; Tue, 07 Feb 2023 12:04:26 -0500 Received: by mail-io1-xd31.google.com with SMTP id a10so599105iod.0 for ; Tue, 07 Feb 2023 09:04:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=wSFb56WLVaFmRA/1Bed5m25GnH18+1xzUYsP9lqAJO8=; b=NclwWNOkBqywXNUmbYG0YkTi0ddwQRpaWJ2v8P3+cLZ81WenAXuKuMctjhBf98O9kT QfTLQIuNCK7VJQ7sFXcv0Xwl5r6FwxfEOker61NyZd3L8U4VhFaeB2esT3/shyLa4GZY U6yndC6n+wzNLFPj2UothOAlg/ER2ENvhV5piU2lHOwO2N/+0CYJBzhBMTB2V6ABuXbJ /xrX+tn7MS+ljLhCdrfAyBsipBg51HrTGx/bauITbTGKgs9hV03eGU1Mg/S9NG3sj2Li aIZcm+jSyqgBTuaEEbC4dbVBNT1xfJ8t5p/yHq37OkcUUX7Ed7JxGLUA/glRHePL/K23 zPpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=wSFb56WLVaFmRA/1Bed5m25GnH18+1xzUYsP9lqAJO8=; b=foeg0prfWWInIG7sTqBkWj1yNMHPhtLHk8cMlI2x0MaU9KMN7xa3cL/LOtAPn3zNTw 3hv6Q6tF64rRiCi314z2qqHW+pN1/uaM2UvuhAefXsfRA1dELXKsuK5/xkUgaIEmttrx Ozvlt8fhK9ie8TJ3aGC0lfGBGgW+IbaMxovj0yB7ct3ocbIt/KjozfziwLx4Ukz4HnDK hLpndcuNF59qDX5aH3L99xfm7NN83OrpJWuuRi8yLyiZOvCpCxMaPzGl5IyEat6ea2uZ uzV4Rvhxen7qIq7l0dX1ZkrbN3byBCglwWrZcPUlj5NDg9qVGYLsy1KI95ob7ofWo7y3 nnEg== X-Gm-Message-State: AO0yUKU57VXGcSm6yXYKoYNWFuah3R/zVbwREO7XQHT7kZshuh3d2UUb gw6L5PUxjiP4c/Thc1kDiqrwOJ0g3ffQ9A== X-Google-Smtp-Source: AK7set/kr1MossOPFbA+tWEAWfLYtP3E2Yj7Wh62qpWVXocsFkbajJsD8HjVOfpfS6vVJrW2ipfLpA== X-Received: by 2002:a6b:4a12:0:b0:71e:24ee:5352 with SMTP id w18-20020a6b4a12000000b0071e24ee5352mr3354913iob.17.1675789458914; Tue, 07 Feb 2023 09:04:18 -0800 (PST) Received: from washu-v4 (c-174-51-139-101.hsd1.co.comcast.net. [174.51.139.101]) by smtp.gmail.com with ESMTPSA id q8-20020a027b08000000b003af4300d670sm4662063jac.27.2023.02.07.09.04.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Feb 2023 09:04:18 -0800 (PST) From: Katherine Cox-Buday References: <20230118014510.19320-1-cox.katherine.e@gmail.com> <20230118014510.19320-9-cox.katherine.e@gmail.com> Date: Tue, 07 Feb 2023 10:04:17 -0700 In-Reply-To: (guix-patches@gnu.org's message of "Mon, 06 Feb 2023 22:20:23 +0000") Message-ID: <87mt5pxv8u.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2607:f8b0:4864:20::d31; envelope-from=cox.katherine.e@gmail.com; helo=mail-io1-xd31.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=NclwWNOk; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1675789523; a=rsa-sha256; cv=none; b=f4fp0IjWyKEsvI1DrIQwBzuLqPAkSqUKg+eAfCrk/+vt00EAfjblPXk6qVHMvlocf9BJvq hKpOvopbQlnphMe5wVnFKjTYqNZYBO7zgUCiyqfFkg03KIHNc5YuCndXzaiggtHHDwiD7n sTLQVOBt5UMan5QPEMiFZrh6cz5VufCk89iDOhrKmy0JKC0lN7uglz0IwEN9pA7b7JSX09 mC0GInkYZOzioRfEdiWUeoVfnTBl1fSdwgalrZFvGDUhGkOKgnzNj5hn4CzqlCY9ti+nTM 2PbT38MFx6tFAH8k36nAzdeKJFVhxTfUMPHNEln8NguG5pqRS+M0UcvxMB7gcA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1675789523; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=wSFb56WLVaFmRA/1Bed5m25GnH18+1xzUYsP9lqAJO8=; b=ZjBNpf/MD6L8r2ifFKy0obnUiCtXY5M+7dZglB2YYqTY4XtLNaDJ84SiX0M0tOlWuj6B5A QMmS20IRJYfM4e6lA/Qi9TrsCJay/O1jpuSoZZJCzwnE5gAY4sY/JHodsBo/cunUVmkfuO 6KnE5Y0kOInDSpNYIW8qYQr2Sz1g9eqDT3UF55jxdi0tUifYSAOeuWcggdbosqOEnmJlPs 2bNm5BHIvrigEgbCY5gait2x3tpFlpKbcRXjNQI1EpMxUUNX1MNoP9ZMYFvWmiJsbTP8EG C3ceaN1QMi9p+rjg652Ws56j76hkeNfBf+XLhxc6xKfkXEH62wPecKR2/ht4TQ== X-Migadu-Spam-Score: -2.19 X-Spam-Score: -2.19 X-Migadu-Queue-Id: D2BC82DFE1 X-Migadu-Scanner: scn1.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=NclwWNOk; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) X-TUID: k8yFjLm4Nb/B "( via Guix-patches" via writes: > * gnu/packages/golang.scm (go-github-com-pkg-diff): Update to > 0.0.0-20210226163009-20ebb0f2a09e. > >> --- a/gnu/packages/golang.scm >> +++ b/gnu/packages/golang.scm > >> @@ -8736,30 +8736,26 @@ (define-public go-github-com-go-git-go-git-fixtures > >> + (package >> + (name "go-github-com-pkg-diff") >> + (version "0.0.0-20210226163009-20ebb0f2a09e") > > As Chris said, don't use this kind of version string :) Ah, I actually have (what I think) is a valid reason for this. In Go, when a module is in development, this long string, including the SHA, is the actual version[1] of the module, and carries semantics for Go developers, i.e. "Signals that the module is still in development and unstable. The release carries no backwards compatibility or stability guarantees." It's how it will be referenced by other Go modules, and so I thought it best to make the version field reflect the actual version. The previous iteration of this package had an incorrect version: upstream did not assign it a 0.0.1 version; that's something we did. I agree that this is confusing for Guix maintainers, and causes duplicate information in the version and commit fields. What are your opinions on this? >> + (source (origin >> + (method git-fetch) >> + (uri (git-reference >> + (url "https://github.com/pkg/diff") >> + (commit "20ebb0f2a09e612109b224b32f79370409108bcc"))) > > And especially don't write the commit twice. > >> + (synopsis "Create and print diffs") > > (synopsis "Generate and print diffs in Go") I only bumped the version here; the synopsis was pre-existing. But: is the language important? Do we say "Diff creates and prints diffs in C"? >> + (description >> + "This package provides a Go library to create and print diffs.") > > (description > "This package provides a Go library to generate and print file > differences in the @code{diff} format.") [1] https://go.dev/doc/modules/version-numbers#in-development -- Katherine