Andrew Tropin writes: > [[PGP Signed Part:Undecided]] > On 2023-02-10 17:04, Pierre Langlois wrote: > >> Hi, >> >> Andrew Tropin writes: >> >>> [[PGP Signed Part:Undecided]] >>> On 2023-02-09 13:39, zimoun wrote: >>> >>>> Hi, >>>> >>>> On Thu, 09 Feb 2023 at 14:11, Andrew Tropin wrote: >>>> >>>>> I applied tree-sitter and tree-sitter-cli patches, >>>> >>>> Just to be sure to understand, you have only applied 02/32 and 05/32, >>>> right? >>>> >>>> >>>> [bug#49946] [PATCH v7 02/32] gnu: tree-sitter: Update to 0.20.7. >>>> id:20221125012142.22579-3-pierre.langlois@gmx.com >>>> http://issues.guix.gnu.org/msgid/20221125012142.22579-3-pierre.langlois@gmx.com >>>> >>>> [bug#49946] [PATCH v7 05/32] gnu: Add tree-sitter-cli. >>>> id:20221125012142.22579-6-pierre.langlois@gmx.com >>>> http://issues.guix.gnu.org/msgid/20221125012142.22579-6-pierre.langlois@gmx.com >>>> >>>> Leaving out all the others, right? >>> >>> Merged first 5 patches from 01 to 05, also added one more commit, which >>> addresses some things from reviews and one commit, which adds html >>> grammar. >> >> I had also started rebasing addressing comments on the tree-sitter-cli >> package, and had a few extra changes left that haven't been pushed. >> >> I realised we could remove a now redundant comment, and while enabling >> *some* tests, I realized we should directly depend on node and dot, so >> that people may use the `tree-sitter' command, without needing them in >> the same profile. > > Sounds very valid! :) > >> >> What do you think of the following two patches? >> > > I applied them locally and tested, LGTM. Will push them a little later > with the rest of tree-sitter related changes. Cool, thanks!