From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id cLiwNaAeHmSdMQEASxT56A (envelope-from ) for ; Fri, 24 Mar 2023 23:05:20 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id QFaYNaAeHmQGiQAAauVa8A (envelope-from ) for ; Fri, 24 Mar 2023 23:05:20 +0100 Received: from lists.gnu.org (unknown [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B67B217C30 for ; Fri, 24 Mar 2023 23:05:20 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pfpTi-0004WE-L6; Fri, 24 Mar 2023 18:01:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pfpTR-0004Hb-DP for guix-patches@gnu.org; Fri, 24 Mar 2023 18:01:29 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pfpTP-0000eY-ES for guix-patches@gnu.org; Fri, 24 Mar 2023 18:01:23 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pfipl-000456-Oe for guix-patches@gnu.org; Fri, 24 Mar 2023 10:56:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#62298] [PATCH v2 2/8] services: replace bare serializers with (serializer ...) Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 24 Mar 2023 14:56:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62298 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Bruno Victal Cc: 62298@debbugs.gnu.org, ludo@gnu.org, liliana.prikler@gmail.com Received: via spool by 62298-submit@debbugs.gnu.org id=B62298.167966975615674 (code B ref 62298); Fri, 24 Mar 2023 14:56:01 +0000 Received: (at 62298) by debbugs.gnu.org; 24 Mar 2023 14:55:56 +0000 Received: from localhost ([127.0.0.1]:41134 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pfipg-00044k-5j for submit@debbugs.gnu.org; Fri, 24 Mar 2023 10:55:56 -0400 Received: from mail-yw1-f176.google.com ([209.85.128.176]:42650) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pfipf-00044Y-3O for 62298@debbugs.gnu.org; Fri, 24 Mar 2023 10:55:55 -0400 Received: by mail-yw1-f176.google.com with SMTP id 00721157ae682-544f7c176easo37233587b3.9 for <62298@debbugs.gnu.org>; Fri, 24 Mar 2023 07:55:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679669748; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=P+SeGUhgIKLmlM/inVAQ5szJqNqt2+lZDCkzeS+jHrk=; b=OyE881MOpHdd7OBuqenc1nHgtXWlesN/Yp3sfKY0BqSeBnvQ0OT2WZDwiTgCGnkFDp qkRqHnBACNqnQELqy3zjW0TN4lNXlz3ne33yyPesp4/xHhwEaYzN0qMQLDqHjFKUpCOX SSo8EhdUXd0l7wboHocZJtdSJs1GP73zFbNwYUDBcyYye+0Zj19ZWvySj6JCqOKi7JmN 8woBKOHwqW40ye0PX4aOUsrTQckZhkVRkZQUYE3XgpXZ2WCKAmpzDH/knFJ1fMqjYnRm zhDeQgmMAmM5MrncV93acXv6bdBqbFHlSuwPvBjP55KJuvxStLBxnDw/IC+6eLogXNFR QGiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679669748; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=P+SeGUhgIKLmlM/inVAQ5szJqNqt2+lZDCkzeS+jHrk=; b=5hXj4IkOo8N+//s1JrQY7qY5ctKtX4yWsqXgFm8xgpPninsLzHMH0K+C8vq9osWLog sCrULBx/U7HFD2b84AtyveoLzKGLI0e6dDoYXkXk6cbwnOBA9bzufXZeBWeJiAJjpIt6 h94gD0QPa/69eXoZNRgpL5kvLmr2QKmZ2T7VOQZ8v+xzO9I5paqIM9kiZLim99dTbh4M +h3I56JFw/bgpxmzGV88sLHzkwp24kk57E7Euzke0WhBvwtIwak05l0tLinBrn8ENdVt mPz8Kuw9ohASjOTAHGMgT9op+9/9nuRUEgvSu2dpvawHKqxv+IQONyEzvS43172qsz56 CbQQ== X-Gm-Message-State: AAQBX9d3LA3eqYJ2L+2/qHqNhujQPL8ancFWyKagfTKwatXMz2bjl7ji hJAiMYNKJwWxaqEB/WmUS8A= X-Google-Smtp-Source: AKy350Zg6ziy+03m2ZIZv1W2jCPMrX7wpTqszkkNh6b7lhw7W8y6Pq+zkDnsaepXTPKyjnqEMAklnQ== X-Received: by 2002:ad4:4eaf:0:b0:5a9:5285:13e2 with SMTP id ed15-20020ad44eaf000000b005a9528513e2mr5163058qvb.4.1679668087408; Fri, 24 Mar 2023 07:28:07 -0700 (PDT) Received: from hurd (dsl-155-54.b2b2c.ca. [66.158.155.54]) by smtp.gmail.com with ESMTPSA id s12-20020ac8758c000000b003e389560a05sm4223956qtq.51.2023.03.24.07.28.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Mar 2023 07:28:07 -0700 (PDT) From: Maxim Cournoyer References: Date: Fri, 24 Mar 2023 10:28:05 -0400 In-Reply-To: (Bruno Victal's message of "Thu, 23 Mar 2023 15:02:12 +0000") Message-ID: <87mt42z0ju.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1679695520; a=rsa-sha256; cv=none; b=OlSk+8KZ5Ehbdhc75LGzjZ8MeNYQ1q+TqjKeI47I3YU2Agqgd1Ulya6M9NQTFMXoiM4vz+ u3YpArgVB7YN8ZolVfFvL1cjYElI1Hc33Vg+1Dpsm6XK8I/T8wRJYpM5M9SSksxHbLge2B RFovBdFCRRuZUZR1DselGuCFTLp+DK4VGsMfQgzv6HW6dZUNdC9o2TDESL0dxAOfevZ8ju +y9itQpb5zA1exNkKaLbLZktm1mSzkHP+t5/7+cDIh2grMG/yENZiHhW/YFllA+G2eeERG +yHS41dPGATPtdEsnOvZ/dVy3j1E4Ck7XWyjb0PAw61Kr8J9oQteusbacnOy7w== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=OyE881MO; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1679695520; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=P+SeGUhgIKLmlM/inVAQ5szJqNqt2+lZDCkzeS+jHrk=; b=jt+5ny1vmLUDGAnlNbrdrMs500QHUXLVDMF006uDVlIFMQUDbby2f/meG+8fhM2NtU/Jlq 3wbyyIhkMmhf/BpEITf7vDwwb3g/2IV5H5ps2GAHzj2mLXMdJ+hcyYn/HA1+5Bz2lbIpet UPKZxvIVfC9OrLhYduBHBzSjCmQibNG4bBGzgXjUfKKF1eMVOvIJgDBEeS3nkOgjpPGxmi MieiYG0D7hOc8mc45vyEZXOSbQ1pEGXgcgTKEKmWc7aHwSMGKimcTwNg9bbaPOdHt+hrDY CFgqrsbOz3Q5M0q+JuCKdZ0FHfMCaOAB2XiXyNEWWor7cMnx6VQffENPtAgqOw== Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=OyE881MO; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Scanner: scn1.migadu.com X-Migadu-Spam-Score: 3.36 X-Spam-Score: 3.36 X-Migadu-Queue-Id: B67B217C30 X-TUID: PJYJAPRPD3Up Bruno Victal writes: > * gnu/home/services/shells.scm (home-zsh-configuration)[environment-variables]: Use (serializer ...). > (home-bash-configuration)[aliases, environment-variables]: Ditto. > (home-fish-configuration)[abbreviations, aliases, environment-variables]: Ditto. > * gnu/services/audio.scm (mpd-configuration)[music-dir, playlist-dir, endpoints] > [address, inputs, archive-plugins, input-cache-size, decoders, filters, playlist-plugins]: Ditto. > * gnu/services/linux.scm (fstrim-configuration)[extra-arguments]: Ditto. > * gnu/services/security.scm (fail2ban-jail-configuration)[backend, log-encoding, extra-content]: Ditto. > * tests/services/configuration.scm: Update tests. Add test for deprecated bare serializers. The commit message should be line-wrapped around 80 chars and the title should be puncutated like: "services: Replace [...] ." The rest LGTM. -- Thanks, Maxim