From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Baptiste Strazzulla <bstrazzull@hotmail.fr>
Cc: 62488@debbugs.gnu.org
Subject: [bug#62488] [PATCH] Update emacs-lemon
Date: Mon, 27 Mar 2023 19:23:22 +0200 [thread overview]
Message-ID: <87mt3yxg51.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <AS8P189MB202455DC51F574CE10B345FCB98B9@AS8P189MB2024.EURP189.PROD.OUTLOOK.COM> (Baptiste Strazzulla's message of "Mon, 27 Mar 2023 16:33:16 +0000")
Hello,
Baptiste Strazzulla <bstrazzull@hotmail.fr> writes:
> * gnu/packages/emacs-xyz.scm (emacs-lemon-version): Update to 2.1.0
Thank you.
> (define-public emacs-lemon
> - (let ((commit "37a6e6d6ef0900ca19c820a2dbc122c7fe6d86cf")
> + (let ((commit "b10e992a25757a91723c7d554a5fa8e14291e702")
> (revision "0"))
> (package
> (name "emacs-lemon")
> - (version (git-version "2.0.0" revision commit))
> + (version (git-version "2.1.0" revision commit))
Since the commit matches the version bump, you can drop the `revision'
binding and `git-version' call. Version is simply "2.1.0". Could you
send an updated patch?
I noticed the package contains some tests. Would you try to run them, in
a subsequent patch?
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2023-03-27 17:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-27 16:33 [bug#62488] [PATCH] Update emacs-lemon Baptiste Strazzulla
2023-03-27 17:23 ` Nicolas Goaziou [this message]
2023-03-29 0:06 ` Baptiste Strazzulla
2023-03-30 10:37 ` bug#62488: " Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mt3yxg51.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=62488@debbugs.gnu.org \
--cc=bstrazzull@hotmail.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).