unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: "J. Sims" <jtsims@protonmail.com>
Cc: "62282@debbugs.gnu.org" <62282-done@debbugs.gnu.org>
Subject: bug#62282: [PATCH] gnu: gerbil: Upgrade to 0.17.0.
Date: Sun, 09 Apr 2023 00:01:38 +0200	[thread overview]
Message-ID: <87mt3i9got.fsf_-_@gnu.org> (raw)
In-Reply-To: <LSuRbFEjWmMm1qyxkuaXGo3gQfE0OmQpT61n_KZK0XgalSlLTjksQg6L23adZp6YQxeLmhWu4tHUYG3998qeF_w0d6u-BSrXjFPBtOOTniY=@protonmail.com> (J. Sims's message of "Thu, 30 Mar 2023 02:12:18 +0000")

Hello,

Thanks for taking the time to split the patch.  I’ve applied #1 and #2.

"J. Sims" <jtsims@protonmail.com> skribis:

> From 569fabf7029200cbb3166af83b8fc89a6378468d Mon Sep 17 00:00:00 2001
> From: Juliana Sims <jtsims@protonmail.com>
> Date: Tue, 28 Mar 2023 23:56:07 -0400
> Subject: [PATCH 3/3] gnu: gerbil: Enable all features.
>
> * gnu/packages/scheme.scm (gerbil): Enable all features.

[...]

> +                           "--enable-leveldb"
> +                           "--enable-libxml"
> +                           "--enable-libyaml"
> +                           "--enable-lmdb"
> +                           "--enable-mysql"
> +                           "--enable-sqlite"
> +                           "--enable-zlib")))
>                 (add-before 'patch-generated-file-shebangs 'fix-gxi-shebangs
>                   (lambda _
>                     ;; Some .ss files refer to gxi using /usr/bin/env gxi
> @@ -1202,8 +1211,18 @@ (define-public gerbil
>                       (copy-recursively "../bin" bin)
>                       (copy-recursively "../lib" lib)))))
>             #:tests? #f))
> -    (native-inputs (list coreutils gambit-c util-linux))
> -    (propagated-inputs (list gambit-c openssl sqlite zlib))
> +    (native-inputs (list coreutils
> +                         gambit-c
> +                         util-linux))
> +    (propagated-inputs (list gambit-c
> +                             leveldb
> +                             libxml2
> +                             libyaml
> +                             lmdb
> +                             mysql
> +                             openssl
> +                             sqlite
> +                             zlib))

I have two questions:

  1. What’s the impact on ‘guix size gerbil’?  Overall we should find a
     balance between feature usefulness and size.

  2. Do all these really need to be propagated?  Shouldn’t they be
     regular inputs?  If propagation is required, please add a comment
     explaining why.

I propose to close this issue since the initial goal has been met, but
please open a new one to follow up on this.

Thanks!

Ludo’.




      reply	other threads:[~2023-04-08 22:02 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-19 23:06 [bug#62282] [PATCH] gnu: gerbil: Upgrade to 0.17.0 J. Sims via Guix-patches via
2023-03-21 13:57 ` Bruno Victal
2023-03-30  2:12   ` J. Sims via Guix-patches via
2023-04-08 22:01     ` Ludovic Courtès [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mt3i9got.fsf_-_@gnu.org \
    --to=ludo@gnu.org \
    --cc=62282-done@debbugs.gnu.org \
    --cc=jtsims@protonmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).