From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id UKsaJtjR5mTHfwEASxT56A (envelope-from ) for ; Thu, 24 Aug 2023 05:43:20 +0200 Received: from aspmx1.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id WGG3JdjR5mSQ2QAAauVa8A (envelope-from ) for ; Thu, 24 Aug 2023 05:43:20 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 693D633F50 for ; Thu, 24 Aug 2023 05:43:15 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=ultrarare.space header.s=dkim header.b="KB/8DqOr"; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1692848595; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=eC/b2dk2q1OqXMfUGx4pN9LqZbdKrMFMVwPA1zJYR1g=; b=p4suPDyWD5/OOIL+13GJyw9ENhblvC4fY0JLeqgA7iNshRrOTZyqaEGrwVqTKCUUv8VMEp U2JRB5YEPBWKjh47CRbYqd7P6KzHjXDonKt35vBi+ZPe558ybFCaXznT6KDI2A2kZtVWRd 4Exy4dTQ1oardTEpiQ2A8IyLAuDovLgYolGO5lpnNjX27gzQw5ZGJZwzEi7dHM5T1OtJk2 zERunaNcTXQ2nRQbX+DpqROcQHdNJW96aPhZ0OxyZIf+usNq52AXHXiYRco/7wmhBE8AG2 8Hzih2PcbjG9DQOqStpvQzovrYTmNvXbGETtzxxWi4sWf3e0taDQFt9yN9cEPA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=ultrarare.space header.s=dkim header.b="KB/8DqOr"; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Seal: i=1; s=key1; d=yhetil.org; t=1692848595; a=rsa-sha256; cv=none; b=Nm/VRfD00LBG5bpF5s7OOtKYy3VKULSMCfzzxpusJwWTSLcwd1lOvyH9O3gUIcbpr1YORH p1deQWcTbNo98SxDWcB456380gSkcxP7G8S8Kv3kszNfk3lnVjg/7H2PmVvvA3upw6zIrZ yxWg+ruzjWAlOTfupogt1+g4ZJLkXXXcFxtwB+Pkya5vtDviJAG2a7Bn3tWB353PQsf2kJ wJIzmIDKhXE7N99PtajBRJjDWd3KsiT2wy63LCEVtlvqPquELvBHKaYQeMVdtiBj1iL87P /0nxsyzQFrLNiBqPzuX0929GRXVmRIZIWmX0+qyHpe4ZG7FHelVPGaSPpnWd8w== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qZ1FN-000795-3c; Wed, 23 Aug 2023 23:43:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qZ1FL-00078s-Rq for guix-patches@gnu.org; Wed, 23 Aug 2023 23:42:59 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qZ1FL-0005nX-K1 for guix-patches@gnu.org; Wed, 23 Aug 2023 23:42:59 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qZ1FO-0003XH-LK for guix-patches@gnu.org; Wed, 23 Aug 2023 23:43:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#65062] [PATCH core-updates 1/1] packages: Specify output in input label when it's not "out". Resent-From: Hilton Chain Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 24 Aug 2023 03:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65062 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: moreinfo patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: Josselin Poiret , Simon Tournier , Mathieu Othacehe , Tobias Geerinckx-Rice , Ricardo Wurmus , 65062@debbugs.gnu.org, Christopher Baines Received: via spool by 65062-submit@debbugs.gnu.org id=B65062.169284857413577 (code B ref 65062); Thu, 24 Aug 2023 03:43:02 +0000 Received: (at 65062) by debbugs.gnu.org; 24 Aug 2023 03:42:54 +0000 Received: from localhost ([127.0.0.1]:35753 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qZ1FG-0003Wv-0E for submit@debbugs.gnu.org; Wed, 23 Aug 2023 23:42:54 -0400 Received: from mail.boiledscript.com ([144.168.59.46]:59014) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qZ1FC-0003Wl-7E for 65062@debbugs.gnu.org; Wed, 23 Aug 2023 23:42:51 -0400 Date: Thu, 24 Aug 2023 11:42:04 +0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ultrarare.space; s=dkim; t=1692848531; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eC/b2dk2q1OqXMfUGx4pN9LqZbdKrMFMVwPA1zJYR1g=; b=KB/8DqOrJ3Af8quekeEqhYMs62NtXXXunPBUU2GRv+E1DN3sT7DIzxsXRle7LYeb0bjsoK N30sWFpobw9lVsN/cNf5cMs0nqR8HiLbbfH9o23C6EAsrFysNhuNMl7OHPZKOsbibkPpF8 Y5OsqgASb/2MzbQBPmsoUzDZWIxzlZ1u6AJKd1+JEJ0Zn1kgzv0vcrR8zvSmoOThjQzcMF Ym1ItXHgJp3v6BZ8peNunFuwV9muFqIB5fDGBgdq1PSdI37IgWS1ksu2dk5ARRlyKJ6UUC zpskvbF4FIFg67D9AC3pfHPaPnbh9QkGogLHbPdRMw95NfsmZLwBy/Eznpp7ng== Message-ID: <87msyhumwj.wl-hako@ultrarare.space> In-Reply-To: <875y575apr.fsf@gnu.org> References: <875y575apr.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spamd-Bar: ++ X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Hilton Chain X-ACL-Warn: , Hilton Chain via Guix-patches From: Hilton Chain via Guix-patches via Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Scanner: mx2.migadu.com X-Migadu-Spam-Score: -5.21 X-Spam-Score: -5.21 X-Migadu-Queue-Id: 693D633F50 X-TUID: XEEA6lY3wA08 Hi Ludo, On Wed, 23 Aug 2023 00:00:00 +0800, Ludovic Court=C3=A8s wrote: > > Hi, > > Hilton Chain skribis: > > > * guix/packages.scm (add-input-label): Specify output when it's not "ou= t". > > [...] > > > + (list (string-append (package-name package) ":" output) > > + package > > + output))) > > The Grand Plan=C2=B9 is to eventually get rid of labels entirely (or almo= st: > there=E2=80=99d still be input alists on the build side). As such, I tho= ught we > shouldn=E2=80=99t worry too much about what the actual label is. But per= haps > you stumbled upon situations where this is a problem? Could you > describe them? > > Thanks, > Ludo=E2=80=99. > > =C2=B9 https://guix.gnu.org/en/blog/2021/the-big-change/ My main concern is that currently modify-inputs, this-package-input and this-package-native-input operate on input labels and there would be duplicated labels if adding multiple outputs of a package. For modify-inputs, I think there's no approach to solve this without also specifying labels in inputs. Although this-package-* can be replaced by search-input-*, I'd like to avoid (dirname (dirname (search-input-file inputs "/lib/..."))) when (this-package-input "...") is available. For current this-package-* vs. search-input-*, I have other points: 1. In the context of build system arguments, like #:configure-flags, inputs and native-inputs as variables aren't available, one may need to use %build-inputs, %build-host-inputs and %build-target-inputs for search-input-*, which is inconsistent with other parts. 2. It might be a bit confusing when, for example, adding tzdata-for-test to native-inputs, and referencing it with proper cross-compilation support: --8<---------------cut here---------------start------------->8--- (setenv "TZDIR" (search-input-directory (if #$(%current-target-system) native-inputs inputs) "/share/zoneinfo")) --8<---------------cut here---------------end--------------->8--- In such cases I may prefer this-package-*, but it would be unreliable when there're duplicated labels. There's also issue referencing a package when multiple versions of it under a same name are added to the inputs, which may not fall under this "Subject:". Thanks