From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id gA6FAKM592QCQQAAG6o9tA:P1 (envelope-from ) for ; Tue, 05 Sep 2023 16:22:27 +0200 Received: from aspmx1.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id gA6FAKM592QCQQAAG6o9tA (envelope-from ) for ; Tue, 05 Sep 2023 16:22:27 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A47B75265B for ; Tue, 5 Sep 2023 16:22:26 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20221208 header.b=OXSbs9K1; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1693923746; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=BKQYh03vPB/NQZ91hTYJTXBkvpzHseEwiupp3KotGxM=; b=fUsUDf/+/sOdIYrO64iQOBcFRHB7Ie1U8vD7Tw4saZzJjD4k0a+SNITa5HPVsVQIF3QI2N Wr6OiRlYn1zdQlxMAM3BwvBUJmapqqXYoTWJJ3s/UTg0KFEwjOH90S/BWzwKPK9b8dpwE/ 4mW2EtLRYFbidfo/X6mDBTnoXH8X11Uta0Rbpp1A/Q9zH/BIq5IGNZtVP90ulBWMZH1w6y v79ZNYa5Z1j5mjOGufWiB3fOgFTh3ZRHjX9C6MUqmpM5ZE1lTfsyraxdzvljDCejzJklaE GMWp1ptBRCy26JlgwUfvdSmwJcEv2lu4+7Audc0q6wbGMmiI0CgSK7dQwRwO0Q== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1693923746; a=rsa-sha256; cv=none; b=KSlof1OXGrP0zofd1DtidlmzIB3YmuFQ8CtvV1pnp1NBrOAZ55qX/v0B8+toQ26Dh/9Xqh m5AKXlbcAoEMIq/azk4tqOKhkpWnlCDZCu2pZvadhV9/zWH6/Vg781KxFW6CaV2Mr0VqkL e2hDlrX432mO0DubeDyMBkh6X9oSUapGLYisJItooq+JfaWlev5pgqhvsWjf3+/UrY/Frv kbbR/L9/GHX4sqgodDlPtd4TuQYRsf5uD76qk1IUutOYw2cyoBZ2/hHLiqdDCNHGZHDbyX ug4XMlzdOdYlTxf9H0MWzq9bHBdDwO3Yo3Box5OdqeEzqz8egYtozdcRXqWO/g== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20221208 header.b=OXSbs9K1; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qdWwO-0002Is-Jy; Tue, 05 Sep 2023 10:22:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qdWwM-0002Hh-3r for guix-patches@gnu.org; Tue, 05 Sep 2023 10:22:02 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qdWwL-0007tv-RE for guix-patches@gnu.org; Tue, 05 Sep 2023 10:22:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qdWwM-0002Ae-0Y for guix-patches@gnu.org; Tue, 05 Sep 2023 10:22:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#65097] [PATCH] gnu: Add tk-img. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 05 Sep 2023 14:22:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65097 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: cage Cc: 65097@debbugs.gnu.org Received: via spool by 65097-submit@debbugs.gnu.org id=B65097.16939236998312 (code B ref 65097); Tue, 05 Sep 2023 14:22:01 +0000 Received: (at 65097) by debbugs.gnu.org; 5 Sep 2023 14:21:39 +0000 Received: from localhost ([127.0.0.1]:57496 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qdWvy-0002A0-V0 for submit@debbugs.gnu.org; Tue, 05 Sep 2023 10:21:39 -0400 Received: from mail-qk1-x735.google.com ([2607:f8b0:4864:20::735]:47449) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qdWvu-00029h-If for 65097@debbugs.gnu.org; Tue, 05 Sep 2023 10:21:37 -0400 Received: by mail-qk1-x735.google.com with SMTP id af79cd13be357-76da239ba16so151814485a.3 for <65097@debbugs.gnu.org>; Tue, 05 Sep 2023 07:21:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693923688; x=1694528488; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=BKQYh03vPB/NQZ91hTYJTXBkvpzHseEwiupp3KotGxM=; b=OXSbs9K1p/Ax6Sz1I3TIiC42reN7ayZH4m58KtEzYKiOMNzKSGrPWj9xOvY6rtWfj7 j13JzgfR1i/dUTYy6wu2YSt5ERmERQIGS/eDYGrbeaq/ZCdlU+z2MbyjXylFfanxdluw bF6UJriKwcDrAX++LmyNzR/WQMZYhzGQIOYPIfLDf52PSdKqatr2eEZaA83uN3+HDkel dSsO670tPnuCC8z5nCttvAKU+C2SXCv2OyZ4ECOCaw36mxfSPrYvoPqjYM18Bnome/SO jBJTv4Cgl/70sW/EUdFhB/U1MnQ88q51SwBujL1lpXSwC82gCXkgzvVb7auzSDcuX1+/ /o2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693923688; x=1694528488; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=BKQYh03vPB/NQZ91hTYJTXBkvpzHseEwiupp3KotGxM=; b=Nu3kZnwayaXatS7IpB83GhEHwFmE3nAkTJVnzhuIl5hroRPuTk+NH0k+wh4jvg37lB EQNMDuK+ESPYMeutkQA/Vx6K00SyRpHIhsgr2posiqWMo/XkIkL3ucZDWRDZx9XQkXUo YuDSw0txsmokkVZDv44PYBCKelNos80KwwGzBrJnGMK17Dy/hDjIxsItvExWvuRswpv1 vRBf+VmRMyAzlSQ4571adpQVtbLlFZHMftC+vyMJLILp4RQiPrmlx+wlcH7dLWW6HA7Z AslmApWN6j6EQOTxegAu/xoiadRAZ7KhVwkMNPz95eIRwadOYoVGmlJQxmfklqREQwJB b2VA== X-Gm-Message-State: AOJu0Ywkkyf+7Z3okifqrJmQnkmo3/Nm6eDSbEN3hT3l/oj6OwDDw6Hk w2Rvl9FRRz7n6Z+g/4avbgjlJU2us5M4GA== X-Google-Smtp-Source: AGHT+IFwePPtyjOZb0aBk4RLFUxGtBRCD0a2eAClgSe3jUGiPUX4U8wz+5BEEh84nWIlkFfO3loq6w== X-Received: by 2002:a05:620a:45a3:b0:76c:ba10:4973 with SMTP id bp35-20020a05620a45a300b0076cba104973mr15573404qkb.37.1693923687730; Tue, 05 Sep 2023 07:21:27 -0700 (PDT) Received: from hurd (dsl-153-125.b2b2c.ca. [66.158.153.125]) by smtp.gmail.com with ESMTPSA id d9-20020a37c409000000b0076f2a76ad60sm4107552qki.99.2023.09.05.07.21.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Sep 2023 07:21:27 -0700 (PDT) From: Maxim Cournoyer References: <637de43ce6edf9cebaf84d3b456901a184e6de82.1691242776.git.cage-dev@twistfold.it> Date: Tue, 05 Sep 2023 10:21:26 -0400 In-Reply-To: <637de43ce6edf9cebaf84d3b456901a184e6de82.1691242776.git.cage-dev@twistfold.it> (cage's message of "Sat, 5 Aug 2023 15:45:53 +0200") Message-ID: <87msy0k8ex.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Scanner: mx2.migadu.com X-Spam-Score: -5.13 X-Migadu-Queue-Id: A47B75265B X-Migadu-Spam-Score: -5.13 X-TUID: hx+ZIqUsQYuj Hi! cage writes: > Hi! > > Note that this patch suffers for some problems: > > - the package will skips the test (it complains "tk" can not be found"); It'd be best to say so in the package, with a XXX comment (meaning subpar/hackish/dirty) like: #:tests #f ;tests fails with "tk" can not be found error > - the manpages will not be installed as make installs exit with an error code because the script 'dtplite' can not be found (seems a TCL script according to README); > > - the license seems X11 to me, but i am unsure (see the last paragraph in the file: "license.terms". > > Any suggestion to improve the patch is appreciated! :) > > Bye! > C. > > --- > gnu/packages/tcl.scm | 40 ++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 40 insertions(+) > > diff --git a/gnu/packages/tcl.scm b/gnu/packages/tcl.scm > index b69dba2254..5bfcc63f96 100644 > --- a/gnu/packages/tcl.scm > +++ b/gnu/packages/tcl.scm > @@ -509,3 +509,43 @@ (define-public go-github.com-nsf-gothic > (description "Gothic contains Go bindings for Tcl/Tk. The package contains > only one type and one function that can be used to create a Tk interpreter.") > (license license:expat)))) > + > + > + > +(define-public tk-img > + (package > + (name "tk-img") > + (version "1.4.14") > + (source > + (origin > + (method url-fetch) > + (uri (string-append > + "mirror://sourceforge/tkimg/tkimg/1.4/tkimg%20" > + version > + "/Img-" version "-Source.tar.gz")) > + (file-name (string-append "tkimg-" version ".tar.gz")) > + (sha256 > + (base32 "08dvb8bfkxr919wp6fq14cfb9lz1v59jx1la4a6j4ks636wb243m")))) > + (build-system gnu-build-system) > + (arguments > + (list #:tests? #f > + #:phases > + #~(modify-phases %standard-phases > + (replace 'install > + (lambda* (#:key outputs #:allow-other-keys) > + (invoke "make" "install-libraries")))) > + #:configure-flags > + #~(list > + (string-append "--exec-prefix=" #$output) > + (string-append "--with-tcl=" > + (assoc-ref %build-inputs "tcl") "/lib") > + (string-append "--with-tk=" > + (assoc-ref %build-inputs "tk") "/lib")))) > + (native-inputs > + (list tcl > + tk)) I'd format on a single line since there are less than 5 dependencies (that's what 'guix style' does). > + (home-page "https://sourceforge.net/projects/tkimg/") > + (synopsis "The Img package adds several image formats to Tcl/Tk.") Synopsis shouldn't be complete sentence but just a very terse expression saying what the package *is*, e.g. "Image library for Tcl/Tk". Debian uses "Extended image format support for Tcl/Tk". > + (description > + "The Img package adds several image formats to Tcl/Tk.") Description should be more generous; here I'd enumerate the specific image formats it adds. Debian uses: --8<---------------cut here---------------start------------->8--- Img is a package to enhance Tk by providing support for various image formats such as XPM, GIF (transparency supported, but not LZW), PNG, JPEG, TIFF, and PostScript. --8<---------------cut here---------------end--------------->8--- It lacks some according to the home page [0]: BMP, GIF, ICO, JPEG, PCX, PNG, PPM, PS, SGI, SUN, TGA, TIFF, XBM, XPM [0] https://sourceforge.net/projects/tkimg/ > + (license license:public-domain))) According to Debian's copyright file (which can be found in http://deb.debian.org/debian/pool/main/libt/libtk-img/libtk-img_1.4.14+dfsg.orig.tar.xz), the licenses used is a mix of the tcl license and public-domain. I'd use (license (list license:tcl/tk license:public-domain)) Reading the last paragraph of license.terms: --8<---------------cut here---------------start------------->8--- GOVERNMENT USE: If you are acquiring this software on behalf of the U.S. government, the Government shall have only "Restricted Rights" in the software and related documentation as defined in the Federal Acquisition Regulations (FARs) in Clause 52.227.19 (c) (2). If you are acquiring the software on behalf of the Department of Defense, the software shall be classified as "Commercial Computer Software" and the Government shall have only "Restricted Rights" as defined in Clause 252.227-7013 (b) (3) of DFARs. Notwithstanding the foregoing, the authors grant the U.S. Government and others acting in its behalf permission to use and distribute the software in accordance with the terms specified in this license. --8<---------------cut here---------------end--------------->8--- I'm not too sure what that really means, even after reading the clauses [1, 2]. [1] https://www.acquisition.gov/far/52.227-19#FAR_52_227_19__d3451e77 [2] https://www.acquisition.gov/dfars/252.227-7013-rights-technical-data%E2%80%94other-commercial-products-and-commercial-services. Although, taking it from a high level, it seems like it implies additional restrictions for the US government, which is incompatible with the free software and thus, the FSDG, which means we cannot distribute this package. I'd be happy to proven wrong, I am not a lawyer. -- Thanks, Maxim