From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id OBybH8OAZWW4SQAAauVa8A:P1 (envelope-from ) for ; Tue, 28 Nov 2023 06:55:15 +0100 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id OBybH8OAZWW4SQAAauVa8A (envelope-from ) for ; Tue, 28 Nov 2023 06:55:15 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 1522B207D7 for ; Tue, 28 Nov 2023 06:55:15 +0100 (CET) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=protonmail.com header.s=protonmail3 header.b=G14EJEcP; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1701150915; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=oOLc8+afqSROYbddsdsLo5ZAEbL2QhUBXyXy+4txSVM=; b=Lli+lTlHFBFW1puYxI2XGt4aJIYWFcAy4QYvFDeD/zXgZt9386b8iqmqN3K1itkMSJEjgU mcQmgd7nKYpXedfFnOkW8QHT0bm75qfADEy7X6Jzp8/Jz0q/a5226C4sZePGlXqfx5iWPG OxV5mgNtwBECNnu8PDPW3Qke+JgpHhhivgRS+gXZ0XygnRhPOys8WIX+R143EMzxMB4TXw zuUiuglzTUuJkqlCc+2Qr5+MHD76Vc8HWw8e1KO2bVaUk4R5YrgaVco6L8BQN2x5Fif3jJ iOI/r00bvdwbrzcbqiYdY+oJmSdToF7SIhBGtnOEmJOIF227e3wQ9nIztKdRxQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=protonmail.com header.s=protonmail3 header.b=G14EJEcP; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Seal: i=1; s=key1; d=yhetil.org; t=1701150915; a=rsa-sha256; cv=none; b=tSZ7thBLW1VFD4SVFE8R64iATlAqXbtvMu7HlZ+e2X0EYim64Yr1ONHAvHXS6ZKMiVdZ7X 4hPDa/Tt9tL+4w3c3+7G9iu9PGI2zdn+AyhP4c84hy1D1Fie27Ry4WgFutYksCcGgAjjzF epzuTA+DEWBuv1oANVH+I6ZfwuPCZyOrA6GDGkKf9+lv5Y5JjVpXWQ3RF3Tt9AKx5ozaKH GUQrZkDhCKXJSZ48EnWG+ZbgyiIJLg8efqdO/EzIyAF5Wa7Tr1YwLJh49FHNbXS7ZcmjMz 2rMHo1ClCw904aUtOZWU9l9x24vOZjZopXYRneczZxPmwWgHxaJI1kqc/riMig== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r7r3h-0006Lo-EK; Tue, 28 Nov 2023 00:54:57 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r7r3f-0006LP-KQ for guix-patches@gnu.org; Tue, 28 Nov 2023 00:54:55 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r7r3f-0007vZ-Ci for guix-patches@gnu.org; Tue, 28 Nov 2023 00:54:55 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1r7r3m-0008Mr-2T for guix-patches@gnu.org; Tue, 28 Nov 2023 00:55:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#65155] [PATCH] gnu: mesa: Add native-search-paths. References: <20230808180851.32652-1-i@dan.games> In-Reply-To: <20230808180851.32652-1-i@dan.games> Resent-From: John Kehayias Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 28 Nov 2023 05:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65155 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: dan Cc: 65155@debbugs.gnu.org Received: via spool by 65155-submit@debbugs.gnu.org id=B65155.170115088532132 (code B ref 65155); Tue, 28 Nov 2023 05:55:02 +0000 Received: (at 65155) by debbugs.gnu.org; 28 Nov 2023 05:54:45 +0000 Received: from localhost ([127.0.0.1]:45339 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r7r3V-0008MC-Ab for submit@debbugs.gnu.org; Tue, 28 Nov 2023 00:54:45 -0500 Received: from mail-4322.protonmail.ch ([185.70.43.22]:37359) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r7r3S-0008Lu-UU for 65155@debbugs.gnu.org; Tue, 28 Nov 2023 00:54:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1701150870; x=1701410070; bh=oOLc8+afqSROYbddsdsLo5ZAEbL2QhUBXyXy+4txSVM=; h=Date:To:From:Cc:Subject:Message-ID:Feedback-ID:From:To:Cc:Date: Subject:Reply-To:Feedback-ID:Message-ID:BIMI-Selector; b=G14EJEcPhCRAlyZUxpnOh85nFpr02rcKEnj41XHmO6+POoDq3Rf6LLm7+PisMc859 HiTwALfvBXGeHKkFRmxzRyqdkGCYSqD5MAuBjhPD9NrrS/0AuvmoKk31bUSvzWEkNJ vdVJZ7yWPIgkh17I+7QqH20Q4R2p/1DjRtgvepxL0XWJlD7bkQbdlcBVx/Vbe3mRaa t2KerVwavdCcJ0yH/l4ARLpBp1/jbkDDIhuttZJ5eq7/GBp0gx9elXYsYBXC7hZaC7 ZBfYtwTbckmuv1ZgncnsF4np7lvutA9VOBcsOsaXfHkkN0uKY8gt8az7ukFrhExptb q/LkcRdgb71fg== Date: Tue, 28 Nov 2023 05:54:25 +0000 Message-ID: <87msuy8lte.fsf@protonmail.com> Feedback-ID: 7805494:user:proton MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: John Kehayias X-ACL-Warn: , John Kehayias via Guix-patches From: John Kehayias via Guix-patches via Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -6.63 X-Spam-Score: -6.63 X-Migadu-Queue-Id: 1522B207D7 X-Migadu-Scanner: mx12.migadu.com X-TUID: nTKYvEtvgh7s Hi, Sorry for the long overdue reply here. On Wed, Aug 09, 2023 at 02:08 AM, dan wrote: > * gnu/packages/gl.scm (mesa) [native-search-paths]: Export XDG_DATA_DIRS. > > According to > https://vulkan.lunarg.com/doc/view/1.3.231.1/linux/loader_and_layer_inter= face.html, > Vulkan loader search for manifest files in several directories. Some of = them > are in the $HOME directory, some of them are set during compile-time. We > don't raelly want vulkan-loader to depend on mesa during compile-time, si= nce > we couldn't assume that mesa is the only package providing Vulkan drivers= . > Thus, it's better for us to export XDG_DATA_DIRS in mesa, so that when bo= th > packages are installed, Vulkan loader could find the corresponding Vulkan > drivers by environment varaible. > I'm not sure if this patch does what you intend. A search-path is defined in the package that consumes the path, meaning the package that looks there for something. The environment variable is then set whenever there is package also in the profile that populates the specified directory. So perhaps this belongs in vulkan-loader? Although I admit I'm less sure for XDG_* related paths. Is there a test case or something we can see if this does what is intended for vulkan? (This did not make it into the just merged mesa-updates but happy to do it on the next round, which could also include changes to vulkan packages if they need a branch.) Apologies for the wait on this one, since I had looked at it a while ago! John > --- > gnu/packages/gl.scm | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/gnu/packages/gl.scm b/gnu/packages/gl.scm > index b53b42a9ba..583cd5a945 100644 > --- a/gnu/packages/gl.scm > +++ b/gnu/packages/gl.scm > @@ -18,6 +18,7 @@ > ;;; Copyright =C2=A9 2021, 2022, 2023 John Kehayias > ;;; Copyright =C2=A9 2022 Petr Hodina > ;;; Copyright =C2=A9 2023 Kaelyn Takata > +;;; Copyright =C2=A9 2023 dan > ;;; > ;;; This file is part of GNU Guix. > ;;; > @@ -518,7 +519,11 @@ (define-public mesa > ;; Ensure the Mesa VDPAU drivers can be found. > (variable "VDPAU_DRIVER_PATH") > (separator #f) > - (files '("lib/vdpau"))))) > + (files '("lib/vdpau"))) > + (search-path-specification > + ;; Ensure the Vulkan drivers can be found by Vulkan loader. > + (variable "XDG_DATA_DIRS") > + (files '("share"))))) > (home-page "https://mesa3d.org/") > (synopsis "OpenGL and Vulkan implementations") > (description "Mesa is a free implementation of the OpenGL and Vulkan > > base-commit: 4547bc6fa3142dca77f7fc912368aeff31bd6e53