unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: Marco Rimoldi <rimarko@libero.it>
Cc: 68052@debbugs.gnu.org
Subject: [bug#68052] [PATCH 3/4] gnu: python-pyportmidi: Update to latest git revision, fixing build fail.
Date: Thu, 04 Jan 2024 13:04:48 -0500	[thread overview]
Message-ID: <87mstl0ybj.fsf@gmail.com> (raw)
In-Reply-To: <f8e15b79edc966a07b01d8f6629fc2c5124fc31a.1703627648.git.rimarko@libero.it> (Marco Rimoldi's message of "Tue, 26 Dec 2023 23:15:54 +0100")

Hello,

Marco Rimoldi <rimarko@libero.it> writes:

Please write GNU ChangeLog commit messages, as mentioned in info '(guix)
Submitting Patches'.  This makes it easy to review the changes and match
if the actual changes match the author's intent.

> Change-Id: Ibe02edca39731f3f3c9001818665d2da97df9465
> ---
>  gnu/packages/music.scm | 52 ++++++++++++++++++------------------------
>  1 file changed, 22 insertions(+), 30 deletions(-)
>
> diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
> index 77e952d383..6f1736a276 100644
> --- a/gnu/packages/music.scm
> +++ b/gnu/packages/music.scm
> @@ -3048,36 +3048,28 @@ (define-public portmidi
>      (license license:expat)))
>  
>  (define-public python-pyportmidi
> -  (package
> -    (name "python-pyportmidi")
> -    (version (package-version portmidi))
> -    (source (package-source portmidi))
> -    (build-system python-build-system)
> -    (arguments
> -     `(#:tests? #f ; no tests included
> -       #:phases
> -       (modify-phases %standard-phases
> -         (add-after 'unpack 'enter-dir
> -           (lambda _ (chdir "pm_python") #t))
> -         (add-after 'enter-dir 'fix-setup.py
> -           (lambda _
> -             (substitute* "setup.py"
> -               ;; Use Python 3 syntax
> -               (("print (\".*\")" _ text)
> -                (string-append "print(" text ")\n"))
> -               ;; TODO.txt and CHANGES.txt don't exist
> -               (("CHANGES =.*") "CHANGES = \"\"\n")
> -               (("TODO =.*") "TODO = \"\"\n"))
> -             #t)))))
> -    (inputs
> -     (list portmidi alsa-lib))
> -    (native-inputs
> -     (list python-cython unzip))
> -    (home-page "https://portmedia.sourceforge.net/portmidi/")
> -    (synopsis "Python bindings to PortMidi")
> -    (description
> -     "This package provides Python bindings to the PortMidi library.")
> -    (license license:expat)))
> +  (let ((commit "d9e5ee00b208b09618fa0d4a5bbce3c9c077b386")
> +        (revision "0"))
> +    (package
> +      (name "python-pyportmidi")
> +      (version (git-version "0.0.7" revision commit))
> +      (source (origin
> +                (method git-fetch)
> +                (uri (git-reference
> +                      (url "https://github.com/PortMidi/pm_python.git")
> +                      (commit commit)))
> +                (sha256 (base32 "1jvp9na8d1hw46w9ybhkimbavfb3ysw7hp30cbk6dj40k5y5vgvz"))
> +                (file-name (git-file-name name version))))
> +      (build-system python-build-system)
> +      (inputs
> +        (list portmidi alsa-lib))
> +      (native-inputs
> +        (list python-cython))
> +      (home-page "https://github.com/PortMidi")
> +      (synopsis "Python bindings to PortMidi")
> +      (description
> +        "This package provides Python bindings to the PortMidi library.")
> +      (license license:expat))))

Otherwise LGTM.

-- 
Thanks,
Maxim




  reply	other threads:[~2024-01-04 18:06 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-26 22:10 [bug#68052] [PATCH 0/4] Collected patches fixing builds of various Frescobaldi dependencies Marco Rimoldi via Guix-patches via
2023-12-26 22:14 ` [bug#68052] [PATCH 1/4] gnu: python-poppler-qt5: update to 21.3.0 Marco Rimoldi via Guix-patches via
2024-01-04 18:00   ` Maxim Cournoyer
2023-12-26 22:14 ` [bug#68052] [PATCH 2/4] gnu : python-poppler-qt5: Remove no longer needed patch Marco Rimoldi via Guix-patches via
2024-01-04 18:02   ` Maxim Cournoyer
2023-12-26 22:15 ` [bug#68052] [PATCH 3/4] gnu: python-pyportmidi: Update to latest git revision, fixing build fail Marco Rimoldi via Guix-patches via
2024-01-04 18:04   ` Maxim Cournoyer [this message]
2024-01-04 18:06   ` Maxim Cournoyer
2023-12-26 22:16 ` [bug#68052] [PATCH 4/4] gnu: portmidi: Add variant portmidi-2 updated to release 2.0.4 Marco Rimoldi via Guix-patches via
2024-01-04 18:07   ` Maxim Cournoyer
2024-01-16  0:34 ` [bug#68052] [PATCH v1 0/3] Collected patches fixing builds of various Frescobaldi dependencies Marco Rimoldi via Guix-patches via
2024-01-16  0:34   ` [bug#68052] [PATCH v1 1/3] gnu: python-poppler-qt5: Update to 21.3.0 Marco Rimoldi via Guix-patches via
2024-01-16  0:34   ` [bug#68052] [PATCH v1 2/3] gnu: python-pyportmidi: Update to first working git revision since project restarted development, fixing build Marco Rimoldi via Guix-patches via
2024-01-16  0:34   ` [bug#68052] [PATCH v1 3/3] gnu: portmidi: Add variant portmidi-2 updated to release 2.0.4 Marco Rimoldi via Guix-patches via
2024-01-16 17:37 ` [bug#68052] [PATCH v2 0/3] Collected patches fixing builds of various Frescobaldi dependencies Marco Rimoldi via Guix-patches via
2024-01-16 17:37   ` [bug#68052] [PATCH v2 1/3] gnu: python-poppler-qt5: Update to 21.3.0 Marco Rimoldi via Guix-patches via
2024-01-16 17:37   ` [bug#68052] [PATCH v2 2/3] gnu: python-pyportmidi: Update to first working git revision since project restarted development, fixing build Marco Rimoldi via Guix-patches via
2024-01-16 17:37   ` [bug#68052] [PATCH v2 3/3] gnu: portmidi: Add variant portmidi-2 updated to release 2.0.4 Marco Rimoldi via Guix-patches via
2024-02-21 19:30 ` [bug#68052] [PATCH v3 1/4] gnu: python-poppler-qt5: Update to 21.3.0 Marco Rimoldi via Guix-patches via
2024-02-21 19:30   ` [bug#68052] [PATCH v3 2/4] gnu: python-pyportmidi: Update to first working git revision since project restarted development, fixing build Marco Rimoldi via Guix-patches via
2024-02-21 19:30   ` [bug#68052] [PATCH v3 3/4] gnu: portmidi: Add variant portmidi-2 updated to release 2.0.4 Marco Rimoldi via Guix-patches via
2024-02-21 19:30   ` [bug#68052] [PATCH v3 4/4] gnu: frescobaldi: Make it display icons with qtsvg-5 Marco Rimoldi via Guix-patches via
2024-03-16 10:12   ` [bug#68052] [PATCH v3 1/4] gnu: python-poppler-qt5: Update to 21.3.0 Christopher Baines

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mstl0ybj.fsf@gmail.com \
    --to=maxim.cournoyer@gmail.com \
    --cc=68052@debbugs.gnu.org \
    --cc=rimarko@libero.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).