unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Mathieu Othacehe <othacehe@gnu.org>
To: Tomas Volf <~@wolfsden.cz>
Cc: 68305@debbugs.gnu.org
Subject: [bug#68305] [PATCH] gnu: Add guile-srfi-197.
Date: Fri, 12 Jan 2024 17:10:50 +0100	[thread overview]
Message-ID: <87mstar0qd.fsf@gnu.org> (raw)
In-Reply-To: <021a14380a3d701f4dddbac72b83bf34bdea4558.1704640177.git.~@wolfsden.cz> (Tomas Volf's message of "Sun, 7 Jan 2024 16:09:44 +0100")


Hello,

> +(define-public guile-srfi-197
> +  (let ((commit "d31b8be86460bf837cccf2737a1b9b9c01788573")
> +        (revision "0"))

You should explain why you are not using a release with a comment. The
"final" tag for instance.

> +        #~(modify-phases %standard-phases
> +            (add-after 'unpack 'create-module
> +              (λ _

Please use 'lambda'.

> +SRFI defines a family of chain and nest pipeline operators, which can rewrite
> +nested expressions like (a b (c d (e f g))) as a sequence of operations:

@code{(a b (c d (e f g)))}

> +(chain g (e f _) (c d _) (a b _)).")

@code{(chain g (e f _) (c d _) (a b _)).")}

Can you please send a v2?

Thanks,

Mathieu




  reply	other threads:[~2024-01-12 16:22 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-07 15:09 [bug#68305] [PATCH] gnu: Add guile-srfi-197 Tomas Volf
2024-01-12 16:10 ` Mathieu Othacehe [this message]
2024-01-12 16:47   ` Tomas Volf
2024-01-13  9:22     ` Mathieu Othacehe
2024-01-12 16:46 ` [bug#68305] [PATCH v2] " Tomas Volf
2024-01-13  9:40   ` bug#68305: " Mathieu Othacehe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mstar0qd.fsf@gnu.org \
    --to=othacehe@gnu.org \
    --cc=68305@debbugs.gnu.org \
    --cc=~@wolfsden.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).