unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: Herman Rimm <herman@rimm.ee>
Cc: 52530@debbugs.gnu.org, Efraim Flashner <efraim@flashner.co.il>
Subject: [bug#52530] [PATCH core-updates-frozen] WIP: Add rust-gtk4 and dependencies
Date: Sun, 21 Jan 2024 23:46:43 -0500	[thread overview]
Message-ID: <87mssy3rgs.fsf_-_@gmail.com> (raw)
In-Reply-To: <211a0295dea59885497541095b79036686a20345.1703429638.git.herman@rimm.ee> (Herman Rimm's message of "Sun, 24 Dec 2023 16:27:30 +0100")

Hi Herman,

Herman Rimm <herman@rimm.ee> writes:

> * gnu/packages/crates-gtk.scm (rust-gdk4-0.6): New variable.
> (rust-graphene-rs-0.17): New variable.
> (rust-graphene-sys-0.17): New variable.
> (rust-gsk4-0.6): New variable.
> (rust-gsk4-sys-0.6): New variable.
> (rust-gtk4-0.6): New variable.
> (rust-gtk4-macros-0.6): New variable.
> (rust-gtk4-sys-0.6): New variable.
> ---
> Hello,
>
> Should each package be added in a separate patch?

That's our convention, yes!  Could you please send a v2 with one package
per commit?

> The latest gtk4-rs version is 0.7, I chose 0.6 because it has more
> compatible dependencies. gtk4-rs can be updated to 0.7 together with
> those dependencies. For the new packages, guix lint notes the newer
> version and that the source is not archived on Software Heritage etc..
>
> The package descriptions are still single sentences, so it can't be
> merged. But I mail this patch for people who would like to use newer
> gtk4-rs packages despite that. Please improve the descriptions if you
> feel like it.

It'd be nice if you could write a few more words about what features
these packages provides and try a bit harder for the tests (at least to
the point where a more detailed comment about the situation can be
written than "tests failed").

-- 
Thanks,
Maxim




  reply	other threads:[~2024-01-22  4:48 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-15 23:05 [bug#52530] [PATCH core-updates-frozen] WIP: Add rust-gtk4 and dependencies Nicholas von Klitzing
2021-12-19  4:42 ` Maxim Cournoyer
2022-01-08  9:10   ` Nicholas von Klitzing via Guix-patches via
2023-12-24 15:27 ` [bug#52530] [PATCH] gnu: " Herman Rimm via Guix-patches via
2024-01-22  4:46   ` Maxim Cournoyer [this message]
2024-01-25 17:47     ` [bug#52530] [PATCH core-updates-frozen] WIP: " Herman Rimm via Guix-patches via
2024-01-27  3:15       ` bug#52530: " Maxim Cournoyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mssy3rgs.fsf_-_@gmail.com \
    --to=maxim.cournoyer@gmail.com \
    --cc=52530@debbugs.gnu.org \
    --cc=efraim@flashner.co.il \
    --cc=herman@rimm.ee \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).