From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: cage <cage-dev@twistfold.it>
Cc: 69355@debbugs.gnu.org
Subject: [bug#69355] [PATCH] gnu: Add libgrapheme.
Date: Mon, 26 Feb 2024 11:24:42 -0500 [thread overview]
Message-ID: <87msrnjir9.fsf@gmail.com> (raw)
In-Reply-To: <505f3bdf672b32d2d9413ed2e4d83a769518d9ea.1708780937.git.cage-dev@twistfold.it> (cage's message of "Sat, 24 Feb 2024 14:24:09 +0100")
Hi,
cage <cage-dev@twistfold.it> writes:
> Change-Id: If19bc5534b8bc3d0aeda4f1e70baa8d42e4948e0
> ---
> gnu/packages/suckless.scm | 30 ++++++++++++++++++++++++++++++
> 1 file changed, 30 insertions(+)
>
> diff --git a/gnu/packages/suckless.scm b/gnu/packages/suckless.scm
> index 81e2151854..e71b0e9252 100644
> --- a/gnu/packages/suckless.scm
> +++ b/gnu/packages/suckless.scm
> @@ -1393,3 +1393,33 @@ (define-public 9base
> (description
> "This package provides ported versions of various Plan 9 userland tools
> for Unix.")))
> +
> +(define-public libgrapheme
> + (package
> + (name "libgrapheme")
> + (version "2.0.2")
> + (source
> + (origin
> + (method url-fetch)
> + (uri (string-append "https://dl.suckless.org/libgrapheme/libgrapheme-"
> + version
> + ".tar.gz"))
> + (sha256
> + (base32 "099i2jm9c25nkbg5420wr12z0gd189gcw5j1ssjmpmbbwzfvv2x6"))))
> + (build-system gnu-build-system)
> + (arguments
> + (list #:tests? #f
We strive to enable test suites of packages in Guix, as this gives us a
chance to detect breakage across updates. Its page mentions a 'test'
target to run the conformance and unit tests of libgrapheme. Did you
try it, via #:test-target "test" ? (the default is "check", which is
most common).
> + #:phases #~(modify-phases %standard-phases
> + (add-after 'configure 'post-configure
> + (lambda _
> + (substitute* "config.mk"
Please leave an explanatory comment mentioning that running ldconfig is
not needed on Guix.
> + (("ldconfig") "")))))
> + #:make-flags
> + #~(list (string-append "CC=" #$(cc-for-target))
> + (string-append "PREFIX=" #$output))))
> + (home-page "https://libs.suckless.org/libgrapheme/")
> + (synopsis "Library to handle string according to Unicode standard")
> + (description "Libgrapheme is an extremely simple freestanding C99 library
> +providing utilities for properly handling strings
> +according to the latest Unicode standard 15.0.0.")
nitpick: The paragraph flow seems broken after 'handling strings' --
"M-;" in Emacs would help.
I'd also drop the exact Unicode standard currently targeted, as this
would probably become outdated information soon.
Could you send a v2 with the above changes?
--
Thanks,
Maxim
next prev parent reply other threads:[~2024-02-26 16:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-24 13:24 [bug#69355] [PATCH] gnu: Add libgrapheme cage
2024-02-26 16:24 ` Maxim Cournoyer [this message]
2024-02-27 18:51 ` cage
2024-04-01 1:26 ` bug#69355: " Maxim Cournoyer
2024-04-02 16:36 ` [bug#69355] " cage
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87msrnjir9.fsf@gmail.com \
--to=maxim.cournoyer@gmail.com \
--cc=69355@debbugs.gnu.org \
--cc=cage-dev@twistfold.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).