From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id aEBkIE1B/GU0DwAAqHPOHw:P1 (envelope-from ) for ; Thu, 21 Mar 2024 15:16:45 +0100 Received: from aspmx1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id aEBkIE1B/GU0DwAAqHPOHw (envelope-from ) for ; Thu, 21 Mar 2024 15:16:45 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=GRNWwSL7; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1711030605; a=rsa-sha256; cv=none; b=hRMUA0diu2LSEgP5Lvs/5BJBwgQp8TGlta/BXsK12rNmBmOs8KpvoyEVaGXlhedZgNnhYA Mlb52sKkIBn3XVApJDcAyWL+VC/f6wFDB50CxmoDH5r1hbJoqtDgKHKb18z9kOwgKLyC/D Ggw14mhpE8m6gBRftTBL7g8w5cpoi/dT400+igtjOrGzSCIQhn5NbX5UGBhJi8UXJ5B+lW fJnCbeKnA45u2V9IVbyNsGJ42KkaiqzFQT1Pq369s50jzADnAqg0RR/3GPnttEIbUHGEA0 JJ11PzLZzyj8xfSeUhrj0aT08nFw9RFfXMrHYFQg9kkkvwchVjR2Pqs9bwKz3g== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=GRNWwSL7; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1711030605; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=KWjn3/qSK4K/HbQBbIJ3vjglCUb7pGBgcT19IZ/RLV8=; b=ClwW9E3Fh4o2cjBR8w6HoNmNLvMX1c/UWAJ5lcr5eJZ6S/rRhve7Ot8sYpEpR6Rh5xHpQ0 KK/IoV9oPrOc3W/a7M6emHxL5s0O6LZyg3NsL8oX+hdu9Vz45nAkuIvItLNseW8k3uMLHw QHynnzJYeEhFdfgEdX6+emfpMBrzKhrTuEA3MWRqGj1hPcjCkX6+Pu0tmUHbkPXmNQTZhQ hRd2ZyJ/7mTtNdm9WdpVr3/Ze4g1DvsqKWVIEKTvSR/UIGzH3U75rfDp9daGlhK7kX+CjC hKEdKw5ORen+7t+71Rjh8AQlf6FLWVQANqc4WSPFfbpUWv2gC9Z9fZdD8BpbGg== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 321B7C063 for ; Thu, 21 Mar 2024 15:16:45 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rnJDV-0006Ni-7W; Thu, 21 Mar 2024 10:16:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rnJDS-0006NN-9f for guix-patches@gnu.org; Thu, 21 Mar 2024 10:16:22 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rnJDR-0000hN-Ue for guix-patches@gnu.org; Thu, 21 Mar 2024 10:16:21 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rnJE5-0005pN-K0 for guix-patches@gnu.org; Thu, 21 Mar 2024 10:17:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#69780] [PATCH 4/4] DRAFT news: Add entry for =?UTF-8?Q?=E2=80=98guix?= git =?UTF-8?Q?authenticate=E2=80=99?= changes. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 21 Mar 2024 14:17:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69780 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Skyler Ferris Cc: 69780@debbugs.gnu.org, Julien Lepiller , Florian Pelz Received: via spool by 69780-submit@debbugs.gnu.org id=B69780.171103060622369 (code B ref 69780); Thu, 21 Mar 2024 14:17:01 +0000 Received: (at 69780) by debbugs.gnu.org; 21 Mar 2024 14:16:46 +0000 Received: from localhost ([127.0.0.1]:37009 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rnJDp-0005oh-CF for submit@debbugs.gnu.org; Thu, 21 Mar 2024 10:16:45 -0400 Received: from eggs.gnu.org ([209.51.188.92]:57360) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rnJDl-0005oG-B5 for 69780@debbugs.gnu.org; Thu, 21 Mar 2024 10:16:44 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rnJAs-0000BI-CU; Thu, 21 Mar 2024 10:13:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=KWjn3/qSK4K/HbQBbIJ3vjglCUb7pGBgcT19IZ/RLV8=; b=GRNWwSL7MH5upwoAGhQu MPbPgOJCniEhLktrR3XhNSpKiMXxKNcPYxz1Y98UFx+p7ppRJcQQSZUj2+ZYT2Wc6csD69dPZiArY m/6gvWUY2W/8LIKJGZemnf+Z0bHIi0I4jsIobiKvnUI5wi9EiF3AtCwgAa403U56xFM57b+yEU9oF 4Gi931gzL2DSIuJe5Y3KvaD/98+/nVDUp78U2zOagJrpejn6DhJDyeFzYkUl9Md7cI6xlIL0AF28Y bUCwT/EcYBKug8Sq6CdkaQipyWprsG+qP5WAl/gSaYYuQXoyrtizeDHsaEPbjcCgOMSVepWQOokRP URvyryWmlT7G4A==; From: Ludovic =?UTF-8?Q?Court=C3=A8s?= In-Reply-To: <7c5370b7-09d6-4614-9b47-eb760c0a95f4@protonmail.com> (Skyler Ferris's message of "Thu, 21 Mar 2024 01:43:09 +0000") References: <73ead80c-9159-4e03-b2a7-68434cade060@protonmail.com> <8734sm48f5.fsf@gnu.org> <7c5370b7-09d6-4614-9b47-eb760c0a95f4@protonmail.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: Duodi 2 Germinal an 232 de la =?UTF-8?Q?R=C3=A9volution, ?= jour du Platane X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Thu, 21 Mar 2024 15:13:39 +0100 Message-ID: <87msqrvfjg.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Scanner: mx10.migadu.com X-Migadu-Spam-Score: -7.22 X-Spam-Score: -7.22 X-Migadu-Queue-Id: 321B7C063 X-TUID: spyMO6t7kEO4 Hi! Skyler Ferris skribis: > Fair enough, that can be addressed in a separate patch. On a related note= , this patch reminded me of an idea I mentioned in a private thread with th= e security team about writing a package that provides `guix git authenticat= e` as a standalone script, which can be done by extracting the dependent mo= dules and building just them (I have successfully done this for the "(guix = build utils)" library, for shell-like guile scripts that have a lighter foo= tprint than all of guix). This will help people who are installing guix fro= m source for the first time. They will not have guix itself available, but = it would be easier for them to use the standalone script than to install al= l of guix (which they will presumably be replacing anyway). Is there anythi= ng else around `guix git authenticate` you are working on that might confli= ct with this? I am starting to look at it now that I have been reminded. I must say I=E2=80=99m usually focusing on the use case where people buildi= ng Guix from source already have a working Guix installation. In that case, it=E2=80=99s that installation that provides a source of trust. For someone building entirely from source, I don=E2=80=99t know what the ri= ght solution is. It could be extracting =E2=80=98guix git authenticate=E2=80= =99 as you say, but then we=E2=80=99re just offsetting the problem. We could just as well recommend building from a signed tag (or signed source tarball) after verifying it. Dunno what a good bootstrapping story might be. >> I spent time looking for the =E2=80=9Cright=E2=80=9D hook and couldn=E2= =80=99t find anything >> really satisfying. Ideally, I=E2=80=99d want a hook that runs on =E2=80= =98fetch=E2=80=99, for >> each new reference. >> >> Is post-merge better than post-checkout? githooks(5) says =E2=80=98post= -merge=E2=80=99 >> =E2=80=9Cis invoked by git-merge(1), which happens when a git pull is do= ne on a >> local repository.=E2=80=9D Is it actually invoked when =E2=80=98git pul= l=E2=80=99 does *not* >> trigger a merge? > > That gave me pause too, but I tested it with a pull that caused a fast-fo= rward (no separate merge commit) and it still ran the hook. I looked for a = `post-fetch` hook but couldn't find one, I agree that would be ideal. OK, thanks for checking. >> Using this configuration format, it seems there=E2=80=99s no room left f= or a >> branch name, or am I overlooking something? [...] > Hmm, I didn't realize that git limited the number of components available= in config names, but it looks like you're correct - my suggestion of appen= ding `.branch-name` caused git to produce an error that the config was inva= lid. > > But we don't necessarily need git to be aware of the semantic meaning of = the branch name since the value is calculated by the guile script. So we co= uld just use a hyphen as a separator and have "introduction-commit-master" = and "introduction-commit-feature" as separate values unrelated to each othe= r (aside from being in the "guix authentication" namespace). Hmm right. Not pretty, but why not. We could still have =E2=80=98introduction-commit=E2=80=99 as a default, and =E2=80=98introduction-commit-BRANCH=E2=80=99 would take precedence over it = when present. Thanks for your feedback! Ludo=E2=80=99.