From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms1.migadu.com with LMTPS id yDIiJBn6HmZTJwEA62LTzQ:P1 (envelope-from ) for ; Wed, 17 Apr 2024 00:22:17 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id yDIiJBn6HmZTJwEA62LTzQ (envelope-from ) for ; Wed, 17 Apr 2024 00:22:17 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1713306137; a=rsa-sha256; cv=none; b=QdCMx8nnffocFLwewvN4TIvMPXNauTWtdVgrov5xhQLwIcFrYtZHA1rT9ae2B/6Gr0lx0/ 6/LsG07YvhcSZq4D2ifmjnrSFQh6Tyr6Swo3v7X9AhhMYZqbnBmsBfMZHe8mN0WUm6J9kD qo46IFs9EpHg26PoaA15jt+1tKOq8InTDAf5y5nX5hjFiB3ewUUVhGo6qoAIq7jpKeRDO7 icBzoLuN5At3dWZzxIDRrXRAGIVXcln0U8N+YXCp+0HsMy+Xr7jXXn0mwWEgj0AaVuZV1V 4Prjqaw/bs7mrP1ZSa5YmOC6lhr7thVjPbKJRsinJx0verBLgbNvZrioy3yY+Q== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1713306137; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-to:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post; bh=ehs4Bik2nftCcJoZ1F3iTA3XyrQHeiospLa+YElLVbI=; b=PSTsR6hVSXe93C9ogfbGrie+BY+1b/1KjyDzaYx/rLWF3IEF2CIhQ9TUwVRbcJD26QsUTE 0IQWr2xntEpnEd6jt3SKb+OALpszmh94DgbIbSfiQBk9tXtpNNzI1VPc8J3fsuV+YbH7P8 j04ZvlRIAcL2BbKreXcI4lnIFEPHYWOXymzDUVchkGXsV91TDq0pF0o5XNYTx/9NMOyw2f Na7dYXceBg4JcmMne0U/XJrAqtc7apZoE8MhjantYgLydTerBt9svfU/XdV/ypZZvtZyIf Kd8pPOLN3P63GfD+eEgI+gZ/YGbDYmc0jFIJHnW4gJBXBe8lC5Hi5ns89a19Jg== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 3CB1C24FD2 for ; Wed, 17 Apr 2024 00:22:16 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rwrBe-0003aM-TD; Tue, 16 Apr 2024 18:21:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rwrBY-0003ZW-Sv for guix-patches@gnu.org; Tue, 16 Apr 2024 18:21:53 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rwrBY-0008SG-KJ for guix-patches@gnu.org; Tue, 16 Apr 2024 18:21:52 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rwrBl-0000Ki-1O for guix-patches@gnu.org; Tue, 16 Apr 2024 18:22:05 -0400 Subject: bug#70407: [PATCH] gnu: Add fnc Resent-From: Christopher Baines Original-Sender: "Debbugs-submit" Resent-To: guix-patches@gnu.org Resent-Date: Tue, 16 Apr 2024 22:22:04 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 70407 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: "ashish.is--- via Guix-patches" via , Daniel Ziltener Cc: 70407-done@debbugs.gnu.org, ashish.is@lostca.se Mail-Followup-To: 70407@debbugs.gnu.org, mail@cbaines.net, ashish.is@lostca.se Received: via spool by 70407-done@debbugs.gnu.org id=D70407.17133061051160 (code D ref 70407); Tue, 16 Apr 2024 22:22:04 +0000 Received: (at 70407-done) by debbugs.gnu.org; 16 Apr 2024 22:21:45 +0000 Received: from localhost ([127.0.0.1]:45338 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rwrBQ-0000Ie-Mb for submit@debbugs.gnu.org; Tue, 16 Apr 2024 18:21:45 -0400 Received: from mira.cbaines.net ([212.71.252.8]:43346) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rwrBO-0000IQ-B4 for 70407-done@debbugs.gnu.org; Tue, 16 Apr 2024 18:21:43 -0400 Received: from localhost (unknown [212.132.255.10]) by mira.cbaines.net (Postfix) with ESMTPSA id 4BFE427BBE9; Tue, 16 Apr 2024 23:21:29 +0100 (BST) Received: from felis (localhost.lan [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id 6a9b4622; Tue, 16 Apr 2024 22:21:28 +0000 (UTC) From: Christopher Baines In-Reply-To: <57b18e1298ae636df0fa11968978adcf227a0cab.1713212712.git.ashish.is@lostca.se> (ashish is's message of "Mon, 15 Apr 2024 20:25:12 +0000") References: <57b18e1298ae636df0fa11968978adcf227a0cab.1713212712.git.ashish.is@lostca.se> User-Agent: mu4e 1.12.2; emacs 29.3 Date: Tue, 16 Apr 2024 23:21:26 +0100 Message-ID: <87msptt0d5.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Spam-Score: -8.48 X-Migadu-Queue-Id: 3CB1C24FD2 X-Migadu-Spam-Score: -8.48 X-Migadu-Scanner: mx10.migadu.com X-TUID: JZa5jvfzueOE --=-=-= Content-Type: text/plain "ashish.is--- via Guix-patches" via writes: > From: Ashish SHUKLA > > * gnu/packages/version-control.scm (fnc): New variable. > > Change-Id: Idf1cb254c3ae18bacb86bf020511a5d34e2d3684 > Signed-off-by: Ashish SHUKLA > --- > gnu/packages/version-control.scm | 25 +++++++++++++++++++++++++ > 1 file changed, 25 insertions(+) > > diff --git a/gnu/packages/version-control.scm b/gnu/packages/version-control.scm > index 96ca1df552..33607940ec 100644 > --- a/gnu/packages/version-control.scm > +++ b/gnu/packages/version-control.scm > @@ -4145,3 +4145,28 @@ (define-public git-sizer > (description "Compute various size metrics for a Git repository, flagging > those that might cause problems or inconvenience.") > (license license:expat))) > + > +(define-public fnc > + (package > + (name "fnc") > + (version "0.16") > + (source (origin > + (method url-fetch) > + (uri > + (string-append "https://fnc.bsdbox.org/uv/dl/fnc-" version ".tar.gz")) > + (sha256 > + (base32 > + "1npnbdz5i4p61ri76vx6awggbc0q19y8b26l3sy4wxmaxkly7gwy")))) > + (build-system gnu-build-system) > + (arguments > + '(#:phases (modify-phases %standard-phases > + (delete 'configure)) > + #:tests? #f > + #:make-flags (list "CC=gcc" > + (string-append "PREFIX=" (assoc-ref %outputs "out"))))) The arguments needed a bit of touching up. Using gexp's is the new style. It's unclear why the tests are disabled, I guess it's because there are no tests so I've added a comment to this effect. Hardcoding CC=gcc also causes problems for cross building, so use (cc-for-target) instead. > + (inputs (list ncurses zlib sqlite-next)) > + (home-page "https://fnc.bsdbox.org") > + (synopsis "Interactive text-based user interface for Fossil") > + (description "fnc uses ncurses and libfossil to create a fossil ui experience in > +the terminal, and parse local changes at the hunk level to prepare atomic commits.") > + (license license:isc))) > > base-commit: a8353e9d6b34fd8d42d2e8f14ce844849fe9c293 I did have a quick check over the source, including a concatenated sqlite seems unusual and not ideal, but I'm not quite sure how it's used. One final change I made was moving the package definition up off the bottom of the file (as if everyone adds new packages there, it causes merge conflicts). I've pushed this to master with the changes I describe as a45b2c7c63c6af9c42698e12b6809c41c0926de3 so please take a look. Thanks, Chris --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAmYe+eZfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh aW5lcy5uZXQACgkQXiijOwuE9Xcbzg//RnDzOf8x5I7xLOMd1N6TiTythTxui+5r HvT4cVq0ElzzPj/KAi2ITX/VbGKJ0/FoDL+pZJu9y6OfPmwUTr8uzcdGvtJmO7Yv Kx7fsTde5EkpCGwWZo9GHepgoYIuGzVt+Jwk5vWnDfxsZAzD4E8+6b6ZHEfehXlQ /ydJXJi0aZWpBwuPqQ5QNR0TqffOz2YELUAi25QD3VQSakQaSlkTEjj6PAM1Ve6B t2K+zkATYfzzxj0opN1nOBSrEvwrYosTkrMz8zIYipvXNzxcyD6+8MAVfmjbJ7NA eoTeqZNth4mKS3JK0+94dcbmWVPKaYb7sRpJg/bPR0ZGW+KapUBnyN+l5WmROfAk 6aU/o5MF9nfefeqgj7cDo86ffCBB3ioyhNfm2/KTVoXOr8/PCCygomcPhz2D76qz aTMah8C+FTGHw6bSGbCCuVmDs68rC3+4Utjgt8B9xiBwg3FZ0F2I1xLKuuner6Tz VsD3YWoX4fP7HkTBGQNmwjFxLp5jM8/qUp6e5yu8i0bGeCt7JxVxfQyj/n9k9cpm dj7sdUT9Y3Zhp+0TF9VmB7u7WbMa/ekCtpKxg7G9AhbK94DSV2VhH8ZQacLr5f7O RsnRppbCV2F/tFkBtX0P7cGxI02mr1TKzQY5tNFr82+KmBsfi4HFGjlNPq0rJKJ0 xtpeAHOysHM= =MunI -----END PGP SIGNATURE----- --=-=-=--