From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms1.migadu.com with LMTPS id YHyzAZa8WWaJ5AAAe85BDQ:P1 (envelope-from ) for ; Fri, 31 May 2024 14:03:34 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id YHyzAZa8WWaJ5AAAe85BDQ (envelope-from ) for ; Fri, 31 May 2024 14:03:34 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=Gq+pp0T9; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1717156981; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=dUm7PPx2zj/cONWkJBwwAKzfJuHNuXjRWV8vrITOAk8=; b=IMfbmJ7/1F19KnqRc5rZrE4d/VKRjMUMMUSsDy3pZ732G5NulAUFPykX0KkHopEs/bAAZL YdUkkp5hbDBOEvEHGTM/BggEXf+Mbzr7Cnn9m8/xwRwIKZlKp6c09SOYrUj6guIgfPTdFM chboJJSPQhWgs/V3fwVggJqm2ek+SgGdbcrbvTuLB8g4ucdN0Gau4CtzgunnJiRnCLU7lP 1ni9/rAu/fjbpHkirmltuG2TMPSgAhJj5bQC9XiGlHjdsNRcTgvWtMZs8PxApKOIL89x4O 8YZ6nDvxZURNzcS8lmPykqMC7XHdX+LBhmzJRBf6KFkp9AE5jIGzN8ZR/zGu+A== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=Gq+pp0T9; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Seal: i=1; s=key1; d=yhetil.org; t=1717156981; a=rsa-sha256; cv=none; b=MLUYHwHg8QgTq/Tsd3W856mKNMil+4WaS/mZOiVOzkGm9Rlw2XfFcYnzzR7Ej21h/4VtYL gf6vNEBtkBHBmSuf4LRpMJSUKvkDio80GasqAFVHBSU1gbpaRkirVXi1Ov+a+qrmNMVOD+ 7JRW4XfKSmCSriRxpBdBmyhEW8tVdoAIqeYhXwuad7t3gTO3HhsJ/uVvQS/0ZZjoS3QHkd /0e4IEG8KjOmRnMWJ21mWa6CmRMeDqgIfqOU64fwQf3Trsi+GOLBjqevSNblapZvnv1x1k Zj2fOvy5pvf01QnN8xCNdb+0efRhS7rkhwBokWjE/8zYSE+6dxwBiBj0U+memg== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D79C76CE80 for ; Fri, 31 May 2024 14:03:01 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sD0yH-000430-18; Fri, 31 May 2024 08:02:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sD0yC-00040p-V1 for guix-patches@gnu.org; Fri, 31 May 2024 08:02:53 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sD0yB-0003G1-BC for guix-patches@gnu.org; Fri, 31 May 2024 08:02:52 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sD0yM-0004i1-BL for guix-patches@gnu.org; Fri, 31 May 2024 08:03:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#70933] [PATCH] system: Do not add "--disable-chroot" to containers. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 31 May 2024 12:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70933 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Andreas Enge Cc: 70933@debbugs.gnu.org Received: via spool by 70933-submit@debbugs.gnu.org id=B70933.171715692218014 (code B ref 70933); Fri, 31 May 2024 12:03:02 +0000 Received: (at 70933) by debbugs.gnu.org; 31 May 2024 12:02:02 +0000 Received: from localhost ([127.0.0.1]:53461 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sD0xO-0004gT-FY for submit@debbugs.gnu.org; Fri, 31 May 2024 08:02:02 -0400 Received: from eggs.gnu.org ([209.51.188.92]:37190) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sD0xM-0004g0-Kj for 70933@debbugs.gnu.org; Fri, 31 May 2024 08:02:01 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sD0x1-0002wd-O1; Fri, 31 May 2024 08:01:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=dUm7PPx2zj/cONWkJBwwAKzfJuHNuXjRWV8vrITOAk8=; b=Gq+pp0T91SjDxCr/3W7R 3VdQP4xIJPoeppOcQAMGNjYz4wgl+6F++ybs8A+2FQVJq9q3eW7UGjR/y/ZwHe73rbNSV+A8BkVy9 nx7w8RvFK6Zd0Y4UXubaF1fnirTO0d4IwzfwmBz2hDgeBrooK2oqJREdK0Kjv44ZOlftvlUo1pLmX xkiFsZSz7WAfJg1g38I5t4bRzjnFwecAP8o2iQc0mmTEnkxwwS51T8QIze4gr7tkgZ9xbzbJYw/h6 ov/sKs2GHJiETxGR4ZooysOg3uuauvPbGxtzf2wPiy59qIdhIqFzHK8rquLkVqkDwbisGiNygu6Dm oyUjA3lkuELr7w==; From: Ludovic =?UTF-8?Q?Court=C3=A8s?= In-Reply-To: <67f49b23cfe3755c6802e2fc3351ef3cf0dcdfda.1715687434.git.andreas@enge.fr> (Andreas Enge's message of "Tue, 14 May 2024 13:50:34 +0200") References: <67f49b23cfe3755c6802e2fc3351ef3cf0dcdfda.1715687434.git.andreas@enge.fr> Date: Fri, 31 May 2024 14:01:36 +0200 Message-ID: <87mso6rxzz.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Spam-Score: -7.24 X-Migadu-Queue-Id: D79C76CE80 X-Migadu-Scanner: mx10.migadu.com X-Migadu-Spam-Score: -7.24 X-TUID: gyeN/a2b+QtR Hi, Andreas Enge skribis: > The rationale for these lines is that they enable non-privileged docker > containers. But I would like to create a privileged container with > chroot (in an openshift environment, where I suppose this environment > does additional encapsulation to enforce security), which these lines > prevent. > > Users can still add the option. Alternatively, we could add an additional > field "chroot? (default: #t)" to guix-configuration. [...] > - ((eq? guix-service-type (service-kind= s)) > - ;; Pass '--disable-chroot' so that > - ;; guix-daemon can build thing even = in > - ;; Docker without '--privileged'. This is tricky, I=E2=80=99m not sure how to provide defaults that works in = most common setups while still allowing the use of privileged Docker containers as in your case. I think the current default is good because it=E2=80=99s the common case, b= ut I agree that we need to find a way to override it. Thoughts? Ludo=E2=80=99.