unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: Andy Tai <atai@atai.org>
Cc: 71219-done@debbugs.gnu.org
Subject: bug#71219: [PATCH v5] gnu: llama-cpp: Update commit and configure flags for shared library build.
Date: Wed, 10 Jul 2024 15:47:36 +0200	[thread overview]
Message-ID: <87msmp7407.fsf@gnu.org> (raw)
In-Reply-To: <ab9b424e00a75d471fc4cfaadb71f765ef40d413.1718107292.git.atai@atai.org> (Andy Tai's message of "Tue, 11 Jun 2024 05:02:13 -0700")

[-- Attachment #1: Type: text/plain, Size: 546 bytes --]

Hi Andy,

Andy Tai <atai@atai.org> skribis:

> * gnu/packages/machine-learning.scm (lama-cpp): Update to commit a5735e with
>   pkg-config support.
>   [arguments](configure-flags): Add cmake configure flag
>   for shared library build and adjust arguments to make openblas
>   found by cmake.
>   (phases) 'install-python-scripts: Remove references to deleted scripts
>   and add new ones upsteeam.
>
> Change-Id: I7c4bc219a22aa9a949e811b340c7cf745b176d14

Applied with the indentation changes shown below.  Thanks!

Ludo’.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 1902 bytes --]

diff --git a/gnu/packages/machine-learning.scm b/gnu/packages/machine-learning.scm
index a2be0bf9c8..1cb6586e81 100644
--- a/gnu/packages/machine-learning.scm
+++ b/gnu/packages/machine-learning.scm
@@ -567,18 +567,22 @@ (define-public llama-cpp
       (arguments
        (list
         #:configure-flags
-        #~(list               "-DBUILD_SHARED_LIBS=ON"
-                              "-DLLAMA_BLAS=ON"
-                              "-DLLAMA_BLAS_VENDOR=OpenBLAS"
-                              (string-append "-DBLAS_INCLUDE_DIRS=" #$(this-package-input "openblas") "/include")
-                              (string-append "-DBLAS_LIBRARIES=" #$(this-package-input "openblas") "/lib/libopenblas.so")
+        #~(list "-DBUILD_SHARED_LIBS=ON"
+                "-DLLAMA_BLAS=ON"
+                "-DLLAMA_BLAS_VENDOR=OpenBLAS"
+                (string-append "-DBLAS_INCLUDE_DIRS="
+                               #$(this-package-input "openblas")
+                               "/include")
+                (string-append "-DBLAS_LIBRARIES="
+                               #$(this-package-input "openblas")
+                               "/lib/libopenblas.so")
 
-                              "-DLLAMA_NATIVE=OFF" ;no '-march=native'
-                              "-DLLAMA_FMA=OFF"    ;and no '-mfma', etc.
-                              "-DLLAMA_AVX2=OFF"
-                              "-DLLAMA_AVX512=OFF"
-                              "-DLLAMA_AVX512_VBMI=OFF"
-                              "-DLLAMA_AVX512_VNNI=OFF")
+                "-DLLAMA_NATIVE=OFF" ;no '-march=native'
+                "-DLLAMA_FMA=OFF"    ;and no '-mfma', etc.
+                "-DLLAMA_AVX2=OFF"
+                "-DLLAMA_AVX512=OFF"
+                "-DLLAMA_AVX512_VBMI=OFF"
+                "-DLLAMA_AVX512_VNNI=OFF")
 
         #:modules '((ice-9 textual-ports)
                     (guix build utils)

  reply	other threads:[~2024-07-10 13:48 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-27  5:16 [bug#71219] [PATCH] gnu: llama-cpp: Update configure flags for shared library build Andy Tai
2024-05-28  1:57 ` [bug#71219] [PATCH v2] " Andy Tai
2024-06-03 15:43 ` [bug#71219] [PATCH v3] gnu: llama-cpp: Update commit and update " Andy Tai
2024-06-06 17:52 ` [bug#71219] Andy Tai
2024-06-06 18:12   ` [bug#71219] Christopher Baines
2024-06-11 11:41 ` [bug#71219] [PATCH v4] gnu: llama-cpp: Update commit and update configure flags for shared library build Andy Tai
2024-06-11  7:30   ` Andy Tai
2024-06-11 12:02 ` [bug#71219] [PATCH v5] gnu: llama-cpp: Update commit and " Andy Tai
2024-07-10 13:47   ` Ludovic Courtès [this message]
2024-07-10 13:49   ` Ludovic Courtès
2024-07-10  4:00 ` [bug#71219] Andy Tai via Guix-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87msmp7407.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=71219-done@debbugs.gnu.org \
    --cc=atai@atai.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).