unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: Simon Tournier <zimon.toutoune@gmail.com>
Cc: ludo@gnu.org, 73034@debbugs.gnu.org, liliana.prikler@gmail.com
Subject: [bug#73034] [PATCH v3 0/3] Fix annoyances of Git and update to 2.46.0
Date: Fri, 06 Sep 2024 13:17:33 +0900	[thread overview]
Message-ID: <87msklct5u.fsf@gmail.com> (raw)
In-Reply-To: <cover.1725550253.git.zimon.toutoune@gmail.com> (Simon Tournier's message of "Thu, 5 Sep 2024 17:34:47 +0200")

Hi,

Simon Tournier <zimon.toutoune@gmail.com> writes:

> Hi,
>
> Since changes to the package Git imply large rebuilds, this series integrates
> submission #72413.
>
> Change since v2: Restore the ’origin’ of git-manpages under native-inputs.
>
> Commit f288604428e9c8f096ec9e0eccf207e079806271 moved the origin inside the phase.
>
> +          (add-after 'split 'install-man-pages
> +            (lambda _
> +              (let ((man (string-append #$output "/share/man")))
> +                (mkdir-p man)
> +                (with-directory-excursion man
> +                  (invoke
> +                   "tar" "xvf"
> +                   #$(origin
> +                       (method url-fetch)
> +                       (uri (string-append
> +                             "mirror://kernel.org/software/scm/git/"
> +                             "git-manpages-" version ".tar.xz"))
> +                       (sha256
> +                        (base32
> +                         "0xsqakgy0s60zpa13ilj6zj420kdh8pf4v3nrp1nziwj8ja4qymw"))))))))
>
> And this appears to me a bad idea, because 1. it makes harder to know what are
> the inputs and more importantly 2. it is hidden from procedure
> ’package-direct-sources’, which means it will not be archived.

I believe your argument 1. is going to affect any label-free package
definitions needing additional origins copied in, so the issue is bigger
than just this commit, in my opinion.

About 2; perhaps it'd be preferable to build the doc from source, if
that doesn't introduce cycles or too large of a native inputs graph.

-- 
Thanks,
Maxim




  parent reply	other threads:[~2024-09-06  4:20 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-05  1:55 [bug#73034] [PATCH] gnu: git: Fix perl search-paths of wrapped programs Simon Tournier
2024-09-05  2:37 ` [bug#73034] [PATCH v2] " Simon Tournier
2024-09-05 12:47 ` [bug#73034] [PATCH] " Ashish SHUKLA via Guix-patches via
2024-09-05 15:34 ` [bug#73034] [PATCH v3 0/3] Fix annoyances of Git and update to 2.46.0 Simon Tournier
2024-09-05 15:34   ` [bug#73034] [PATCH v3 1/3] gnu: git: Fix perl search-paths of wrapped programs Simon Tournier
2024-09-05 15:34   ` [bug#73034] [PATCH v3 2/3] gnu: git: Update to 2.46.0 Simon Tournier
2024-09-05 15:34   ` [bug#73034] [PATCH v3 3/3] gnu: git: Move git-manpages origin from phases to native-inputs Simon Tournier
2024-09-06  4:17   ` Maxim Cournoyer [this message]
2024-09-06 10:31     ` [bug#73034] [PATCH v3 0/3] Fix annoyances of Git and update to 2.46.0 Simon Tournier
2024-09-06 15:53       ` Simon Tournier
2024-09-08 12:10         ` bug#73034: " Maxim Cournoyer
2024-09-09 17:50           ` [bug#73034] " Simon Tournier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87msklct5u.fsf@gmail.com \
    --to=maxim.cournoyer@gmail.com \
    --cc=73034@debbugs.gnu.org \
    --cc=liliana.prikler@gmail.com \
    --cc=ludo@gnu.org \
    --cc=zimon.toutoune@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).