From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id iNbCOEKxAmfZhQAA62LTzQ:P1 (envelope-from ) for ; Sun, 06 Oct 2024 15:48:19 +0000 Received: from aspmx1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id iNbCOEKxAmfZhQAA62LTzQ (envelope-from ) for ; Sun, 06 Oct 2024 17:48:19 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=CMYsvdO3; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=BXEYE8UY; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1728229698; a=rsa-sha256; cv=none; b=JnJVkXtN3+IKWduVuUTGHFeX+FdkaKiRmdXKr/LGcaYCcIpHbzEEtawMbknacIXJwoI/uN zSYNpebABQ6awXAMl2iTbYx+hjfop7A5+zWeMgMEsFUjp/8fopPdBDMb9UwBycqF+IwER9 0ARjY7m7ExxYYL7Wp7G8ocrpBgxWpR7lKPtEcBuPtAHrL38W3F31WxZ7xv6l4cwaIOmAT8 ZMgI2Gi+AWJt3UDgr+MkoQTRxnVSNeL7yjWVEv0OieJ1Z0/LrH+sPcZkEUyy+iLvhuLvOY E2CxcJw42jGzURekL7vynP7VZuaGDanhviJXmpbtZ97zv8PhTN68K2XkqiBkAg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=CMYsvdO3; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=BXEYE8UY; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1728229698; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=PK2hsLEZ4eiUdePSOb8bLNTEUEhPFRtfrap7ghMxElY=; b=Ea+2MzEqOdpwVYBoMmjcaI4BfX1ol2l7PVyF6d7OfI1oaaOka2NJAyt0kpljZX7o0j1T+w Po2b+53dmtAgrwJgIdAZ2KXk9YuesxlELqH9c5kBTzzjxHBnrWNBvOr8cBV74Fr7DOJIfT /LJGZ+G/hJ0a5zCwITVxLE3vXFFIVS6Hcx2EilOqznoM6NXXEqZm7V/uJRBi+v/vwmEWfw UItpZWUZbwjzKwrbqjuI+S6i/lgtjvS8LiMXHvQbCMQLqZkxdW1TTaawHBpnL3HldtzxXV 5uPDjdFfCoRM0PiKMzvvJ7hLqBACVaAWiAA9idI/MewC7nhyh2amXkcU/h+RJg== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 702F91E60C for ; Sun, 06 Oct 2024 17:48:17 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sxTUF-0006Uv-Mn; Sun, 06 Oct 2024 11:47:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sxTUC-0006Ue-UD for guix-patches@gnu.org; Sun, 06 Oct 2024 11:47:57 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sxTUC-0002Se-4b for guix-patches@gnu.org; Sun, 06 Oct 2024 11:47:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=PK2hsLEZ4eiUdePSOb8bLNTEUEhPFRtfrap7ghMxElY=; b=CMYsvdO3t4P8J6DYO84O3jHIT99fQAV2MPvTuRV84ZPVLaEWx2KI6Kh3JBQHjstQ9zk+3gTD2Y9jtq2O4wTkyYiPdKcO9YZVdAGgDl1AbHuhlsVdKXDNw8rTKN2MDBtz48YtxNIStZl5aZ251eSLIcf8OBZ091KIjW3FXPGwUYCfyPop3+L3QckDfEbJkuv39wnAbNpSMBOB3GBfXgShVsnYoLIjH6pgPi+u2W2SA2lquOk4aNJzRrnZGulOJPS8w947FT8LjSHKrGzhOPOAq+8Q+lrhrmdvLwRKhSk61HPUexYjcB1yEuaUBEM/IrVkyy5PClWVa0cTtZZpCFZEiQ==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sxTUI-0000ZD-3y; Sun, 06 Oct 2024 11:48:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#72925] [PATCH v10] gnu: Add jpm. Resent-From: Suhail Singh Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org, "Suhail Singh" Resent-Date: Sun, 06 Oct 2024 15:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72925 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Omar Bassam Cc: 72925@debbugs.gnu.org, Suhail Singh Received: via spool by 72925-submit@debbugs.gnu.org id=B72925.17282296682155 (code B ref 72925); Sun, 06 Oct 2024 15:48:02 +0000 Received: (at 72925) by debbugs.gnu.org; 6 Oct 2024 15:47:48 +0000 Received: from localhost ([127.0.0.1]:42009 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sxTU3-0000Yg-T5 for submit@debbugs.gnu.org; Sun, 06 Oct 2024 11:47:48 -0400 Received: from mail-qv1-f68.google.com ([209.85.219.68]:57570) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sxTU1-0000YS-JZ for 72925@debbugs.gnu.org; Sun, 06 Oct 2024 11:47:46 -0400 Received: by mail-qv1-f68.google.com with SMTP id 6a1803df08f44-6cb35f2aec1so32676256d6.2 for <72925@debbugs.gnu.org>; Sun, 06 Oct 2024 08:47:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1728229593; x=1728834393; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=PK2hsLEZ4eiUdePSOb8bLNTEUEhPFRtfrap7ghMxElY=; b=BXEYE8UY1Rx+szDVrrLBLlO50axmUX3lPubLY6DYElcqu+/Qyza8M9LiKikBlXsPRV mnP9hEEyZWt3oqHd4fqZYMCji9BESjtOg7CwBTE1cTxdcbno7i2540i04HjMQq4+FMNr D8XVMyvhlHGc7QGsN3fwndyYxUS8ZkCY+p0GeYr9mc4g4SVA8ZgkGOAQp4gg2GTKd3bT W1ZOkIwpCsMdYlllb2bpLKZ/UBCUEYne/0ZJQohSkZBGtE7pHB51M5Y5J/cqPnwxwmsx FstoYkiGxKBNBRB/Awr6y+pcFLV+UfuuqKJ93smuJ+4lrtrpOIYHVjuxs5qBSWnZ0pIB LbTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728229593; x=1728834393; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=PK2hsLEZ4eiUdePSOb8bLNTEUEhPFRtfrap7ghMxElY=; b=pEanC2ZzKSR3Ib5lX2i00YkTEmqcqazfH7DRzIkYtvhSjO4dfle3EMlopumuAFjJrn 4s6wgWLe0erfvGxBj3B2zth7Zp8HB0BmCxZzyYrSa9uGP/SaXaiAoBp8KPAQyTVTciUc UD2nbdDF83WDEnm9tGb/V6GBMezmSxE/sopIAp2P+rkdAxOXjK2jfZp0rxDOxyWgAhCH ICQGioWDuh8YU+G3tk7PsQGIwkicYCeJCtRHpI2Ue/TZBtD33S9ZEIOx08VObe8RFDeJ cL5dYMvdFWPFc2HfraqmTwnpZjn9lK1dBx1LvcnmFk0GkFcCeFH7QMlRzu9gW8J7GhFi vVKw== X-Forwarded-Encrypted: i=1; AJvYcCWNsZHqkTyrlxLc5pIEsp+EHppmSFCqr5cmRqpnEyNFZYJ0DGH0j22Ay2Lz+qv4+O6uiqRigQ==@debbugs.gnu.org X-Gm-Message-State: AOJu0Yy3R04WnisYPAzfbdmMff66pd++5igAgk2I/wGUaNDLJyXoNHiy +WiudWkvCkShgdh1SJkm4Om/EUfnCOWaXH5wpBfusqrGF9cpXlyaxx6IvrSC X-Google-Smtp-Source: AGHT+IHoky1/g2kdsE27PhB6XERE+3JvNjvdbnznv2aXEoKmJ+cBMdDAUUPhellsN573f1wgywYrjQ== X-Received: by 2002:a05:6214:5882:b0:6cb:600f:568b with SMTP id 6a1803df08f44-6cb9a1ef82amr134793146d6.8.1728229593283; Sun, 06 Oct 2024 08:46:33 -0700 (PDT) Received: from gnus ([65.94.70.53]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6cba475ff59sm17602476d6.118.2024.10.06.08.46.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 06 Oct 2024 08:46:32 -0700 (PDT) From: Suhail Singh In-Reply-To: <87o73xgyf2.fsf@omar-Latitude-5540.mail-host-address-is-not-set> (Omar Bassam's message of "Sun, 06 Oct 2024 16:21:05 +0300") References: <6e198e7dc1f64bea3a2b1498fb69e597e4d03360.1728148557.git.suhail@bayesians.ca> <87o73xgyf2.fsf@omar-Latitude-5540.mail-host-address-is-not-set> Date: Sun, 06 Oct 2024 11:46:20 -0400 Message-ID: <87msjh5j5f.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -1.16 X-Spam-Score: -1.16 X-Migadu-Queue-Id: 702F91E60C X-Migadu-Scanner: mx10.migadu.com X-TUID: Q/d4dobL50dy Omar Bassam writes: >> + #:use-module (gnu packages certs) > > If we don't need nss-verts, do we still need this line? Good catch. We don't need this. Please remove in v11 when you send it. >> + (propagated-inputs (list janet >> + ;; Lazily resolve the gcc-toolchain to avoid a >> + ;; circular dependency. >> + (module-ref (resolve-interface '(gnu packages >> + commencement)) >> + 'gcc-toolchain))) > > Since we no longer need gcc-toolchain and we are just using gcc > directly, should we remove this module-ref expression and just add gcc > as a propagated input? What we need is _some_ mechanism to ensure that when jpm invokes gcc (or g++), the compiler is able to locate the appropriate header files. This should be doable without propagating any other inputs. For example by ensuring that jpm sets appropriate environment variables (such as $CPATH , $C_INCLUDE_PATH , $CPLUS_INCLUDE_PATH etc.) or flags when invoking the compiler. If so, that would be the preferred approach. We only want to propagate those inputs that are strictly necessary. I do know that when I had tried to remove gcc-toolchain (without doing anything else) I encountered some errors during "jpm install -l sh" (in a pure shell). However, I did not spend any effort in simplifying this, and I agree that we should try to. I look forward to seeing what you come up with in v11 :) >> + ;; NOTE: Below ensures that the user provides the CA certificates they >> + ;; desire (as opposed to bundling `nss-certs' in propagated-inputs, which >> + ;; isn't recommended) and when they do, that they are respected. > > Why isn't bundling nss-certs recommended? Doing so would deprive the user of the choice of which CAs to trust. I.e., if we were to bundle nss-certs we are taking an opinionated stance that the user agrees with Mozilla project's stance on these matters. >> + ;; FIXME: It's unclear why `search-paths', instead of >> + ;; `native-search-paths', doesn't work. > > What are the difference between search-paths and > native-search-paths. These are documented in the info manual. However, it's not clear to me _why_ native-search-paths is the right thing to use in this situation. I posted a message on guix-devel regarding this: . The FIXME was simply an attempt to get the attention of others more knowledgable than me. Use your discretion regd. whether to keep it or not. > And were you able to run the "jpm install" command without > nss-certs. Because, for me I was unable to do so. When I added back > the nss-certs in propagated-inputs, it worked fine. That is expected behaviour. The way to test it, when in a pure container, would be by explicitly ensuring that certificates of trusted CAs are included in the profile. On way to do so would by adding nss-certs alongside jpm when invoking the shell. Relying on the package to provide nss-certs isn't desirable. We simply want to ensure that when the certs are provided that the package _is able to use_ them. This is what the native-search-paths line accomplishes. -- Suhail