unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: Richard Sent <richard@freakingpenguin.com>
Cc: Josselin Poiret <dev@jpoiret.xyz>,
	Simon Tournier <zimon.toutoune@gmail.com>,
	Mathieu Othacehe <othacehe@gnu.org>,
	Tobias Geerinckx-Rice <me@tobias.gr>,
	74878@debbugs.gnu.org, Christopher Baines <guix@cbaines.net>
Subject: [bug#74878] [PATCH 2/2] scripts: substitute: Improve the help output.
Date: Mon, 23 Dec 2024 18:39:07 +0100	[thread overview]
Message-ID: <87msgm8fk4.fsf@gnu.org> (raw)
In-Reply-To: <abc5d45c178b0a00f778af8bc4847c34ed3c70fd.1734221404.git.richard@freakingpenguin.com> (Richard Sent's message of "Sat, 14 Dec 2024 19:26:47 -0500")

Hi,

Richard Sent <richard@freakingpenguin.com> skribis:

> Clarify that arguments are read from standard input and that --query expects a
> command.
>
> * guix/scripts/substitute.scm (show-help): Reword.
>
> Change-Id: Ifc197d5e10e43663f1e05039ce29086f6a21b943

[...]

>  (define (show-help)
>    (display (G_ "Usage: guix substitute OPTION [ARGUMENT]...
> -Internal tool to substitute a pre-built binary to a local build.\n"))
> +Internal tool to substitute a pre-built binary to a local build.
> +
> +ARGUMENT is read from standard input, not from the command line.\n"))

I find this sentence confusing since the usage line above shows that
it’s a command-line argument.  But since there’s no such argument, we
can just remove “[ARGUMENT]...” from the usage line.

>    (display (G_ "
> -      --query            report on the availability of substitutes for the
> -                         store file names passed on the standard input"))
> +      --query COMMAND STORE-FILE ...
> +                         Run query COMMAND with STORE-FILE to report on
> +                         the availability of substitutes"))

I think this also adds to the confusion since ‘--query’ doesn’t actually
take any arguments.

Note that the protocol ‘guix-daemon’ and ‘guix substitute’ is
purposefully undocumented: it’s an implementation detail and users are
not supposed to use ‘guix substitute’ directly.

Thoughts?

Ludo’.





      reply	other threads:[~2024-12-23 17:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-15  0:23 [bug#74878] [PATCH 0/2] Improve Guix Subsitute script usage Richard Sent
2024-12-15  0:26 ` [bug#74878] [PATCH 1/2] scripts: substitute: Report the number of substitutes being updated Richard Sent
2024-12-15  0:26 ` [bug#74878] [PATCH 2/2] scripts: substitute: Improve the help output Richard Sent
2024-12-23 17:39   ` Ludovic Courtès [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87msgm8fk4.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=74878@debbugs.gnu.org \
    --cc=dev@jpoiret.xyz \
    --cc=guix@cbaines.net \
    --cc=me@tobias.gr \
    --cc=othacehe@gnu.org \
    --cc=richard@freakingpenguin.com \
    --cc=zimon.toutoune@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).