From: ludo@gnu.org (Ludovic Courtès)
To: Tobias Geerinckx-Rice <me@tobias.gr>
Cc: 26489@debbugs.gnu.org
Subject: bug#26489: [PATCH] substitute: Ignore bad responses.
Date: Fri, 14 Apr 2017 11:54:32 +0200 [thread overview]
Message-ID: <87lgr3gvqf.fsf@gnu.org> (raw)
In-Reply-To: <20170414002755.32672-1-me@tobias.gr> (Tobias Geerinckx-Rice's message of "Fri, 14 Apr 2017 02:27:55 +0200")
Howdy!
Tobias Geerinckx-Rice <me@tobias.gr> skribis:
> * guix/scripts/substitute.scm (http-multiple-get): Catch BAD-RESPONSE
> exceptions and keep going.
> ---
>
> Guix,
>
> One weird HTTP response from a server will kill ‘guix substitute’:
>
> updating list of substitutes from 'https://foo'... 50.0%Backtrace:
> ...
> guix/ui.scm:1229:8: In procedure run-guix-command:
> guix/ui.scm:1229:8: Throw to key `bad-response' with args
> `("Bad Response-Line: ~s" (""))'.
> error: build failed: substituter `substitute' died unexpectedly
>
> Attached is a patch to ignore such bad responses. The offending .narinfo
> will be ignored for that session, and not cached at all. The result:
I’m sure you expect this question: what bad responses did you get in
practice? :-)
Usually that is a sign of a broken HTTP server. Of course it’s
widespread enough, we’d better handle it, either in Guix or directly in
(web client) in Guile; OTOH, if it’s a genuine problem, we’d better not
hide it.
Thanks,
Ludo’.
next prev parent reply other threads:[~2017-04-14 9:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-14 0:27 bug#26489: [PATCH] substitute: Ignore bad responses Tobias Geerinckx-Rice
2017-04-14 9:54 ` Ludovic Courtès [this message]
2017-04-28 20:56 ` Tobias Geerinckx-Rice
2017-05-01 13:14 ` Ludovic Courtès
2020-12-18 20:19 ` [bug#26489] " zimoun
2020-12-20 13:39 ` Ludovic Courtès
2021-01-11 13:08 ` zimoun
2021-01-15 19:52 ` Julien Lepiller
2021-02-09 1:05 ` zimoun
2021-02-09 8:42 ` bug#26489: " Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lgr3gvqf.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=26489@debbugs.gnu.org \
--cc=me@tobias.gr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).