unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Marius Bakke <mbakke@fastmail.com>
To: Julien Lepiller <julien@lepiller.eu>, 26522@debbugs.gnu.org
Subject: bug#26522: gnu: Add adb
Date: Mon, 17 Apr 2017 17:09:04 +0200	[thread overview]
Message-ID: <87lgqzkr5b.fsf@fastmail.com> (raw)
In-Reply-To: <20170417104022.3947db41@lepiller.eu>

[-- Attachment #1: Type: text/plain, Size: 1294 bytes --]

Julien Lepiller <julien@lepiller.eu> writes:

> Le Sun, 16 Apr 2017 23:54:47 +0200,
> Marius Bakke <mbakke@fastmail.com> a écrit :
>
>> Julien Lepiller <julien@lepiller.eu> writes:
>> 
>> > Hi Marius,
>> >
>> > thanks for the quick review. This should fix your comments.
>> 
>> Great! One thing I overlooked last time was the patches. It would be
>> good to include the origin in URL form, so we can dig them out later.
>> 
>> The arch patch shouldn't be too hard to find (but URL would be
>> convenient!), I'm curious where the other patch comes from.
>> 
>> Patches tend to evolve over time, so checking what happened "upstream"
>> can be handy when you're stumped. See e.g. any CVE patch for
>> examples :)
>> 
>> Other than that looks good!
>
> Here is an updated patch with a link to archlinux' patch. You were the
> one to add the other patch, and I can't find it. I'm also curious where
> it comes from :p

Hehe...I deliberately did not add a reference just to prove this point!

...but I remember now, it is this commit, which I don't think will hit a
release until Android 8 if I've understood their branching correctly:

https://android.googlesource.com/platform/system/core/+/e5dd71a290f664d3f3bf0dd8a4bad411dc7ad416

Please add it and push! :D


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

  reply	other threads:[~2017-04-17 15:10 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-15 16:31 bug#26522: gnu: Add adb Julien Lepiller
2017-04-15 18:02 ` Marius Bakke
2017-04-16  9:22   ` Julien Lepiller
2017-04-16 21:54     ` Marius Bakke
2017-04-17  8:40       ` Julien Lepiller
2017-04-17 15:09         ` Marius Bakke [this message]
2017-04-18  8:21           ` Ludovic Courtès
2017-04-20  8:33 ` bug#26522: julien lepiller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lgqzkr5b.fsf@fastmail.com \
    --to=mbakke@fastmail.com \
    --cc=26522@debbugs.gnu.org \
    --cc=julien@lepiller.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).