unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Kei Kebreau <kei@openmailbox.org>
To: Leo Famulari <leo@famulari.name>
Cc: 26713@debbugs.gnu.org
Subject: bug#26713: [PATCH] gnu: Move netsurf to web-browsers.scm.
Date: Sat, 06 May 2017 10:51:26 -0400	[thread overview]
Message-ID: <87lgqaghsh.fsf@openmailbox.org> (raw)
In-Reply-To: <87o9vdo805.fsf@openmailbox.org> (Kei Kebreau's message of "Sun, 30 Apr 2017 18:17:30 -0400")

[-- Attachment #1: Type: text/plain, Size: 1139 bytes --]

Kei Kebreau <kei@openmailbox.org> writes:

> Kei Kebreau <kei@openmailbox.org> writes:
>
>> Leo Famulari <leo@famulari.name> writes:
>>
>>> On Sat, Apr 29, 2017 at 06:09:42PM -0400, Kei Kebreau wrote:
>>>> * gnu/packages/web.scm: Move netsurf...
>>>> * gnu/packages/web-browsers.scm: ...here.
>>>
>>> This caused building Guix to fail because the glib-or-gtk build-system
>>> module was not imported in (gnu packages web-browsers).
>>>
>>
>> Oh no! :(
>>
>>> I planned to add that module in a followup commit, but I realized that
>>> several other variables from (gnu packages web) need to be imported in
>>> (gnu packages web-browsers) along with this change, and I decided to
>>> revert the change for now.
>>>
>>> Can you take another look at moving this package?
>>
>> Will do. I'll have to adjust the qutebrowser patch for corrections to
>> this one.
>
> Try the attached patch. I'm not sure that copying the definition of
> netsurf-buildsystem is the best way to handle the move, but I'm not sure
> this is worth making netsurf-buildsystem a publicly-defined package.
>
> Thoughts?

If you have no objections, I'd like to push this.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

  reply	other threads:[~2017-05-06 14:53 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-29 22:09 bug#26713: [PATCH] gnu: Move netsurf to web-browsers.scm Kei Kebreau
2017-04-30 15:31 ` Christopher Allan Webber
2017-04-30 18:12   ` Kei Kebreau
2017-04-30 19:13 ` Leo Famulari
2017-04-30 19:57   ` Kei Kebreau
2017-04-30 22:17     ` Kei Kebreau
2017-05-06 14:51       ` Kei Kebreau [this message]
2017-05-06 15:24         ` Marius Bakke
2017-05-06 16:34           ` Kei Kebreau
2017-05-06 17:38             ` Marius Bakke
2017-05-08 15:17               ` Kei Kebreau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lgqaghsh.fsf@openmailbox.org \
    --to=kei@openmailbox.org \
    --cc=26713@debbugs.gnu.org \
    --cc=leo@famulari.name \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).