From: ludo@gnu.org (Ludovic Courtès)
To: julien lepiller <julien@lepiller.eu>
Cc: 26829@debbugs.gnu.org
Subject: bug#26829: Add knot service
Date: Mon, 29 May 2017 18:36:17 +0200 [thread overview]
Message-ID: <87lgpf7h8e.fsf@gnu.org> (raw)
In-Reply-To: <92fb9449ec88661f0fb9d43664792ffa@lepiller.eu> (julien lepiller's message of "Mon, 29 May 2017 09:55:18 +0200")
Hello,
julien lepiller <julien@lepiller.eu> skribis:
> Le 2017-05-28 19:34, ludo@gnu.org a écrit :
>> Hi Julien,
>>
>> Julien Lepiller <julien@lepiller.eu> skribis:
>>
>>> So, pushed as ba69e8f7ce21a81bdd5b99fdb1cc64492443e15c.
>>
>> Very nice and very useful notably for self-hosting use cases!
> That's exactly why I did that :). I'm currently self-hosting my
> services on debian, and I would like to move to guixSD at some point,
> so I'm writing services I need.
Excellent. :-)
>> I have two minor comments:
>>
>> 1. What it would it take to write tests for this? I assume we could
>> simply make DNS requests locally?
> I have never written a system test, so I don't know how it works. If
> we check only that requests are answered correctly locally, I think
> that would be great but limited to the "master" scenario. Then there
> is the "slave" scenario, where we would need a zone transfer between
> two hosts. And we could also check that transfer occurs only to
> authorized slaves.
OK. I guess I know too little about DNS to make any useful comment.
>> 2. For things like:
>>
>> +@item @code{nsec3-salt-lifetime} (default: @code{"30d"})
>>
>> I prefer using an integer denoting the number of seconds, and then
>> letting users do the multiplication or use (string->duration
>> "30d").
>> I did that for ‘guix-publish-service’.
> I didn't know it existed, but it looks nicer indeed. I'll see what I
> can do.
OK! Note that I’m not saying that the service code should use
‘string->duration’ directly, but rather that the service code should use
integers to represent duration (in seconds).
Thank you,
Ludo’.
next prev parent reply other threads:[~2017-05-29 16:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-08 15:22 bug#26829: Add knot service Julien Lepiller
2017-05-08 18:25 ` Tobias Geerinckx-Rice
2017-05-08 18:27 ` Tobias Geerinckx-Rice
2017-05-22 7:57 ` julien lepiller
2017-05-27 8:41 ` Julien Lepiller
2017-05-28 17:34 ` Ludovic Courtès
2017-05-29 7:55 ` julien lepiller
2017-05-29 16:36 ` Ludovic Courtès [this message]
2017-05-31 19:41 ` Julien Lepiller
2017-05-31 21:17 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lgpf7h8e.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=26829@debbugs.gnu.org \
--cc=julien@lepiller.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).