unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: Kei Kebreau <kkebreau@posteo.net>
Cc: 28164@debbugs.gnu.org
Subject: [bug#28164] gnu: red-eclipse: Add store "data" package path as default
Date: Tue, 10 Oct 2017 09:20:25 +0200	[thread overview]
Message-ID: <87lgkjpiyu.fsf@gnu.org> (raw)
In-Reply-To: <87mv50b7q5.fsf@posteo.net> (Kei Kebreau's message of "Mon, 09 Oct 2017 12:34:42 -0400")

Kei Kebreau <kkebreau@posteo.net> skribis:

> From 59e71c1f353fc895318612e7cffe890e1caac029 Mon Sep 17 00:00:00 2001
> From: Adonay Felipe Nogueira <adfeno@hyperbola.info>
> Date: Sun, 20 Aug 2017 15:28:20 -0300
> Subject: [PATCH] gnu: red-eclipse: Add store "data" package path as default.
>
> * gnu/packages/games.scm (red-eclipse): Remove extra spaces. Make version
> respect documentation.
> [arguments]: Add "prefix" to make-flags. Add
> "add-store-data-package-path-as-default" phase. Improve "copy-data" phase.
>
> Signed-off-by: Kei Kebreau <kkebreau@posteo.net>

At first sight, it LGTM.  I think you can go ahead.

Thank you Adonay & Kei!

Ludo’.

  parent reply	other threads:[~2017-10-10  7:21 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-20 18:28 [bug#28164] gnu: red-eclipse: Add store "data" package path as default Adonay Felipe Nogueira
2017-09-23 15:30 ` Kei Kebreau
2017-10-07 20:49   ` Ludovic Courtès
2017-10-09 16:34     ` Kei Kebreau
2017-10-09 16:58       ` Adonay Felipe Nogueira
2017-10-10  7:20       ` Ludovic Courtès [this message]
2017-10-10 12:27         ` bug#28164: " Kei Kebreau
2017-10-12 13:33         ` [bug#28164] " Adonay Felipe Nogueira

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lgkjpiyu.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=28164@debbugs.gnu.org \
    --cc=kkebreau@posteo.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).