From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34654)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1e2gs5-0002ht-Qg
	for guix-patches@gnu.org; Thu, 12 Oct 2017 13:02:13 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1e2grz-0004Ld-UJ
	for guix-patches@gnu.org; Thu, 12 Oct 2017 13:02:09 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:55843)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1e2grz-0004LR-Qx
	for guix-patches@gnu.org; Thu, 12 Oct 2017 13:02:03 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1e2gry-0004ne-EW
	for guix-patches@gnu.org; Thu, 12 Oct 2017 13:02:03 -0400
Subject: [bug#27344] [PATCH v3 6/8] gnu: Add freehdl.
Resent-Message-ID: <handler.27344.B27344.150782769018401@debbugs.gnu.org>
References: <87lglnery8.fsf@foradis.org>
	<20170909175752.8566-1-theodoros@foradis.org>
	<20170909175752.8566-6-theodoros@foradis.org> <87sheqcd0w.fsf@gnu.org>
From: Theodoros Foradis <theodoros@foradis.org>
Message-ID: <87lgkggv59.fsf@openmailbox.org>
In-reply-to: <87sheqcd0w.fsf@gnu.org>
Date: Thu, 12 Oct 2017 20:00:57 +0300
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
Cc: 27344@debbugs.gnu.org


Ludovic Courtès writes:

> Theodoros Foradis <theodoros@foradis.org> skribis:
>
>> * gnu/packages/engineering.scm (freehdl): New variable.
>
> I’ve applied the patch.  \o/
>
> I have one question for which I couldn’t find an answer in the previous
> discussions:
>
>> +         (add-after 'configure 'patch-freehdl-pc
>> +           (lambda* (#:key inputs #:allow-other-keys)
>> +             (substitute* "freehdl.pc"
>> +               (("=g\\+\\+")
>> +                (string-append "=" (assoc-ref inputs "gcc")
>> +                               "/bin/g++"))
>> +               (("=libtool")
>> +                (string-append "=" (assoc-ref inputs "libtool")
>> +                               "/bin/libtool")))
>> +             #t))
>
> The effect of this is to retain a reference to GCC, Libtool, and all
> their dependencies, which makes the closure of FreeHDL much bigger.
>
> We could avoid it by just putting this in ‘freehdl.pc’:
>
>   cxx=g++
>   libtool=libtool
>
> Now, whether this will work depends on whether/how users of ‘freehdl.pc’
> use these variables.
>
> Could you check whether that would work?

Yes, I have tested this and it should work. Freehdl is a VHDL to C
compiler, so the user should be responsible for having a gcc toolchain
in his environment to run the simulations.

Now, in regard to the qucs and qucs-s packages, for the VHDL simulation
to work, libtool should be propagated (?) as well, but I'll reply to
that patch separately.

We can remove this phase (patch-freehdl-pc) altogether. Shall I submit
this patch?

-- 
Theodoros Foradis