From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46328) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eOQdh-0004dR-N1 for guix-patches@gnu.org; Mon, 11 Dec 2017 11:09:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eOQdc-0007Tq-1b for guix-patches@gnu.org; Mon, 11 Dec 2017 11:09:09 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:48385) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eOQdb-0007TR-UG for guix-patches@gnu.org; Mon, 11 Dec 2017 11:09:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eOQdb-00037G-PM for guix-patches@gnu.org; Mon, 11 Dec 2017 11:09:03 -0500 Subject: bug#29646: [PATCH] skalibs reproducible issue (reopen) Resent-To: guix-patches@gnu.org Resent-Message-ID: From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) References: <20171210154045.GB30811@air> Date: Mon, 11 Dec 2017 17:08:35 +0100 In-Reply-To: <20171210154045.GB30811@air> (Z. Ren's message of "Sun, 10 Dec 2017 23:42:30 +0800") Message-ID: <87lgi9xn5o.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: "Z. Ren" Cc: 29646-done@debbugs.gnu.org Hello, "Z. Ren" skribis: > Previously, we submitted a patch that intended to fix the unreproducible = issue of the package skalibs (#28017). Unfortunately, the patch we submitte= d only partially fixed the issues, i.e,. for the .a file (lib/skalibs/libsk= arnet.a). However, the .so file (lib/libskarnet.so) is still non-determinis= tic. > > After investigation, we find that in the Makefile, 'sort' should be appli= ed associated with 'wildcard', rather than with only ALL_SRCS.=20 > > To validate the fix, we applied "guix build --check --no-grafts --rounds= =3D2 skalibs" with the patched skarnet.scm, over three PCs (with guix 316fd= 29f9b6b0941367f54f431ef99695b16a9e5), and checked the sha256sum of the buil= t files. Under our testing setup, the attached patch fixes the issues for t= he .a/.so files for skalibs. Hope the patch is correct this time, and sorry= that the previous submitted patch failed to resolve all the unreproducible= issues. I confirm that it builds reproducibly on my laptop with --rounds=3D2 (a weaker test that what you did!). > From 36e35a72942a561028f93e6905cab7729a0d1f12 Mon Sep 17 00:00:00 2001 > From: Z. Ren > Date: Sun, 10 Dec 2017 22:23:32 +0800 > Subject: [PATCH] fix the unreproducible issue for skalibs > > --- > gnu/packages/skarnet.scm | 4 ++-- I adjusted the commit log and committed. Thank you! Ludo=E2=80=99.