From: Marius Bakke <mbakke@fastmail.com>
To: Tobias Geerinckx-Rice <me@tobias.gr>, 30748@debbugs.gnu.org
Subject: [bug#30748] [PATCH] gnu: Add nsd.
Date: Sat, 10 Mar 2018 10:18:00 +0100 [thread overview]
Message-ID: <87lgf0jnlj.fsf@fastmail.com> (raw)
In-Reply-To: <20180308082050.9855-1-me@tobias.gr>
[-- Attachment #1: Type: text/plain, Size: 756 bytes --]
Tobias Geerinckx-Rice <me@tobias.gr> writes:
> * gnu/packages/dns.scm (nsd): New public variable.
[...]
> + (add-before 'configure 'patch-installation-paths
> + (lambda* (#:key outputs #:allow-other-keys)
> + (let* ((out (assoc-ref outputs "out"))
> + (doc (string-append out "/share/doc/" ,name "-" ,version)))
> + (substitute* "Makefile.in"
> + (((string-append ".*\\$\\(DESTDIR\\)\\$\\("
> + "(config|pid|xfr|db)dir"
> + "\\).*"))
> + "")
Can you add a comment about what's going on here? Would setting
DESTDIR=(assoc-ref %outputs "out") in #:make-flags suffice?
Apart from that LGTM.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]
next prev parent reply other threads:[~2018-03-10 9:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-08 8:20 [bug#30748] [PATCH] gnu: Add nsd Tobias Geerinckx-Rice
2018-03-10 9:18 ` Marius Bakke [this message]
2018-03-12 21:03 ` Danny Milosavljevic
2018-03-12 21:35 ` Tobias Geerinckx-Rice
2018-03-13 2:06 ` Tobias Geerinckx-Rice
2018-10-04 19:38 ` bug#30748: " Tobias Geerinckx-Rice
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lgf0jnlj.fsf@fastmail.com \
--to=mbakke@fastmail.com \
--cc=30748@debbugs.gnu.org \
--cc=me@tobias.gr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).