From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51314) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ewOcI-0000vA-MG for guix-patches@gnu.org; Thu, 15 Mar 2018 04:52:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ewOcE-0001xl-Dl for guix-patches@gnu.org; Thu, 15 Mar 2018 04:52:06 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:54352) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ewOcE-0001xf-A5 for guix-patches@gnu.org; Thu, 15 Mar 2018 04:52:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ewOcE-0008Eq-44 for guix-patches@gnu.org; Thu, 15 Mar 2018 04:52:02 -0400 Subject: [bug#30797] [PATCH 1/2] gnu: Add emacs-exec-path-from-shell Resent-Message-ID: From: Oleg Pykhalov References: Date: Thu, 15 Mar 2018 11:50:53 +0300 In-Reply-To: (Konrad Hinsen's message of "Tue, 13 Mar 2018 16:47:01 +0100") Message-ID: <87lgetu3gy.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Konrad Hinsen Cc: 30797@debbugs.gnu.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hello Konrad, Konrad Hinsen writes: > * gnu/packages/emacs.scm (emacs-exec-path-from-shell): New variable. > --- > gnu/packages/emacs.scm | 28 ++++++++++++++++++++++++++++ > 1 file changed, 28 insertions(+) > > diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm > index c2c162c75..9c9c399fd 100644 > --- a/gnu/packages/emacs.scm > +++ b/gnu/packages/emacs.scm > @@ -7361,3 +7361,31 @@ highlighting and indentation support.") > @uref{https://www.terraform.io/, Terraform} configuration files. Most o= f the > functionality is inherited from @code{hcl-mode}.") > (license license:gpl3+))) > + > +(define-public emacs-exec-path-from-shell > + (package > + (name "emacs-exec-path-from-shell") > + (version "1.11") > + (source > + (origin > + (method url-fetch) > + (uri (string-append > + "http://stable.melpa.org/packages/exec-path-from-shell-" > + version > + ".el")) Same as in https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D30798#8 Unfortunately, we can't use sources from MELPA. The problem is: when a repository get a new commit, the old tarball is *REPLACED* with the new one on MELPA, so the package could never be built anymore, since the source disappeared. That's why we use tarballs directly from source. BTW, to make a recipe more polished you could remove unnecessary new lines, for example: (uri (string-append "http://stable.melpa.org/packages/deft-" version ".el")) > + (sha256 > + (base32 > + "03qjgb81cq1l3j54lvlf98r75vmmgd06mj6qh5wa6mz4xzp4w26r")))) > + (build-system emacs-build-system) > + (home-page > + "https://github.com/purcell/exec-path-from-shell") > + (synopsis=20 > + "Get environment variables such as $PATH from the shell") Likewise (new line). > + (description > + "This library allows the user to set Emacs' @code{exec-path} and @c= ode{$PATH} ^ unnecessary apostrophe? Also this line is too long (more than 80 symbols). > +from the shell path, so that @code{shell-command}, @code{compile} and the > +like work as expected on systems on which Emacs is not guaranteed > +to inherit a login shell's environment variables. It also allows other > +environment variables to be retrieved from the shell, so that Emacs will > +see the same values you get in a terminal.") > + (license license:gpl3+))) Otherwise LGTM. Thanks, Oleg. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEc+OyAXw1EaDPCmAPckbhHGm3lWkFAlqqM+0ACgkQckbhHGm3 lWmGSw//V9lbD5R7v2cGndwbQYH9QhBMNCKuH1WcVGP0Okvz/rSFf63osfbkOMBM 9Zv9BIwXCzLBxsEBJrJf5PcSalfiy0Ivr9SBR3gGCmrNshsxDbbH+YUSmoBzzgW+ GOrZJEkhpMjTUT2ieI13KnObxWCGJ2qg9gNwWt+fNaeKZdH0eGtZRYj4knm2fQ20 K7iI9vn8StPZJuFUjB05gAgKKhPE70E4mdkBVrmuwX3YeNz7WUCzz9YTO3gJW204 VmVQkqKtoTqOMupqHq3VYd5BszLBb5qTx8OKBicjkrQtbtuZD14hhGTi4tkcYoXb sJ5EqWmyQb7eXw/gVO8cslE3EQb0C8uOgVfcXZT5wZBa8pJhdVQ6W8bZCb4o8HyF PdLxLyHB+m6i7HPXYAPtRvoZKeiuFl22Xrxhr6WLucnUXcuYeKBaSmQahQh2sedc P1Tzbtg2FBjWDo6wakevqRM/WkdRaMfsDzDIZEeckwVhw1rx59xzSffyfEh4ia6g jhR89/+6l2Z+zmNcvdAtbKqdRq+1eQ422xpJwmHcjG9021aYWd5gNtacui8QTdbX +OoZxmpAmtOVjqhLs5+9YgYvD6UFDpsCZRW0jMyo58U/a01h+B1FgUWFLmRfuq1Z JjGoj6E7ZSszr/UBylHaqfjIgvHK6Br9qnQSedhHbVISQMzG5sQ= =T4ge -----END PGP SIGNATURE----- --=-=-=--