From: Oleg Pykhalov <go.wigust@gmail.com>
To: Konrad Hinsen <konrad.hinsen@fastmail.net>
Cc: 30797@debbugs.gnu.org
Subject: [bug#30797] [PATCH 1/2] gnu: Add emacs-exec-path-from-shell
Date: Thu, 15 Mar 2018 11:50:53 +0300 [thread overview]
Message-ID: <87lgetu3gy.fsf@gmail.com> (raw)
In-Reply-To: <m1zi3c9dsi.fsf@fastmail.net> (Konrad Hinsen's message of "Tue, 13 Mar 2018 16:47:01 +0100")
[-- Attachment #1: Type: text/plain, Size: 2653 bytes --]
Hello Konrad,
Konrad Hinsen <konrad.hinsen@fastmail.net> writes:
> * gnu/packages/emacs.scm (emacs-exec-path-from-shell): New variable.
> ---
> gnu/packages/emacs.scm | 28 ++++++++++++++++++++++++++++
> 1 file changed, 28 insertions(+)
>
> diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
> index c2c162c75..9c9c399fd 100644
> --- a/gnu/packages/emacs.scm
> +++ b/gnu/packages/emacs.scm
> @@ -7361,3 +7361,31 @@ highlighting and indentation support.")
> @uref{https://www.terraform.io/, Terraform} configuration files. Most of the
> functionality is inherited from @code{hcl-mode}.")
> (license license:gpl3+)))
> +
> +(define-public emacs-exec-path-from-shell
> + (package
> + (name "emacs-exec-path-from-shell")
> + (version "1.11")
> + (source
> + (origin
> + (method url-fetch)
> + (uri (string-append
> + "http://stable.melpa.org/packages/exec-path-from-shell-"
> + version
> + ".el"))
Same as in https://debbugs.gnu.org/cgi/bugreport.cgi?bug=30798#8
Unfortunately, we can't use sources from MELPA. The problem is:
when a repository get a new commit, the old tarball is *REPLACED*
with the new one on MELPA, so the package could never be built
anymore, since the source disappeared. That's why we use tarballs
directly from source.
BTW, to make a recipe more polished you could remove unnecessary new
lines, for example:
(uri (string-append "http://stable.melpa.org/packages/deft-"
version ".el"))
> + (sha256
> + (base32
> + "03qjgb81cq1l3j54lvlf98r75vmmgd06mj6qh5wa6mz4xzp4w26r"))))
> + (build-system emacs-build-system)
> + (home-page
> + "https://github.com/purcell/exec-path-from-shell")
> + (synopsis
> + "Get environment variables such as $PATH from the shell")
Likewise (new line).
> + (description
> + "This library allows the user to set Emacs' @code{exec-path} and @code{$PATH}
^
unnecessary apostrophe?
Also this line is too long (more than 80 symbols).
> +from the shell path, so that @code{shell-command}, @code{compile} and the
> +like work as expected on systems on which Emacs is not guaranteed
> +to inherit a login shell's environment variables. It also allows other
> +environment variables to be retrieved from the shell, so that Emacs will
> +see the same values you get in a terminal.")
> + (license license:gpl3+)))
Otherwise LGTM.
Thanks,
Oleg.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
next prev parent reply other threads:[~2018-03-15 8:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-13 15:47 [bug#30797] [PATCH 1/2] gnu: Add emacs-exec-path-from-shell Konrad Hinsen
2018-03-15 8:50 ` Oleg Pykhalov [this message]
2018-03-16 12:11 ` Konrad Hinsen
2018-03-16 14:13 ` bug#30797: " Oleg Pykhalov
2018-03-16 14:42 ` [bug#30797] " Konrad Hinsen
2018-03-16 15:05 ` Clément Lassieur
2018-03-16 15:28 ` Konrad Hinsen
2018-03-16 16:16 ` Oleg Pykhalov
2018-03-16 16:16 ` Oleg Pykhalov
2018-03-17 11:46 ` Andreas Enge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lgetu3gy.fsf@gmail.com \
--to=go.wigust@gmail.com \
--cc=30797@debbugs.gnu.org \
--cc=konrad.hinsen@fastmail.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).