Updated patch attached, addressing most of the issues raised, comments in-line below. On 2018-05-17, Vagrant Cascadian wrote: > On 2018-05-17, Mark H Weaver wrote: >> ludo@gnu.org (Ludovic Courtès) writes: >> %linux-compatible-systems is also used as the 'supported-systems' field >> of linux-libre-4.14, but there's no '4.14-arm64.conf' file added here. >> We should either add that file, or else somehow arrange for >> 'aarch64-linux' to be omitted from linux-libre-4.14's >> 'supported-systems' field. I adjusted linux-libre-4.14 to only support the previous set of architectures. >> As Ludovic mentioned, the new .conf file needs to be added to >> gnu/local.mk. > > I don't see any of the existing linux-libre/*.conf files added there; > maybe Ludovic meant Makefile.am ? Added to AUX_FILES in Makefile.am. >> Otherwise, it looks good to me. > > Since submitting, I did notice that the way .dtb files are installed, it > doesn't preserve the subdirectory structure. Unlike the "arm" > architecture, where .dtb files are all placed in a single directory, on > "arm64" there are sub-directories for each soc family: > > allwinner/sun50i-a64-pine64-plus.dtb > > It looks like the linux Makefile supports setting INSTALL_DTBS_PATH > variable, and both "arm" and "arm64" architectures have a "dtbs_install" > target, which may simply do "the right thing". Haven't looked into this yet. Platforms using UEFI/EFI may not use the .dtb files anyways, so perhaps it is worth merging this as is, and fixing up the .dtb locations in a later patch. Thanks for the review! live well, vagrant