From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39354) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fmNjD-00058c-W9 for guix-patches@gnu.org; Sun, 05 Aug 2018 14:26:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fmNj8-0002L3-U9 for guix-patches@gnu.org; Sun, 05 Aug 2018 14:26:07 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:37040) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fmNj8-0002Jw-KU for guix-patches@gnu.org; Sun, 05 Aug 2018 14:26:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fmNj8-0001mT-9b for guix-patches@gnu.org; Sun, 05 Aug 2018 14:26:02 -0400 Subject: [bug#28004] Chromium Resent-Message-ID: From: Marius Bakke In-Reply-To: <20180805161802.bif4ax5feqloxayz@abyayala> References: <87vaejvclc.fsf@fastmail.com> <20180226200133.zsnahblbgzovrtmu@abyayala> <87muzvv7ku.fsf@fastmail.com> <20180226234144.032af030@alma-ubu> <87woyxt3nz.fsf@fastmail.com> <20180316173044.dctlydfij7smndxd@abyayala> <87h8pfc3tr.fsf@fastmail.com> <20180316175225.7jf4k2qaciyxnepp@abyayala> <20180725080800.stqijlny6om6powe@abyayala> <87tvo9c6cs.fsf@fastmail.com> <20180805161802.bif4ax5feqloxayz@abyayala> Date: Sun, 05 Aug 2018 20:25:33 +0200 Message-ID: <87lg9kd61u.fsf@fastmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: ng0 Cc: 28004@debbugs.gnu.org --=-=-= Content-Type: text/plain ng0 writes: > Once we merge this into master, can we document the update procedure? > Or even better, write an update script if possible? For me it was 40% > hit everything which doesn't move and take what's left over and 60% > reading. I understand the code, but some people might want an > explanation for how it's decided which folder gets to stay. The "preserved-club" are simply third_party directories that are necessary for the build. Removing any single one will cause the build to fail (in theory, there might be outdated entries..). It's difficult to automate because you don't know what's needed until the build process starts and fails because of some missing dependency. > Not related to this section, but: NixOS has a "sandbox" output for Chromium > which "contains the sandboxed wrapper" of Chromium. Maybe it requires something > Nix/NixOS specific, maybe we can add that. I guess that's for the SUID sandbox binary. I haven't had a reason to build that because the user namespace sandbox works just fine. Perhaps it's useful for distributions that don't have user namespaces enabled? >> + ;; TODO: Install icons from "../../chrome/app/themes" into >> + ;; "out/share/icons/hicolor/$size". > > I have more icons here in my definition, the whole section looked like... > >> + (install-file >> + "product_logo_48.png" >> + (string-append out "/share/icons/48x48/chromium.png")) > > this: > > + ;; XXX: What about ../../chrome/app/theme/chromium/linux/? > + (for-each > + (lambda (file) > + (let* ((size (string-filter char-numeric? file)) > + (icons (string-append out "/share/icons/hicolor/" > + size "x" size "/apps"))) > + (mkdir-p icons) > + (copy-file file (string-append icons "/chromium.png")))) > + '("../../chrome/app/theme/chromium/product_logo_128.png" > + "../../chrome/app/theme/chromium/product_logo_22.png" > + "../../chrome/app/theme/chromium/product_logo_22_mono.png" > + "../../chrome/app/theme/chromium/product_logo_24.png" > + "../../chrome/app/theme/chromium/product_logo_256.png" > + "../../chrome/app/theme/chromium/product_logo_48.png" > + "../../chrome/app/theme/chromium/product_logo_64.png")) Nice. Now the next step is to generate the latter list, maybe with find-files? Thanks for the feedback! --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAltnQR0ACgkQoqBt8qM6 VPp9YwgAkNFCcTpNOmo0VwqqSUCSYVTZ8e+v0EaWXgWNkOGvvh4d6nA+IUnEin2F W23JgtrtiFcHvj6hr6U4XiBkK4yumyv6WGCv1xRAXHAwB6mGUhRyQfr3n59tVHDD IlAQpNgH0JJ0NxCv/ORieJmsW+/SexBui19aEVxPXiS1Z7sUfBVljzKtpZ3NVDbR XXOpqiesekw88S2oS/Rh5gSlTHUkw2fEgJw9xYIB89FGL5asEGladg42mbmRQblI Cb3SdqhXr0WsPfmonSgfCTWizLfgBIgTYAHNXwPjUOdeRGfciUbkQtO/AGvdwRhQ v6ajiaK3FJcIPx94k2QBXez3KXUaOA== =6bjy -----END PGP SIGNATURE----- --=-=-=--