From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57020)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gLYGh-0000VW-Nf
	for guix-patches@gnu.org; Sat, 10 Nov 2018 13:46:05 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gLYGg-00009j-C4
	for guix-patches@gnu.org; Sat, 10 Nov 2018 13:46:03 -0500
Received: from debbugs.gnu.org ([208.118.235.43]:40698)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1gLYGg-00008L-5g
	for guix-patches@gnu.org; Sat, 10 Nov 2018 13:46:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gLYGg-0000Es-22
	for guix-patches@gnu.org; Sat, 10 Nov 2018 13:46:02 -0500
Subject: [bug#33080] [PATCH] gnu: Add inferno.
Resent-Message-ID: <handler.33080.B33080.1541875559908@debbugs.gnu.org>
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
References: <87bm7sjmfc.fsf@GlaDOS.home>
Date: Sat, 10 Nov 2018 19:05:32 +0100
In-Reply-To: <87bm7sjmfc.fsf@GlaDOS.home> (Diego Nicola Barbato's message of
	"Wed, 17 Oct 2018 23:25:11 +0200")
Message-ID: <87lg60yfir.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Diego Nicola Barbato <dnbarbato@posteo.de>
Cc: 33080@debbugs.gnu.org

Hi Diego,

Sorry for the late reply.

Diego Nicola Barbato <dnbarbato@posteo.de> skribis:

> This patch adds inferno as discussed here:
> https://lists.gnu.org/archive/html/guix-devel/2018-10/msg00031.html

In that thread we discussed the font issue, and I=E2=80=99m unsure if it was
resolved:

  <https://lists.gnu.org/archive/html/guix-devel/2018-10/msg00265.html>

Is everything =E2=80=9Cknown good=E2=80=9D with this version of the patch?

> From c97b28e97a210cc31e34c08bc1abdc8bd74114fa Mon Sep 17 00:00:00 2001
> From: Diego Nicola Barbato <dnbarbato@posteo.de>
> Date: Wed, 17 Oct 2018 23:07:40 +0200
> Subject: [PATCH] gnu: Add inferno.
>
> * gnu/packages/inferno.scm: New file.
> * gnu/local.mk (GNU_SYSTEM_MODULES): Register it.

Overall it LGTM!  Minor suggestions here:

> +         #:phases
> +         (let* ((bash (assoc-ref %build-inputs "bash"))
> +                (objtype ,@(match (%current-system)
> +                             ((or "armhf-linux" "aarch64-linux")
> +                              `("arm"))
> +                             (_
> +                              `("386"))))
> +                (out (assoc-ref %outputs "out"))
> +                (root (string-append out "/share/inferno"))
> +                (root/bindir (string-append root "/Linux/"
> +                                            objtype "/bin"))
> +                (bindir (string-append out "/bin"))
> +                (infwm-script (string-append bindir "/infwm")))
> +           `(,(assoc 'set-paths %standard-phases)
> +             (unpack . ,(lambda* (#:key source #:allow-other-keys)

For consistency, I would very much prefer if we could use
=E2=80=98modify-phases=E2=80=99 here, which is what is used throughout gnu/=
packages.
If that=E2=80=99s fine with you, could you update the patch?

> +      (synopsis
> +       "Compact operating system for building cross-platform distributed=
 systems")

Maybe shorten to =E2=80=9COperating system for building distributed systems=
=E2=80=9D?

Thanks!

Ludo=E2=80=99.