unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: swedebugia <swedebugia@riseup.net>
Cc: rekado@elephly.net, 33329@debbugs.gnu.org
Subject: [bug#33329] [PATCH] gnu: Deprecate linux-module shpchp and tell user to remove it.
Date: Sun, 11 Nov 2018 12:32:35 +0100	[thread overview]
Message-ID: <87lg5zu9ws.fsf@gnu.org> (raw)
In-Reply-To: <dae167e0-c817-ee08-2fa1-4f99427731b4@riseup.net> (swedebugia's message of "Sun, 11 Nov 2018 08:27:59 +0100")

swedebugia <swedebugia@riseup.net> skribis:

> On 2018-11-11 01:15, Brett Gilio wrote:
>>
>> Ludovic Courtès writes:
>>
>>> If anything, what should be improved IMO is the error message you get
>>> when specifying a module that is unavailable.  That’s not easily done
>>> though since that happens at build time.
>>
>> I think Ludo is correct in this, an error message seems to be the only
>> option we have to ensure that maintainability and reproducibility are
>> respected. To add onto that, I was thinking that maybe it could be part
>> of the configuration process that we could modify to ensure that all of
>> the specified modules that are needed are available else it throws an
>> error?
>
> Ok. Would my patch have worked anyway?

I spotted a typo: (eqv? (missing 'shpchp)) is wrong because ‘eqv?’
should take two arguments and ‘missing’ is not a procedure.

Apart from this the patch could have worked I guess.

> So where would that error message be produced?
> In gnu/build/linux-modules? load-linux-modules?

An error message is produced while building the initrd; see commit
4db7a9dc663c5b26e45ec35538bf68ff87acdf7b.

For now, what about closing this issue and opening a new one when we
have an idea on how to improve on this?

Thanks,
Ludo’.

  reply	other threads:[~2018-11-11 11:33 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <87h8jbang2.fsf@elephly.net>
2018-11-09 22:47 ` [bug#33329] [PATCH] gnu: Deprecate linux-module shpchp and tell user to remove it swedebugia
2018-11-10 12:03   ` swedebugia
2018-11-10 22:31     ` Ludovic Courtès
2018-11-11  0:15       ` Brett Gilio
2018-11-11  7:27         ` swedebugia
2018-11-11 11:32           ` Ludovic Courtès [this message]
2018-11-11 18:42             ` swedebugia
2018-11-12  8:42               ` bug#33329: " Ludovic Courtès
2018-11-11 11:27         ` [bug#33329] " Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lg5zu9ws.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=33329@debbugs.gnu.org \
    --cc=rekado@elephly.net \
    --cc=swedebugia@riseup.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).