From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([209.51.188.92]:38392)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1h4vHu-0005oP-Bj
	for guix-patches@gnu.org; Fri, 15 Mar 2019 18:26:51 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1h4vCI-0000Wz-PZ
	for guix-patches@gnu.org; Fri, 15 Mar 2019 18:21:03 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:60270)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1h4vCI-0000Vv-9X
	for guix-patches@gnu.org; Fri, 15 Mar 2019 18:21:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1h4vCH-0004vv-Q1
	for guix-patches@gnu.org; Fri, 15 Mar 2019 18:21:01 -0400
Subject: [bug#34698] [PATCH] gnu: add org-noter.
Resent-Message-ID: <handler.34698.B34698.155268843718920@debbugs.gnu.org>
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
References: <20190301080758.5548-1-anothersms@gmail.com>
	<20190301080758.5548-2-anothersms@gmail.com>
Date: Fri, 15 Mar 2019 23:20:28 +0100
In-Reply-To: <20190301080758.5548-2-anothersms@gmail.com>
	("=?UTF-8?Q?Nicol=C3=B2?=
	Balzarotti"'s message of "Fri, 1 Mar 2019 09:07:52 +0100")
Message-ID: <87lg1f230z.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: =?UTF-8?Q?Nicol=C3=B2?= Balzarotti <anothersms@gmail.com>
Cc: 34698@debbugs.gnu.org

Hello,

Nicol=C3=B2 Balzarotti <anothersms@gmail.com> skribis:

> ---
>  gnu/packages/emacs-xyz.scm | 32 ++++++++++++++++++++++++++++++++
>  1 file changed, 32 insertions(+)

Could you add a commit log that follows our conventions?

> +       (method url-fetch)
> +       (uri (string-append
> +             "https://stable.melpa.org/packages/org-noter-"
> +             version
> +             ".el"))

Since files on MELPA are unversioned and regularly modified in place,
could you instead use the upstream URL (presumably the GitHub repo)?

> +    (synopsis
> +     "A synchronized, Org-mode, document annotator")
         ^
=E2=80=98guix lint=E2=80=99 probably complains about this; please remove th=
e =E2=80=9CA=E2=80=9D.

> +    (description
> +     "The idea is to let you create notes that are kept in sync when you=
 scroll through the
> +document, but that are external to it - the notes themselves live in an =
Org-mode file. As
> +such, this leverages the power of Org-mode (the notes may have outlines,=
 latex fragments,
> +babel, etc...) while acting like notes that are made /in/ the document.
> +
> +Also, I must thank Sebastian for the original idea and inspiration!
> +Link to the original Interleave package:
> +https://github.com/rudolfochrist/interleave

Please change the description to describe the package contents from the
viewpoint of an outsider.  See the guidelines at
<https://www.gnu.org/software/guix/manual/en/html_node/Synopses-and-Descrip=
tions.html>.

> +    (license license:gpl3)))

The source file header explicitly says =E2=80=9Cor any later version=E2=80=
=9D, so it
should be =E2=80=98license:gpl3+=E2=80=99.

Could you send an updated patch?

Thank you,
Ludo=E2=80=99.