From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([209.51.188.92]:47563)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1h8AWF-0003Qg-I8
	for guix-patches@gnu.org; Sun, 24 Mar 2019 17:19:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1h8AWE-0005Th-H7
	for guix-patches@gnu.org; Sun, 24 Mar 2019 17:19:03 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:43646)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1h8AWE-0005TV-AR
	for guix-patches@gnu.org; Sun, 24 Mar 2019 17:19:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1h8AWE-0004F5-0T
	for guix-patches@gnu.org; Sun, 24 Mar 2019 17:19:02 -0400
Subject: [bug#34929] [PATCH 04/12] bootloader: Add a 'keyboard-layout' field.
Resent-Message-ID: <handler.34929.B34929.155346230316258@debbugs.gnu.org>
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
References: <20190320230435.25458-1-ludo@gnu.org>
	<20190320230435.25458-4-ludo@gnu.org>
	<20190324103157.3493634f@lepiller.eu>
Date: Sun, 24 Mar 2019 22:18:11 +0100
In-Reply-To: <20190324103157.3493634f@lepiller.eu> (Julien Lepiller's message
	of "Sun, 24 Mar 2019 10:31:57 +0100")
Message-ID: <87lg14t1ik.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Julien Lepiller <julien@lepiller.eu>
Cc: 34929@debbugs.gnu.org

Hi!

Julien Lepiller <julien@lepiller.eu> skribis:

> Le Thu, 21 Mar 2019 00:04:27 +0100,
> Ludovic Court=C3=A8s <ludo@gnu.org> a =C3=A9crit :

[...]

>> +while the example below designates the b=C3=A9po layout for French:
>> +
>> +@example
>> +(keyboard-layout "fr" "bepo")
>> +@end example
>
> I think these examples are a bit confusing, because they could be
> interpreted as:
>
> (bootloader (bootloader-configuration
>                 (target "/boot/efi")
>                 (bootloader grub-efi-bootloader)
>                 (keyboard-layout "fr" "bepo")))
>
> as well as:
>
> (bootloader (bootloader-configuration
>                 (target "/boot/efi")
>                 (bootloader grub-efi-bootloader)
>                 (keyboard-layout (keyboard-layout "fr" "bepo"))))
>
> and I think you mean the second one, but the first one is the one that
> comes immediately to mind when reading the manual. Maybe you could add
> the full example?

Good point.  Actually the last patch adds a new =E2=80=9CKeyboard Layout=E2=
=80=9D
section, which I think doesn=E2=80=99t have this problem and provides a com=
plete
example.

>> +  (keyboard-layout
>> bootloader-configuration-keyboard-layout ;string | #f
>
> I think you mean "<keyboard-layout> | #f"

Good catch, thanks!

Ludo=E2=80=99.