From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:40384) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hBydH-0007Iv-TS for guix-patches@gnu.org; Thu, 04 Apr 2019 05:26:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hBydG-0003eh-MK for guix-patches@gnu.org; Thu, 04 Apr 2019 05:26:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:58385) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hBydG-0003dK-EN for guix-patches@gnu.org; Thu, 04 Apr 2019 05:26:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hBydG-0000AW-63 for guix-patches@gnu.org; Thu, 04 Apr 2019 05:26:02 -0400 Subject: [bug#35127] [PATCH] Add meritous. Resent-Message-ID: From: Nicolas Goaziou References: <87ftqzhtvz.fsf@nicolasgoaziou.fr> <87r2aiyhs6.fsf@elephly.net> Date: Thu, 04 Apr 2019 11:24:54 +0200 In-Reply-To: <87r2aiyhs6.fsf@elephly.net> (Ricardo Wurmus's message of "Wed, 03 Apr 2019 22:07:21 +0200") Message-ID: <87lg0qunq1.fsf@nicolasgoaziou.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ricardo Wurmus Cc: 35127@debbugs.gnu.org Hello, Thank you for the review. Ricardo Wurmus writes: >> + (add-after 'unpack 'fix-sdl-path >> + ;; XXX: For some reason, `sdl-config' reports stand-alone SDL >> + ;; directory, not SDL-union provided as an input to the pack= age. >> + ;; We force the latter with "--prefix=3D" option. >> + (lambda* (#:key inputs #:allow-other-keys) >> + (substitute* "Makefile" >> + (("sdl-config" command) >> + (string-append command " --prefix=3D" (assoc-ref inputs= "sdl")))) >> + #t)) > > Hmm, weird. Do you know why this happens? Is this something we can fix > in sdl-union? The Makefile uses "$(shell sdl-config --libs)" (see ). I tried to replace the sdl-config executable with its full path, i.e., (string-append (assoc-ref inputs "sdl") "/bin/sdl-config"), to no avail. Is there a problem in sdl-union? Is the `shell' call the issue? I don't know. >> + (add-after 'unpack 'fix ^^^ I replaced that with 'fix-crash >> + ;; XXX: Songs are removed due to licensing issues. However,= the >> + ;; game tries to load them, and, since it cannot find them, >> + ;; crashes. Users cannot add them back, the store being rea= d-only, >> + ;; so we turn off background music altogether. > > Oh :( > > Where are the songs removed? Should they be removed in a snippet? The songs are not in the repository. See Yet, the game tries to find them, and, AFAICT, crashes when it fails. They could be replaced with free music, but I don't think it has been done in any distribution. Also, this is just for background music. The game still provides ambient sounds. For clarity, I reworded the comment a bit: ;; XXX: Songs are not present in the repository, due to licensing ;; issues. Yet, the game tries to load them, and, since it cannot ;; find them, crashes. Users cannot add them back, the store being ;; read-only, so we turn off background music altogether. >> + (lambda _ >> + (substitute* "src/audio.c" >> + (("PlayBackgroundMusic\\(new_track\\);" all) >> + (string-append "// " all)))))))) > > Please end with #T. Oops. Done. >> + (native-inputs >> + `(("intltool" ,intltool))) >> + (inputs >> + `(("sdl" ,(sdl-union (list sdl sdl-image sdl-mixer))) >> + ("zlib" ,zlib))) >> + ;; Original home page has stalled. > > I don=E2=80=99t think =E2=80=9Cstalled=E2=80=9D is the right term. I thi= nk you can remove this > comment. The gitlab page is fine as a home page. OK. >> + (description "Far below the surface of the planet is a secret. A p= lace of >> +limitless power. > > How about =E2=80=9Ca secret place of limitless power=E2=80=9D? (=E2=80= =9Cis a secret=E2=80=9D sounds > odd to me.) > >> +Meritous is a action-adventure game with simple controls but a challeng= e to >> +find a balance of power verses recovery time during real-time >> battles. > > Should be =E2=80=9Cversus=E2=80=9D. OK. I will fix those before pushing. WDYT? Regards, --=20 Nicolas Goaziou