From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([209.51.188.92]:49303)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hQ5fs-0006K9-Ao
	for guix-patches@gnu.org; Mon, 13 May 2019 03:47:05 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hQ5fr-00035e-9i
	for guix-patches@gnu.org; Mon, 13 May 2019 03:47:04 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:58667)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1hQ5fr-00035M-4c
	for guix-patches@gnu.org; Mon, 13 May 2019 03:47:03 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hQ5fr-0001JA-27
	for guix-patches@gnu.org; Mon, 13 May 2019 03:47:03 -0400
Subject: bug#35611: [PATCH 1/2] gnu: cross-base: Allow using non-default glibc.
Resent-To: guix-patches@gnu.org
Resent-Message-ID: <handler.35611.D35611.15577335662155.done@debbugs.gnu.org>
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
References: <lIPG7Aip1kvx4dmDzDQOSQ8OGS0G9_f3COv4CgIvX_FKd56k9096gjgd2FrXPGXcO4scp8HrRHMpEipnDtjOGI0MwCep2Vi3r-utcOX2eG8=@carldong.me>
	<87woivs660.fsf@gnu.org>
	<O0Vs2q0_-33GQP3OOX7WdpAtozqA5khmB2tPcndkUAbxZaWBx8eRpFIu7Yx82YNoUv5SpAq6AJU-277Q__Wl5pOk-qiiH9JhTkbp-OlpnrM=@carldong.me>
Date: Mon, 13 May 2019 09:45:56 +0200
In-Reply-To: <O0Vs2q0_-33GQP3OOX7WdpAtozqA5khmB2tPcndkUAbxZaWBx8eRpFIu7Yx82YNoUv5SpAq6AJU-277Q__Wl5pOk-qiiH9JhTkbp-OlpnrM=@carldong.me>
	(Carl Dong's message of "Mon, 13 May 2019 02:46:39 +0000")
Message-ID: <87lfzavlu3.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Carl Dong <accounts@carldong.me>
Cc: "35611@debbugs.gnu.org" <35611-done@debbugs.gnu.org>

Hi Carl,

Carl Dong <accounts@carldong.me> skribis:

>> Really a detail, but for clarity I would change =E2=80=9Cxlibc=E2=80=9D =
to =E2=80=9Clibc=E2=80=9D, because
>> this argument denotes a C library, not a cross-compiled C library.
>>
>> Ditto in other places.
>>
>> You can send an updated patch or I can make this change on your behalf i=
f you
>> prefer, let me know!
>
> Ah yes! That does make it more clear. Could you make this change for me? =
Thanks!

Done!

>> This procedure is starting to look weird. :-) I wonder if we should inli=
ne it
>> at the call sites, but we can look into it later.
>
> Haha that's what I thought too... Inlining would probably make the most s=
ense.
> I'll submit another patch to this effect at some point!

Awesome.  :-)

Thank you!

Ludo=E2=80=99.